encounter/SDL
1
0
Fork 0
mirror of https://github.com/encounter/SDL.git synced 2025-05-18 21:31:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

joystick: Fix rumble issues on PS5 HIDAPI controllers

Browse Source 
We were returning the report size from HIDAPI_DriverPS5_RumbleJoystick() rather
than 0 upon success, causing SDL_JoystickRumble() (and callers) to think that
rumbling failed.

This didn't cause major problems until 1868c5b, when it started preventing
rumble state from being persisted in the joystick core, even though it was
successfully sent to the hardware.

This led to all sorts of strangeness, including broken rumble duration and
attempts to stop rumble being discarded.
This commit is contained in:
Cameron Gutman 2022-03-30 18:33:38 -05:00
parent 7e15ad2fc4
commit 2c04df8d65
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/joystick/hidapi/SDL_hidapi_ps5.c
View File

@ -747,7 +747,11 @@ HIDAPI_DriverPS5_SendJoystickEffect(SDL_HIDAPI_Device *device, SDL_Joystick *joy
} }
} }
return SDL_HIDAPI_SendRumbleAndUnlock(device, data, report_size); if (SDL_HIDAPI_SendRumbleAndUnlock(device, data, report_size) != report_size) {
return -1;
}
return 0;
} }
static int static int