encounter
/
SDL
mirror of https://github.com/encounter/SDL.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed incorrect modifier keys handling on macOS 

(cherry-picked from commit 45a58b7882a253db29b1b1393bc2a1fe030d5955)
This commit is contained in:
Deve 2023-03-08 23:57:08 +01:00 committed by Ozkan Sezer
parent 1723e93a0c
commit 54ca4d3879
1 changed files with 49 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

88
src/video/cocoa/SDL_cocoakeyboard.m
View File

@ -182,48 +182,58 @@
@end @end
static void static bool IsModifierKeyPressed(unsigned int flags,
HandleModifiers(_THIS, unsigned short scancode, unsigned int modifierFlags) unsigned int target_mask,
unsigned int other_mask,
unsigned int either_mask)
{ {
SDL_Scancode code = darwin_scancode_table[scancode]; bool target_pressed = (flags & target_mask) != 0;
bool other_pressed = (flags & other_mask) != 0;
bool either_pressed = (flags & either_mask) != 0;
const SDL_Scancode codes[] = { if (either_pressed != (target_pressed || other_pressed))
SDL_SCANCODE_LSHIFT, return either_pressed;
SDL_SCANCODE_LCTRL,
SDL_SCANCODE_LALT,
SDL_SCANCODE_LGUI,
SDL_SCANCODE_RSHIFT,
SDL_SCANCODE_RCTRL,
SDL_SCANCODE_RALT,
SDL_SCANCODE_RGUI,
SDL_SCANCODE_LSHIFT,
SDL_SCANCODE_LCTRL,
SDL_SCANCODE_LALT,
SDL_SCANCODE_LGUI, };
const unsigned int modifiers[] = { return target_pressed;
NX_DEVICELSHIFTKEYMASK, }
NX_DEVICELCTLKEYMASK,
NX_DEVICELALTKEYMASK,
NX_DEVICELCMDKEYMASK,
NX_DEVICERSHIFTKEYMASK,
NX_DEVICERCTLKEYMASK,
NX_DEVICERALTKEYMASK,
NX_DEVICERCMDKEYMASK,
NX_SHIFTMASK,
NX_CONTROLMASK,
NX_ALTERNATEMASK,
NX_COMMANDMASK };
for (int i = 0; i < 12; i++) static void
{ HandleModifiers(_THIS, SDL_Scancode code, unsigned int modifierFlags)
if (code == codes[i]) {
{ bool pressed = false;
if (modifierFlags & modifiers[i])
SDL_SendKeyboardKey(SDL_PRESSED, code); if (code == SDL_SCANCODE_LSHIFT) {
else pressed = IsModifierKeyPressed(modifierFlags, NX_DEVICELSHIFTKEYMASK,
SDL_SendKeyboardKey(SDL_RELEASED, code); NX_DEVICERSHIFTKEYMASK, NX_SHIFTMASK);
} } else if (code == SDL_SCANCODE_LCTRL) {
pressed = IsModifierKeyPressed(modifierFlags, NX_DEVICELCTLKEYMASK,
NX_DEVICERCTLKEYMASK, NX_CONTROLMASK);
} else if (code == SDL_SCANCODE_LALT) {
pressed = IsModifierKeyPressed(modifierFlags, NX_DEVICELALTKEYMASK,
NX_DEVICERALTKEYMASK, NX_ALTERNATEMASK);
} else if (code == SDL_SCANCODE_LGUI) {
pressed = IsModifierKeyPressed(modifierFlags, NX_DEVICELCMDKEYMASK,
NX_DEVICERCMDKEYMASK, NX_COMMANDMASK);
} else if (code == SDL_SCANCODE_RSHIFT) {
pressed = IsModifierKeyPressed(modifierFlags, NX_DEVICERSHIFTKEYMASK,
NX_DEVICELSHIFTKEYMASK, NX_SHIFTMASK);
} else if (code == SDL_SCANCODE_RCTRL) {
pressed = IsModifierKeyPressed(modifierFlags, NX_DEVICERCTLKEYMASK,
NX_DEVICELCTLKEYMASK, NX_CONTROLMASK);
} else if (code == SDL_SCANCODE_RALT) {
pressed = IsModifierKeyPressed(modifierFlags, NX_DEVICERALTKEYMASK,
NX_DEVICELALTKEYMASK, NX_ALTERNATEMASK);
} else if (code == SDL_SCANCODE_RGUI) {
pressed = IsModifierKeyPressed(modifierFlags, NX_DEVICERCMDKEYMASK,
NX_DEVICELCMDKEYMASK, NX_COMMANDMASK);
} else {
return;
}
if (pressed) {
SDL_SendKeyboardKey(SDL_PRESSED, code);
} else {
SDL_SendKeyboardKey(SDL_RELEASED, code);
} }
} }
@ -424,7 +434,7 @@ Cocoa_HandleKeyEvent(_THIS, NSEvent *event)
SDL_SendKeyboardKey(SDL_RELEASED, code); SDL_SendKeyboardKey(SDL_RELEASED, code);
break; break;
case NSEventTypeFlagsChanged: case NSEventTypeFlagsChanged:
HandleModifiers(_this, scancode, (unsigned int)[event modifierFlags]); HandleModifiers(_this, code, (unsigned int)[event modifierFlags]);
break; break;
default: /* just to avoid compiler warnings */ default: /* just to avoid compiler warnings */
break; break;