encounter
/
SDL
mirror of https://github.com/encounter/SDL.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed invalid read when SDL_GameControllerSetPlayerIndex() is passed a negative player_index

This commit is contained in:
Sam Lantinga 2022-08-09 00:19:02 -07:00
parent df537a7c0e
commit 55882e43c4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/joystick/SDL_joystick.c
View File

@ -186,7 +186,7 @@ SDL_SetJoystickIDForPlayerIndex(int player_index, SDL_JoystickID instance_id)
SDL_joystick_players = new_players; SDL_joystick_players = new_players;
SDL_memset(&SDL_joystick_players[SDL_joystick_player_count], 0xFF, (player_index - SDL_joystick_player_count + 1) * sizeof(SDL_joystick_players[0])); SDL_memset(&SDL_joystick_players[SDL_joystick_player_count], 0xFF, (player_index - SDL_joystick_player_count + 1) * sizeof(SDL_joystick_players[0]));
SDL_joystick_player_count = player_index + 1; SDL_joystick_player_count = player_index + 1;
} else if (SDL_joystick_players[player_index] == instance_id) { } else if (player_index >= 0 && SDL_joystick_players[player_index] == instance_id) {
/* Joystick is already assigned the requested player index */ /* Joystick is already assigned the requested player index */
return SDL_TRUE; return SDL_TRUE;
} }