SDL_SetHintWithPriority: actually, this test is good.

Otherwise, we end up calling the callback if both the old and new value
are NULL.

This reverts commit 5f25a6ea78 (and also
trims some whitespace).
This commit is contained in:
Ryan C. Gordon 2022-06-06 10:54:16 -04:00
parent 30cf26e089
commit 9703f23663
No known key found for this signature in database
GPG Key ID: FA148B892AB48044
1 changed files with 1 additions and 1 deletions

View File

@ -66,7 +66,7 @@ SDL_SetHintWithPriority(const char *name, const char *value,
if (priority < hint->priority) { if (priority < hint->priority) {
return SDL_FALSE; return SDL_FALSE;
} }
if (!hint->value || !value || SDL_strcmp(hint->value, value) != 0) { if (((hint->value == NULL) != (value == NULL)) || (value && (SDL_strcmp(hint->value, value) != 0))) {
for (entry = hint->callbacks; entry; ) { for (entry = hint->callbacks; entry; ) {
/* Save the next entry in case this one is deleted */ /* Save the next entry in case this one is deleted */
SDL_HintWatch *next = entry->next; SDL_HintWatch *next = entry->next;