encounter
/
SDL
mirror of https://github.com/encounter/SDL.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cocoa: Don't change the NSWindow background color. 

Changing the background color causes the titlebar to blend against it on
modern macOS releases, making all SDL windows look wrong by default. This was
set to make the window not flash white before a GL context is ready, but we
can accomplish this in our window's view's drawRect implementation, too.
This commit is contained in:
Ryan C. Gordon 2017-10-25 18:02:11 -04:00
parent 8fd0c22adc
commit 9bbf92e3da
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/video/cocoa/SDL_cocoawindow.m
View File

@ -1152,6 +1152,11 @@ SetWindowStyle(SDL_Window * window, NSUInteger style)
- (void)drawRect:(NSRect)dirtyRect - (void)drawRect:(NSRect)dirtyRect
{ {
/* Force the graphics context to clear to black so we don't get a flash of
white until the app is ready to draw. In practice on modern macOS, this
only gets called for window creation and other extraordinary events. */
[[NSColor blackColor] setFill];
NSRectFill(dirtyRect);
SDL_SendWindowEvent(_sdlWindow, SDL_WINDOWEVENT_EXPOSED, 0, 0); SDL_SendWindowEvent(_sdlWindow, SDL_WINDOWEVENT_EXPOSED, 0, 0);
} }
@ -1316,7 +1321,6 @@ Cocoa_CreateWindow(_THIS, SDL_Window * window)
@catch (NSException *e) { @catch (NSException *e) {
return SDL_SetError("%s", [[e reason] UTF8String]); return SDL_SetError("%s", [[e reason] UTF8String]);
} }
[nswindow setBackgroundColor:[NSColor blackColor]];
if (videodata->allow_spaces) { if (videodata->allow_spaces) {
SDL_assert(floor(NSAppKitVersionNumber) > NSAppKitVersionNumber10_6); SDL_assert(floor(NSAppKitVersionNumber) > NSAppKitVersionNumber10_6);