encounter
/
SDL
mirror of https://github.com/encounter/SDL.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed signedness issue when blitting on a big endian platform, as reported by capehill 

For example, if sR is 0 and dR is 255, we will get -255*sA casted to an unsigned value. Basically results are quite large numbers instead of the expected 0-255 range.
This commit is contained in:
Sam Lantinga 2017-01-05 08:16:39 -08:00
parent e6e6613ca4
commit d024c724d1
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/video/SDL_blit.h
View File

@ -443,19 +443,19 @@ do { \
/* Blend the RGB values of two pixels with an alpha value */ /* Blend the RGB values of two pixels with an alpha value */
#define ALPHA_BLEND_RGB(sR, sG, sB, A, dR, dG, dB) \ #define ALPHA_BLEND_RGB(sR, sG, sB, A, dR, dG, dB) \
do { \ do { \
dR = ((((unsigned)(sR-dR)*(unsigned)A)/255)+dR); \ dR = (Uint8)((((int)(sR-dR)*A)/255)+dR); \
dG = ((((unsigned)(sG-dG)*(unsigned)A)/255)+dG); \ dG = (Uint8)((((int)(sG-dG)*A)/255)+dG); \
dB = ((((unsigned)(sB-dB)*(unsigned)A)/255)+dB); \ dB = (Uint8)((((int)(sB-dB)*A)/255)+dB); \
} while(0) } while(0)
/* Blend the RGBA values of two pixels */ /* Blend the RGBA values of two pixels */
#define ALPHA_BLEND_RGBA(sR, sG, sB, sA, dR, dG, dB, dA) \ #define ALPHA_BLEND_RGBA(sR, sG, sB, sA, dR, dG, dB, dA) \
do { \ do { \
dR = ((((unsigned)(sR-dR)*(unsigned)sA)/255)+dR); \ dR = (Uint8)((((int)(sR-dR)*sA)/255)+dR); \
dG = ((((unsigned)(sG-dG)*(unsigned)sA)/255)+dG); \ dG = (Uint8)((((int)(sG-dG)*sA)/255)+dG); \
dB = ((((unsigned)(sB-dB)*(unsigned)sA)/255)+dB); \ dB = (Uint8)((((int)(sB-dB)*sA)/255)+dB); \
dA = ((unsigned)sA+(unsigned)dA-((unsigned)sA*dA)/255); \ dA = (Uint8)((int)sA+dA-((int)sA*dA)/255); \
} while(0) } while(0)