encounter
/
SDL
mirror of https://github.com/encounter/SDL.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

unix: OpenURL: Move unsetenv above vfork 

From the vfork manpage:

> The  vfork()  function has the same effect as fork(2), except that
> the behavior is undefined if the process created by vfork() either
> modifies any data other than a variable of type pid_t used to store
> the return value from vfork(), or returns from the function in which
> vfork() was called, or calls any other function before successfully
> calling _exit(2) or one of the exec(3) family of functions.

unsetenv is still called inside a child process, so it does not
influence the rest of the application.
This commit is contained in:
Sebastian Krzyszkowiak 2021-08-01 09:15:26 +02:00 committed by Sam Lantinga
parent 9b7b928765
commit d4e1b4974a
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/misc/unix/SDL_sysurl.c
View File

@ -33,11 +33,12 @@ SDL_SYS_OpenURL(const char *url)
{ {
const pid_t pid1 = fork(); const pid_t pid1 = fork();
if (pid1 == 0) { /* child process */ if (pid1 == 0) { /* child process */
/* Notice this is vfork and not fork! */ pid_t pid2;
const pid_t pid2 = vfork();
if (pid2 == 0) { /* Grandchild process will try to launch the url */
/* Clear LD_PRELOAD so Chrome opens correctly when this application is launched by Steam */ /* Clear LD_PRELOAD so Chrome opens correctly when this application is launched by Steam */
unsetenv("LD_PRELOAD"); unsetenv("LD_PRELOAD");
/* Notice this is vfork and not fork! */
pid2 = vfork();
if (pid2 == 0) { /* Grandchild process will try to launch the url */
execlp("xdg-open", "xdg-open", url, NULL); execlp("xdg-open", "xdg-open", url, NULL);
_exit(EXIT_FAILURE); _exit(EXIT_FAILURE);
} else if (pid2 < 0) { /* There was an error forking */ } else if (pid2 < 0) { /* There was an error forking */