encounter
/
SDL
mirror of https://github.com/encounter/SDL.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed bug 5168 - Memory leak in RAWINPUT_JoystickOpen 

meyraud705

Variable 'hwdata' is not freed in RAWINPUT_JoystickOpen if device->driver->OpenJoystick() fails.
This commit is contained in:
Sam Lantinga 2020-06-02 17:08:31 -07:00
parent 134362e745
commit eea0b0e088
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/joystick/windows/SDL_rawinputjoystick.c
View File

@ -592,8 +592,8 @@ RAWINPUT_JoystickOpen(SDL_Joystick * joystick, int device_index)
}
if (!device->driver->OpenJoystick(&device->hiddevice, joystick)) {
/* Only possible error is out of memory */
return SDL_OutOfMemory();
SDL_free(hwdata);
return -1;
}
hwdata->reserved = (void*)-1; /* crash if some code slips by that tries to use this */