encounter/SDL - SDL - AxioDL Git

Commit Graph

Author	SHA1	Message	Date
Ryan C. Gordon	fa8c83c1c1	Remove almost all instances of "volatile" keyword. As Tiffany pointed out in Bugzilla, volatile is not useful for thread safety: https://software.intel.com/en-us/blogs/2007/11/30/volatile-almost-useless-for-multi-threaded-programming/ Some of these volatiles didn't need to be, some were otherwise protected by spinlocks or mutexes, and some got moved over to SDL_atomic_t data, etc. Fixes Bugzilla #3220.	2016-01-03 06:50:50 -05:00
Sam Lantinga	42065e785d	Updated copyright to 2016	2016-01-02 10:10:34 -08:00
Philipp Wiesemann	0e45984fa0	Fixed crash if initialization of EGL failed but was tried again later. The internal function SDL_EGL_LoadLibrary() did not delete and remove a mostly uninitialized data structure if loading the library first failed. A later try to use EGL then skipped initialization and assumed it was previously successful because the data structure now already existed. This led to at least one crash in the internal function SDL_EGL_ChooseConfig() because a NULL pointer was dereferenced to make a call to eglBindAPI().	2015-06-21 17:33:46 +02:00

Author

SHA1

Message

Date

Ryan C. Gordon

fa8c83c1c1

Remove almost all instances of "volatile" keyword.

As Tiffany pointed out in Bugzilla, volatile is not useful for thread safety:

https://software.intel.com/en-us/blogs/2007/11/30/volatile-almost-useless-for-multi-threaded-programming/

Some of these volatiles didn't need to be, some were otherwise protected by
spinlocks or mutexes, and some got moved over to SDL_atomic_t data, etc.

Fixes Bugzilla #3220.

2016-01-03 06:50:50 -05:00

Sam Lantinga

42065e785d

Updated copyright to 2016

2016-01-02 10:10:34 -08:00

Philipp Wiesemann

0e45984fa0

Fixed crash if initialization of EGL failed but was tried again later.

The internal function SDL_EGL_LoadLibrary() did not delete and remove a mostly
uninitialized data structure if loading the library first failed. A later try to
use EGL then skipped initialization and assumed it was previously successful
because the data structure now already existed. This led to at least one crash
in the internal function SDL_EGL_ChooseConfig() because a NULL pointer was
dereferenced to make a call to eglBindAPI().

2015-06-21 17:33:46 +02:00

3 Commits