mirror of https://github.com/encounter/SDL.git
ec58a817ef
Most of these are probably harmless, but the changes to SDL_immdevice.c and SDL_pixels.c appear to have fixed genuine bugs. SDL_audiocvt.c: By separating the calculation of the divisor, I got rid of the suspicion that dividing a double by an integer led to loss of precision. SDL_immdevice.c: Added a missing test, one that could have otherwise led to dereferencing a null pointer. SDL_events.c, SDL_gamecontroller.c, SDL_joystick.c, SDL_malloc.c, SDL_video.c: Made it clear the return values weren't used. SDL_hidapi_shield.c: The size is zero, so nothing bad would have happened, but the SDL_memset() was still being given an address outside of the array's range. SDL_dinputjoystick.c: Initialize local data, just in case IDirectInputDevice8_GetProperty() isn't guaranteed to write to it. SDL_render_sw.c: drawstate.viewport could be null (as seen on line 691). SDL.c: SDL_MostSignificantBitIndex32() could return -1, though I don't know if you want to cope with that (what I did) or SDL_assert() that it can't happen. SDL_hints.c: Replaced boolean tests on pointer values with comparisons to NULL. SDL_pixels.c: Looks like the switch is genuinely missing a break! SDL_rect_impl.h: The MacOS static checker pointed out issues with the X comparisons that were handled by assertions; I added assertions for the Y comparisons. SDL_yuv.c, SDL_windowskeyboard.c, SDL_windowswindow.c: Checked error-result returns. |
||
|---|---|---|
| .. | ||
| SDL_blendfillrect.c | ||
| SDL_blendfillrect.h | ||
| SDL_blendline.c | ||
| SDL_blendline.h | ||
| SDL_blendpoint.c | ||
| SDL_blendpoint.h | ||
| SDL_draw.h | ||
| SDL_drawline.c | ||
| SDL_drawline.h | ||
| SDL_drawpoint.c | ||
| SDL_drawpoint.h | ||
| SDL_render_sw.c | ||
| SDL_render_sw_c.h | ||
| SDL_rotate.c | ||
| SDL_rotate.h | ||
| SDL_triangle.c | ||
| SDL_triangle.h | ||