dawn-cmake/src/utils/Glfw3Fuchsia.cpp

101 lines
3.5 KiB
C++
Raw Normal View History

Enable Vulkan for Chromium Fuchsia build. Enable the Vulkan backend when building Dawn with the Chromium build system for Fuchsia. To make this work properly the following is required: - Modify VulkanInfo.cpp and BackendVk.cpp to correctly probe the Fuchsia swapchain layer and its layer extension, as well as enabling them when creating a new VkInstance. - Modify VulkanFunctions.cpp to load the Fuchsia swapchain related extension for this platform only. - Provide a small mock GLFW library for Fuchsia under src/utils/Glfw3Fuchsia.cpp, since the upstream project does not support this platform at all. Its purpose is only to allow the creation of the right VulkanBinding instance, which depends on the creation of a display surface for latter swapchain creation. - Add //third_party/fuchsia-sdk:vulkan_base and //third_party/fuchsia-sdk:vulkan_validation as data_deps of the libdawn_native_sources target in order to ensure that the Fuchsia package created by the build system will include the correct Vulkan libraries (loader and validation layers). This builds correctly, and both dawn_unittests and dawn_end2end_tests will run on a real Fuchsia device or inside the Fuchsia emulator, using either GPU virtualization or a software-based renderer. Note: dawn_unittests will also run inside QEMU, but not dawn_end2end_tests, since the latter requires proper GPU emulation which is not available in this environment. NOTE: All end2end tests pass using a device with an "Intel HD Graphics 615 (Kaby Lake GT2)" adapter. However: - For some reason, a single test takes up to 129 seconds to pass (BufferSetSubDataTests.ManySetSubData/Vulkan). - The test process crashes inside VkDestroyInstance(), apparently inside the Fuchsia-specific imagepipe layer (which implements swapchain support). This is likely a bug in the layer itself, and not Dawn. Also, may end2end tests will crash when run inside the Fuchsia emulator (which uses GPU virtualization to talk to the host GPU). The crashes happen inside libvulkan-goldfish.so, the emulator-specific Vulkan ICD on this sytem. Not a Dawn bug either. Bug=dawn:221 Change-Id: Id3598b673e8c6393f24db728b8da49fdde3cac76 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8963 Commit-Queue: David Turner <digit@google.com> Reviewed-by: Austin Eng <enga@chromium.org>
2019-09-09 10:52:08 +00:00
// Copyright 2019 The Dawn Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// A mock GLFW implementation that supports Fuchsia, but only implements
// the functions called from Dawn.
// NOTE: This must be included before GLFW/glfw3.h because the latter will
// include <vulkan/vulkan.h> and "common/vulkan_platform.h" wants to be
// the first header to do so for sanity reasons (e.g. undefining weird
// macros on Windows and Linux).
// clang-format off
#include "common/vulkan_platform.h"
#include "common/Assert.h"
#include <GLFW/glfw3.h>
// clang-format on
#include <dlfcn.h>
int glfwInit(void) {
return GLFW_TRUE;
}
void glfwDefaultWindowHints(void) {
}
void glfwWindowHint(int hint, int value) {
DAWN_UNUSED(hint);
DAWN_UNUSED(value);
}
struct GLFWwindow {
PFN_vkGetInstanceProcAddr GetInstanceProcAddress = nullptr;
void* vulkan_loader = nullptr;
GLFWwindow() {
vulkan_loader = ::dlopen("libvulkan.so", RTLD_NOW);
ASSERT(vulkan_loader != nullptr);
GetInstanceProcAddress = reinterpret_cast<PFN_vkGetInstanceProcAddr>(
dlsym(vulkan_loader, "vkGetInstanceProcAddr"));
ASSERT(GetInstanceProcAddress != nullptr);
}
~GLFWwindow() {
if (vulkan_loader) {
::dlclose(vulkan_loader);
}
vulkan_loader = nullptr;
}
};
GLFWwindow* glfwCreateWindow(int width,
int height,
const char* title,
GLFWmonitor* monitor,
GLFWwindow* share) {
ASSERT(monitor == nullptr);
ASSERT(share == nullptr);
DAWN_UNUSED(width);
DAWN_UNUSED(height);
DAWN_UNUSED(title);
return new GLFWwindow();
}
VkResult glfwCreateWindowSurface(VkInstance instance,
GLFWwindow* window,
const VkAllocationCallbacks* allocator,
VkSurfaceKHR* surface) {
// IMPORTANT: This assumes that the VkInstance was created with a Fuchsia
// swapchain layer enabled, as well as the corresponding extension that
// is queried here to perform the surface creation. Dawn should do all
// required steps in VulkanInfo.cpp, VulkanFunctions.cpp and BackendVk.cpp.
auto vkCreateImagePipeSurfaceFUCHSIA = reinterpret_cast<PFN_vkCreateImagePipeSurfaceFUCHSIA>(
window->GetInstanceProcAddress(instance, "vkCreateImagePipeSurfaceFUCHSIA"));
ASSERT(vkCreateImagePipeSurfaceFUCHSIA != nullptr);
if (!vkCreateImagePipeSurfaceFUCHSIA) {
*surface = VK_NULL_HANDLE;
return VK_ERROR_FEATURE_NOT_PRESENT;
}
const struct VkImagePipeSurfaceCreateInfoFUCHSIA create_info = {
VK_STRUCTURE_TYPE_IMAGEPIPE_SURFACE_CREATE_INFO_FUCHSIA,
nullptr, // pNext
0, // flags, ignored for now
ZX_HANDLE_INVALID, // imagePipeHandle, a null handle matches the framebuffer.
};
return vkCreateImagePipeSurfaceFUCHSIA(instance, &create_info, nullptr, surface);
}