encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
dawn-cmake/src/intrinsic_table_test.cc

505 lines
23 KiB
C++
Raw Normal View History

IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
// Copyright 2021 The Tint Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "src/intrinsic_table.h"
#include "gmock/gmock.h"
#include "src/program_builder.h"
#include "src/type/access_control_type.h"
#include "src/type/depth_texture_type.h"
#include "src/type/multisampled_texture_type.h"
#include "src/type/sampled_texture_type.h"
#include "src/type/storage_texture_type.h"
namespace tint {
namespace {
using ::testing::ElementsAre;
using ::testing::HasSubstr;
Rename semantic to sem * Rename namespace semantic to sem * Rename directory src/semantic/ to src/sem/ Bug: tint:724 Change-Id: I76383b821fbca7f1037a803c497b595a706dcb06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48120 Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-04-16 19:07:51 +00:00
using IntrinsicType = sem::IntrinsicType;
using Parameter = sem::Parameter;
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
class IntrinsicTableTest : public testing::Test, public ProgramBuilder {
public:
std::unique_ptr<IntrinsicTable> table = IntrinsicTable::Create();
};
TEST_F(IntrinsicTableTest, MatchF32) {
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result = table->Lookup(*this, IntrinsicType::kCos, {ty.f32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kCos);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.f32());
EXPECT_THAT(result.intrinsic->Parameters(), ElementsAre(Parameter{ty.f32()}));
}
TEST_F(IntrinsicTableTest, MismatchF32) {
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result = table->Lookup(*this, IntrinsicType::kCos, {ty.i32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_EQ(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_THAT(result.diagnostics.str(), HasSubstr("no matching call"));
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
}
TEST_F(IntrinsicTableTest, MatchU32) {
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result = table->Lookup(*this, IntrinsicType::kUnpack2x16Float,
{ty.u32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kUnpack2x16Float);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.vec2<f32>());
EXPECT_THAT(result.intrinsic->Parameters(), ElementsAre(Parameter{ty.u32()}));
}
TEST_F(IntrinsicTableTest, MismatchU32) {
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result = table->Lookup(*this, IntrinsicType::kUnpack2x16Float,
{ty.f32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_EQ(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_THAT(result.diagnostics.str(), HasSubstr("no matching call"));
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
}
TEST_F(IntrinsicTableTest, MatchI32) {
Move all classes from namespace `type` to namespace `sem` Bug: tint:724 Change-Id: I4eeabab9b00b6b28f61645bd95d326fb48609bf0 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48362 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 22:51:23 +00:00
auto* tex = create<sem::SampledTexture>(sem::TextureDimension::k1d, ty.f32());
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result = table->Lookup(*this, IntrinsicType::kTextureLoad,
Reland "Remove deprecated textureLoad overloads with no level param" This is a reland of cc4c22ebaa72a2365dc196c4a1496e5a36452cdc Original change's description: > Remove deprecated textureLoad overloads with no level param > > BUG=tint:516 > > Change-Id: I7004e0dbd44d703c684118136b05b84cf609c6ba > Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/42703 > Reviewed-by: Ben Clayton <bclayton@google.com> > Commit-Queue: Ryan Harrison <rharrison@chromium.org> Bug: tint:516 Change-Id: Ic52893c78046cd54575cea51c244f6df5a4f843c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/43620 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-03-02 20:31:58 +00:00
{tex, ty.i32(), ty.i32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kTextureLoad);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.vec4<f32>());
EXPECT_THAT(result.intrinsic->Parameters(),
ElementsAre(Parameter{tex, Parameter::Usage::kTexture},
Reland "Remove deprecated textureLoad overloads with no level param" This is a reland of cc4c22ebaa72a2365dc196c4a1496e5a36452cdc Original change's description: > Remove deprecated textureLoad overloads with no level param > > BUG=tint:516 > > Change-Id: I7004e0dbd44d703c684118136b05b84cf609c6ba > Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/42703 > Reviewed-by: Ben Clayton <bclayton@google.com> > Commit-Queue: Ryan Harrison <rharrison@chromium.org> Bug: tint:516 Change-Id: Ic52893c78046cd54575cea51c244f6df5a4f843c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/43620 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-03-02 20:31:58 +00:00
Parameter{ty.i32(), Parameter::Usage::kCoords},
Parameter{ty.i32(), Parameter::Usage::kLevel}));
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
}
TEST_F(IntrinsicTableTest, MismatchI32) {
Move all classes from namespace `type` to namespace `sem` Bug: tint:724 Change-Id: I4eeabab9b00b6b28f61645bd95d326fb48609bf0 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48362 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 22:51:23 +00:00
auto* tex = create<sem::SampledTexture>(sem::TextureDimension::k1d, ty.f32());
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result = table->Lookup(*this, IntrinsicType::kTextureLoad,
{tex, ty.f32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_EQ(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_THAT(result.diagnostics.str(), HasSubstr("no matching call"));
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
}
TEST_F(IntrinsicTableTest, MatchIU32AsI32) {
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result =
table->Lookup(*this, IntrinsicType::kCountOneBits, {ty.i32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kCountOneBits);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.i32());
EXPECT_THAT(result.intrinsic->Parameters(), ElementsAre(Parameter{ty.i32()}));
}
TEST_F(IntrinsicTableTest, MatchIU32AsU32) {
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result =
table->Lookup(*this, IntrinsicType::kCountOneBits, {ty.u32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kCountOneBits);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.u32());
EXPECT_THAT(result.intrinsic->Parameters(), ElementsAre(Parameter{ty.u32()}));
}
TEST_F(IntrinsicTableTest, MismatchIU32) {
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result =
table->Lookup(*this, IntrinsicType::kCountOneBits, {ty.f32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_EQ(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_THAT(result.diagnostics.str(), HasSubstr("no matching call"));
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
}
TEST_F(IntrinsicTableTest, MatchFIU32AsI32) {
auto result = table->Lookup(*this, IntrinsicType::kClamp,
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
{ty.i32(), ty.i32(), ty.i32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kClamp);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.i32());
EXPECT_THAT(result.intrinsic->Parameters(),
ElementsAre(Parameter{ty.i32()}, Parameter{ty.i32()},
Parameter{ty.i32()}));
}
TEST_F(IntrinsicTableTest, MatchFIU32AsU32) {
auto result = table->Lookup(*this, IntrinsicType::kClamp,
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
{ty.u32(), ty.u32(), ty.u32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kClamp);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.u32());
EXPECT_THAT(result.intrinsic->Parameters(),
ElementsAre(Parameter{ty.u32()}, Parameter{ty.u32()},
Parameter{ty.u32()}));
}
TEST_F(IntrinsicTableTest, MatchFIU32AsF32) {
auto result = table->Lookup(*this, IntrinsicType::kClamp,
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
{ty.f32(), ty.f32(), ty.f32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kClamp);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.f32());
EXPECT_THAT(result.intrinsic->Parameters(),
ElementsAre(Parameter{ty.f32()}, Parameter{ty.f32()},
Parameter{ty.f32()}));
}
TEST_F(IntrinsicTableTest, MismatchFIU32) {
auto result = table->Lookup(*this, IntrinsicType::kClamp,
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
{ty.bool_(), ty.bool_(), ty.bool_()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_EQ(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_THAT(result.diagnostics.str(), HasSubstr("no matching call"));
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
}
TEST_F(IntrinsicTableTest, MatchBool) {
auto result = table->Lookup(*this, IntrinsicType::kSelect,
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
{ty.f32(), ty.f32(), ty.bool_()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kSelect);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.f32());
EXPECT_THAT(result.intrinsic->Parameters(),
ElementsAre(Parameter{ty.f32()}, Parameter{ty.f32()},
Parameter{ty.bool_()}));
}
TEST_F(IntrinsicTableTest, MismatchBool) {
auto result = table->Lookup(*this, IntrinsicType::kSelect,
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
{ty.f32(), ty.f32(), ty.f32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_EQ(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_THAT(result.diagnostics.str(), HasSubstr("no matching call"));
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
}
TEST_F(IntrinsicTableTest, MatchPointer) {
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result = table->Lookup(
*this, IntrinsicType::kModf,
{ty.f32(), ty.pointer<f32>(ast::StorageClass::kNone)}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kModf);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.f32());
EXPECT_THAT(
result.intrinsic->Parameters(),
ElementsAre(Parameter{ty.f32()},
Parameter{ty.pointer<f32>(ast::StorageClass::kNone)}));
}
TEST_F(IntrinsicTableTest, MismatchPointer) {
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result = table->Lookup(*this, IntrinsicType::kModf, {ty.f32(), ty.f32()},
Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_EQ(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_THAT(result.diagnostics.str(), HasSubstr("no matching call"));
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
}
TEST_F(IntrinsicTableTest, MatchArray) {
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result = table->Lookup(*this, IntrinsicType::kArrayLength,
{ty.array<f32>()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kArrayLength);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.u32());
EXPECT_THAT(result.intrinsic->Parameters(),
ElementsAre(Parameter{ty.array<f32>()}));
}
TEST_F(IntrinsicTableTest, MismatchArray) {
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result =
table->Lookup(*this, IntrinsicType::kArrayLength, {ty.f32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_EQ(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_THAT(result.diagnostics.str(), HasSubstr("no matching call"));
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
}
TEST_F(IntrinsicTableTest, MatchSampler) {
Move all classes from namespace `type` to namespace `sem` Bug: tint:724 Change-Id: I4eeabab9b00b6b28f61645bd95d326fb48609bf0 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48362 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 22:51:23 +00:00
auto* tex = create<sem::SampledTexture>(sem::TextureDimension::k2d, ty.f32());
auto* sampler = create<sem::Sampler>(sem::SamplerKind::kSampler);
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
auto result = table->Lookup(*this, IntrinsicType::kTextureSample,
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
{tex, sampler, ty.vec2<f32>()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kTextureSample);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.vec4<f32>());
EXPECT_THAT(
result.intrinsic->Parameters(),
ElementsAre(Parameter{tex, Parameter::Usage::kTexture},
Parameter{sampler, Parameter::Usage::kSampler},
Parameter{ty.vec2<f32>(), Parameter::Usage::kCoords}));
}
TEST_F(IntrinsicTableTest, MismatchSampler) {
Move all classes from namespace `type` to namespace `sem` Bug: tint:724 Change-Id: I4eeabab9b00b6b28f61645bd95d326fb48609bf0 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48362 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 22:51:23 +00:00
auto* tex = create<sem::SampledTexture>(sem::TextureDimension::k2d, ty.f32());
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
auto result = table->Lookup(*this, IntrinsicType::kTextureSample,
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
{tex, ty.f32(), ty.vec2<f32>()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_EQ(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_THAT(result.diagnostics.str(), HasSubstr("no matching call"));
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
}
TEST_F(IntrinsicTableTest, MatchSampledTexture) {
Move all classes from namespace `type` to namespace `sem` Bug: tint:724 Change-Id: I4eeabab9b00b6b28f61645bd95d326fb48609bf0 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48362 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 22:51:23 +00:00
auto* tex = create<sem::SampledTexture>(sem::TextureDimension::k2d, ty.f32());
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result = table->Lookup(*this, IntrinsicType::kTextureLoad,
Reland "Remove deprecated textureLoad overloads with no level param" This is a reland of cc4c22ebaa72a2365dc196c4a1496e5a36452cdc Original change's description: > Remove deprecated textureLoad overloads with no level param > > BUG=tint:516 > > Change-Id: I7004e0dbd44d703c684118136b05b84cf609c6ba > Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/42703 > Reviewed-by: Ben Clayton <bclayton@google.com> > Commit-Queue: Ryan Harrison <rharrison@chromium.org> Bug: tint:516 Change-Id: Ic52893c78046cd54575cea51c244f6df5a4f843c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/43620 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-03-02 20:31:58 +00:00
{tex, ty.vec2<i32>(), ty.i32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kTextureLoad);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.vec4<f32>());
Reland "Remove deprecated textureLoad overloads with no level param" This is a reland of cc4c22ebaa72a2365dc196c4a1496e5a36452cdc Original change's description: > Remove deprecated textureLoad overloads with no level param > > BUG=tint:516 > > Change-Id: I7004e0dbd44d703c684118136b05b84cf609c6ba > Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/42703 > Reviewed-by: Ben Clayton <bclayton@google.com> > Commit-Queue: Ryan Harrison <rharrison@chromium.org> Bug: tint:516 Change-Id: Ic52893c78046cd54575cea51c244f6df5a4f843c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/43620 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-03-02 20:31:58 +00:00
EXPECT_THAT(result.intrinsic->Parameters(),
ElementsAre(Parameter{tex, Parameter::Usage::kTexture},
Parameter{ty.vec2<i32>(), Parameter::Usage::kCoords},
Parameter{ty.i32(), Parameter::Usage::kLevel}));
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
}
TEST_F(IntrinsicTableTest, MatchMultisampledTexture) {
auto* tex =
Move all classes from namespace `type` to namespace `sem` Bug: tint:724 Change-Id: I4eeabab9b00b6b28f61645bd95d326fb48609bf0 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48362 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 22:51:23 +00:00
create<sem::MultisampledTexture>(sem::TextureDimension::k2d, ty.f32());
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
auto result = table->Lookup(*this, IntrinsicType::kTextureLoad,
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
{tex, ty.vec2<i32>(), ty.i32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kTextureLoad);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.vec4<f32>());
EXPECT_THAT(result.intrinsic->Parameters(),
ElementsAre(Parameter{tex, Parameter::Usage::kTexture},
Parameter{ty.vec2<i32>(), Parameter::Usage::kCoords},
Parameter{ty.i32(), Parameter::Usage::kSampleIndex}));
}
TEST_F(IntrinsicTableTest, MatchDepthTexture) {
Move all classes from namespace `type` to namespace `sem` Bug: tint:724 Change-Id: I4eeabab9b00b6b28f61645bd95d326fb48609bf0 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48362 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 22:51:23 +00:00
auto* tex = create<sem::DepthTexture>(sem::TextureDimension::k2d);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result = table->Lookup(*this, IntrinsicType::kTextureLoad,
Reland "Remove deprecated textureLoad overloads with no level param" This is a reland of cc4c22ebaa72a2365dc196c4a1496e5a36452cdc Original change's description: > Remove deprecated textureLoad overloads with no level param > > BUG=tint:516 > > Change-Id: I7004e0dbd44d703c684118136b05b84cf609c6ba > Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/42703 > Reviewed-by: Ben Clayton <bclayton@google.com> > Commit-Queue: Ryan Harrison <rharrison@chromium.org> Bug: tint:516 Change-Id: Ic52893c78046cd54575cea51c244f6df5a4f843c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/43620 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-03-02 20:31:58 +00:00
{tex, ty.vec2<i32>(), ty.i32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kTextureLoad);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.f32());
Reland "Remove deprecated textureLoad overloads with no level param" This is a reland of cc4c22ebaa72a2365dc196c4a1496e5a36452cdc Original change's description: > Remove deprecated textureLoad overloads with no level param > > BUG=tint:516 > > Change-Id: I7004e0dbd44d703c684118136b05b84cf609c6ba > Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/42703 > Reviewed-by: Ben Clayton <bclayton@google.com> > Commit-Queue: Ryan Harrison <rharrison@chromium.org> Bug: tint:516 Change-Id: Ic52893c78046cd54575cea51c244f6df5a4f843c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/43620 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-03-02 20:31:58 +00:00
EXPECT_THAT(result.intrinsic->Parameters(),
ElementsAre(Parameter{tex, Parameter::Usage::kTexture},
Parameter{ty.vec2<i32>(), Parameter::Usage::kCoords},
Parameter{ty.i32(), Parameter::Usage::kLevel}));
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
}
TEST_F(IntrinsicTableTest, MatchROStorageTexture) {
Move all classes from namespace `type` to namespace `sem` Bug: tint:724 Change-Id: I4eeabab9b00b6b28f61645bd95d326fb48609bf0 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48362 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 22:51:23 +00:00
auto* tex = create<sem::StorageTexture>(
sem::TextureDimension::k2d, sem::ImageFormat::kR16Float,
sem::StorageTexture::SubtypeFor(sem::ImageFormat::kR16Float, Types()));
auto* tex_ac = create<sem::AccessControl>(ast::AccessControl::kReadOnly, tex);
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
auto result = table->Lookup(*this, IntrinsicType::kTextureLoad,
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
{tex_ac, ty.vec2<i32>()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kTextureLoad);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.vec4<f32>());
EXPECT_THAT(
result.intrinsic->Parameters(),
ElementsAre(Parameter{tex_ac, Parameter::Usage::kTexture},
Parameter{ty.vec2<i32>(), Parameter::Usage::kCoords}));
}
TEST_F(IntrinsicTableTest, MatchWOStorageTexture) {
Move all classes from namespace `type` to namespace `sem` Bug: tint:724 Change-Id: I4eeabab9b00b6b28f61645bd95d326fb48609bf0 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48362 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 22:51:23 +00:00
auto* tex = create<sem::StorageTexture>(
sem::TextureDimension::k2d, sem::ImageFormat::kR16Float,
sem::StorageTexture::SubtypeFor(sem::ImageFormat::kR16Float, Types()));
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
auto* tex_ac =
Move all classes from namespace `type` to namespace `sem` Bug: tint:724 Change-Id: I4eeabab9b00b6b28f61645bd95d326fb48609bf0 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48362 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 22:51:23 +00:00
create<sem::AccessControl>(ast::AccessControl::kWriteOnly, tex);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result =
table->Lookup(*this, IntrinsicType::kTextureStore,
{tex_ac, ty.vec2<i32>(), ty.vec4<f32>()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kTextureStore);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.void_());
EXPECT_THAT(result.intrinsic->Parameters(),
ElementsAre(Parameter{tex_ac, Parameter::Usage::kTexture},
Parameter{ty.vec2<i32>(), Parameter::Usage::kCoords},
Parameter{ty.vec4<f32>(), Parameter::Usage::kValue}));
}
TEST_F(IntrinsicTableTest, MismatchTexture) {
auto result = table->Lookup(*this, IntrinsicType::kTextureLoad,
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
{ty.f32(), ty.vec2<i32>()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_EQ(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_THAT(result.diagnostics.str(), HasSubstr("no matching call"));
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
}
TEST_F(IntrinsicTableTest, MatchAutoPointerDereference) {
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result =
table->Lookup(*this, IntrinsicType::kCos,
{ty.pointer<f32>(ast::StorageClass::kNone)}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kCos);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.f32());
EXPECT_THAT(result.intrinsic->Parameters(), ElementsAre(Parameter{ty.f32()}));
}
TEST_F(IntrinsicTableTest, MatchWithAliasUnwrapping) {
auto* alias_a = ty.alias("alias_a", ty.f32());
auto* alias_b = ty.alias("alias_b", alias_a);
auto* alias_c = ty.alias("alias_c", alias_b);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result = table->Lookup(*this, IntrinsicType::kCos, {alias_c}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kCos);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.f32());
EXPECT_THAT(result.intrinsic->Parameters(), ElementsAre(Parameter{ty.f32()}));
}
Resolver: compute canonical types and store them as semantic::Variable::Type We define the canonical type as a type stripped of all aliases. For example, Canonical(alias<alias<vec3<alias<f32>>>>) is vec3<f32>. This change adds Resolver::Canonical(Type*) which caches and returns the resulting canonical type. We use this throughout the Resolver instead of UnwrapAliasIfNeeded(), and we store the result in semantic::Variable, returned from it's Type() member function. Also: * Wrote unit tests for Resolver::Canonical() * Added semantic::Variable::DeclaredType() as a convenience to retrieve the AST variable's type. * Updated post-resolve code (transforms) to make use of Type and DeclaredType appropriately, removing unnecessary calls to UnwrapAliasIfNeeded. * Added IntrinsicTableTest.MatchWithNestedAliasUnwrapping to ensure we don't need to pass canonical parameter types for instrinsic table lookups. * ProgramBuilder: added vecN and matMxN overloads that take a Type* arg to create them with alias types. Bug: tint:705 Change-Id: I58a3b62538356b8dad2b1161a19b38bcefdd5d62 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/47360 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-13 13:32:33 +00:00
TEST_F(IntrinsicTableTest, MatchWithNestedAliasUnwrapping) {
auto* alias_a = ty.alias("alias_a", ty.bool_());
auto* alias_b = ty.alias("alias_b", alias_a);
auto* alias_c = ty.alias("alias_c", alias_b);
auto* vec4_of_c = ty.vec4(alias_c);
auto* alias_d = ty.alias("alias_d", vec4_of_c);
auto* alias_e = ty.alias("alias_e", alias_d);
auto result = table->Lookup(*this, IntrinsicType::kAll, {alias_e}, Source{});
ASSERT_NE(result.intrinsic, nullptr);
ASSERT_EQ(result.diagnostics.str(), "");
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kAll);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.bool_());
EXPECT_THAT(result.intrinsic->Parameters(),
ElementsAre(Parameter{ty.vec4<bool>()}));
}
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
TEST_F(IntrinsicTableTest, MatchOpenType) {
auto result = table->Lookup(*this, IntrinsicType::kClamp,
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
{ty.f32(), ty.f32(), ty.f32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kClamp);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.f32());
EXPECT_THAT(result.intrinsic->Parameters(),
ElementsAre(Parameter{ty.f32()}, Parameter{ty.f32()},
Parameter{ty.f32()}));
}
TEST_F(IntrinsicTableTest, MismatchOpenType) {
auto result = table->Lookup(*this, IntrinsicType::kClamp,
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
{ty.f32(), ty.u32(), ty.f32()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_EQ(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_THAT(result.diagnostics.str(), HasSubstr("no matching call"));
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
}
TEST_F(IntrinsicTableTest, MatchOpenSizeVector) {
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result =
table->Lookup(*this, IntrinsicType::kClamp,
{ty.vec2<f32>(), ty.vec2<f32>(), ty.vec2<f32>()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kClamp);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.vec2<f32>());
EXPECT_THAT(result.intrinsic->Parameters(),
ElementsAre(Parameter{ty.vec2<f32>()}, Parameter{ty.vec2<f32>()},
Parameter{ty.vec2<f32>()}));
}
TEST_F(IntrinsicTableTest, MismatchOpenSizeVector) {
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result =
table->Lookup(*this, IntrinsicType::kClamp,
{ty.vec2<f32>(), ty.vec2<u32>(), ty.vec2<f32>()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_EQ(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_THAT(result.diagnostics.str(), HasSubstr("no matching call"));
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
}
TEST_F(IntrinsicTableTest, MatchOpenSizeMatrix) {
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result = table->Lookup(*this, IntrinsicType::kDeterminant,
{ty.mat3x3<f32>()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_NE(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_EQ(result.diagnostics.str(), "");
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
EXPECT_THAT(result.intrinsic->Type(), IntrinsicType::kDeterminant);
EXPECT_THAT(result.intrinsic->ReturnType(), ty.f32());
EXPECT_THAT(result.intrinsic->Parameters(),
ElementsAre(Parameter{ty.mat3x3<f32>()}));
}
TEST_F(IntrinsicTableTest, MismatchOpenSizeMatrix) {
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
auto result = table->Lookup(*this, IntrinsicType::kDeterminant,
{ty.mat3x2<f32>()}, Source{});
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
ASSERT_EQ(result.intrinsic, nullptr);
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
ASSERT_THAT(result.diagnostics.str(), HasSubstr("no matching call"));
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
}
TEST_F(IntrinsicTableTest, OverloadOrderByNumberOfParameters) {
// None of the arguments match, so expect the overloads with 2 parameters to
// come first
auto result = table->Lookup(*this, IntrinsicType::kTextureDimensions,
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
{ty.bool_(), ty.bool_()}, Source{});
ASSERT_EQ(result.diagnostics.str(),
R"(error: no matching call to textureDimensions(bool, bool)
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
Remove references 1D Array texture dimension WGSL recently removed this concept, since it didn't exist in WebGPU, so excising it from the code. BUG=tint:515 Change-Id: Ibbca6bd643fd96c2fb10bd33f471c9e9e58de535 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/42320 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2021-02-24 05:05:21 +00:00
25 candidate functions:
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
textureDimensions(texture : texture_2d<T>, level : i32) -> vec2<i32>
textureDimensions(texture : texture_2d_array<T>, level : i32) -> vec2<i32>
textureDimensions(texture : texture_3d<T>, level : i32) -> vec3<i32>
textureDimensions(texture : texture_cube<T>, level : i32) -> vec3<i32>
textureDimensions(texture : texture_cube_array<T>, level : i32) -> vec3<i32>
textureDimensions(texture : texture_depth_2d, level : i32) -> vec2<i32>
textureDimensions(texture : texture_depth_2d_array, level : i32) -> vec2<i32>
textureDimensions(texture : texture_depth_cube, level : i32) -> vec3<i32>
textureDimensions(texture : texture_depth_cube_array, level : i32) -> vec3<i32>
textureDimensions(texture : texture_1d<T>) -> i32
textureDimensions(texture : texture_2d<T>) -> vec2<i32>
textureDimensions(texture : texture_2d_array<T>) -> vec2<i32>
textureDimensions(texture : texture_3d<T>) -> vec3<i32>
textureDimensions(texture : texture_cube<T>) -> vec3<i32>
textureDimensions(texture : texture_cube_array<T>) -> vec3<i32>
textureDimensions(texture : texture_multisampled_2d<T>) -> vec2<i32>
textureDimensions(texture : texture_multisampled_2d_array<T>) -> vec2<i32>
textureDimensions(texture : texture_depth_2d) -> vec2<i32>
textureDimensions(texture : texture_depth_2d_array) -> vec2<i32>
textureDimensions(texture : texture_depth_cube) -> vec3<i32>
textureDimensions(texture : texture_depth_cube_array) -> vec3<i32>
textureDimensions(texture : texture_storage_1d<F>) -> i32
textureDimensions(texture : texture_storage_2d<F>) -> vec2<i32>
textureDimensions(texture : texture_storage_2d_array<F>) -> vec2<i32>
textureDimensions(texture : texture_storage_3d<F>) -> vec3<i32>
)");
}
TEST_F(IntrinsicTableTest, OverloadOrderByMatchingParameter) {
Move all classes from namespace `type` to namespace `sem` Bug: tint:724 Change-Id: I4eeabab9b00b6b28f61645bd95d326fb48609bf0 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48362 Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-04-19 22:51:23 +00:00
auto* tex = create<sem::DepthTexture>(sem::TextureDimension::k2d);
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
auto result = table->Lookup(*this, IntrinsicType::kTextureDimensions,
Add TINT_UNREACHABLE() and TINT_ICE() helper macros Appends an error message with the tint compiler source location to the provided diagnositic list, and then calls the global error handler if one is set. Tests and the sample app now register an error handler to print the diagnostic list to stderr and abort when NDEBUG is not defined. All uses of assert(false) have been fixed up to use these macros. Change-Id: I2f63e51ed86ac23883301d280070bd1a357c6cb2 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41620 Commit-Queue: dan sinclair <dsinclair@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-17 20:13:34 +00:00
{tex, ty.bool_()}, Source{});
ASSERT_EQ(
result.diagnostics.str(),
R"(error: no matching call to textureDimensions(texture_depth_2d, bool)
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
Remove references 1D Array texture dimension WGSL recently removed this concept, since it didn't exist in WebGPU, so excising it from the code. BUG=tint:515 Change-Id: Ibbca6bd643fd96c2fb10bd33f471c9e9e58de535 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/42320 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2021-02-24 05:05:21 +00:00
25 candidate functions:
IntrinsicTable: Fix a number of TODOs And add tests for IntrinsicTable. Drop all the type unwrapping - be precise: * Display the actual argument types in the signature mismatch message * Only dereference pointer arguments if the parameter does not expect a pointer Correctly match access control on storage types Note that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone. Fixed: tint:486 Change-Id: I239eabd1fedfc082566c4af616ccfc58786cae25 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-10 21:34:25 +00:00
textureDimensions(texture : texture_depth_2d, level : i32) -> vec2<i32>
textureDimensions(texture : texture_depth_2d) -> vec2<i32>
textureDimensions(texture : texture_2d<T>, level : i32) -> vec2<i32>
textureDimensions(texture : texture_2d_array<T>, level : i32) -> vec2<i32>
textureDimensions(texture : texture_3d<T>, level : i32) -> vec3<i32>
textureDimensions(texture : texture_cube<T>, level : i32) -> vec3<i32>
textureDimensions(texture : texture_cube_array<T>, level : i32) -> vec3<i32>
textureDimensions(texture : texture_depth_2d_array, level : i32) -> vec2<i32>
textureDimensions(texture : texture_depth_cube, level : i32) -> vec3<i32>
textureDimensions(texture : texture_depth_cube_array, level : i32) -> vec3<i32>
textureDimensions(texture : texture_1d<T>) -> i32
textureDimensions(texture : texture_2d<T>) -> vec2<i32>
textureDimensions(texture : texture_2d_array<T>) -> vec2<i32>
textureDimensions(texture : texture_3d<T>) -> vec3<i32>
textureDimensions(texture : texture_cube<T>) -> vec3<i32>
textureDimensions(texture : texture_cube_array<T>) -> vec3<i32>
textureDimensions(texture : texture_multisampled_2d<T>) -> vec2<i32>
textureDimensions(texture : texture_multisampled_2d_array<T>) -> vec2<i32>
textureDimensions(texture : texture_depth_2d_array) -> vec2<i32>
textureDimensions(texture : texture_depth_cube) -> vec3<i32>
textureDimensions(texture : texture_depth_cube_array) -> vec3<i32>
textureDimensions(texture : texture_storage_1d<F>) -> i32
textureDimensions(texture : texture_storage_2d<F>) -> vec2<i32>
textureDimensions(texture : texture_storage_2d_array<F>) -> vec2<i32>
textureDimensions(texture : texture_storage_3d<F>) -> vec3<i32>
)");
}
} // namespace
} // namespace tint