dawn-cmake/src/intrinsic_table.h

61 lines
1.9 KiB
C
Raw Normal View History

Add IntrinsicTable Provides a centeralized table for all intrinsic overloads. IntrinsicTable::Lookup() takes the intrinsic type and list of arguments, returning either the matched overload, or a sensible error message. The validator has expectations that the TypeDeterminer resolves the return type of an intrinsic call, even when the signature doesn't match. To handle this, create semantic::Intrinsic nodes even when the overload fails to match. A significant portion of the Validator's logic for handling intrinsics can be removed (future change). There are a number of benefits to migrating the TypeDeterminer and Validator over to the IntrinsicTable: * There's far less intrininsic-bespoke code to maintain (no more duplicate `kIntrinsicData` tables in TypeDeterminer and Validator). * Adding or adjusting an intrinsic overload involves adding or adjusting a single Register() line. * Error messages give helpful suggestions for related overloads when given incorrect arguments. * Error messages are consistent for all intrinsics. * Error messages are far more understandable than those produced by the TypeDeterminer. * Further improvements on the error messages produced by the IntrinsicTable will benefit _all_ the intrinsics and their overloads. * The IntrinsicTable generates correct parameter information, including whether parameters are pointers or not. * The IntrinsicTable will help with implementing autocomplete for a language server Change-Id: I4bfa88533396b0b372aef41a62fe47b738531aed Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/40504 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-08 22:42:54 +00:00
// Copyright 2021 The Tint Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#ifndef SRC_INTRINSIC_TABLE_H_
#define SRC_INTRINSIC_TABLE_H_
#include <memory>
#include <string>
#include <vector>
#include "src/sem/intrinsic.h"
Add IntrinsicTable Provides a centeralized table for all intrinsic overloads. IntrinsicTable::Lookup() takes the intrinsic type and list of arguments, returning either the matched overload, or a sensible error message. The validator has expectations that the TypeDeterminer resolves the return type of an intrinsic call, even when the signature doesn't match. To handle this, create semantic::Intrinsic nodes even when the overload fails to match. A significant portion of the Validator's logic for handling intrinsics can be removed (future change). There are a number of benefits to migrating the TypeDeterminer and Validator over to the IntrinsicTable: * There's far less intrininsic-bespoke code to maintain (no more duplicate `kIntrinsicData` tables in TypeDeterminer and Validator). * Adding or adjusting an intrinsic overload involves adding or adjusting a single Register() line. * Error messages give helpful suggestions for related overloads when given incorrect arguments. * Error messages are consistent for all intrinsics. * Error messages are far more understandable than those produced by the TypeDeterminer. * Further improvements on the error messages produced by the IntrinsicTable will benefit _all_ the intrinsics and their overloads. * The IntrinsicTable generates correct parameter information, including whether parameters are pointers or not. * The IntrinsicTable will help with implementing autocomplete for a language server Change-Id: I4bfa88533396b0b372aef41a62fe47b738531aed Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/40504 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-08 22:42:54 +00:00
namespace tint {
// Forward declarations
class ProgramBuilder;
/// IntrinsicTable is a lookup table of all the WGSL intrinsic functions
class IntrinsicTable {
public:
/// @return a pointer to a newly created IntrinsicTable
static std::unique_ptr<IntrinsicTable> Create();
/// Destructor
virtual ~IntrinsicTable();
/// Result is returned by Lookup
struct Result {
/// The intrinsic, if the lookup succeeded, otherwise nullptr
sem::Intrinsic* intrinsic;
/// Diagnostic messages
diag::List diagnostics;
Add IntrinsicTable Provides a centeralized table for all intrinsic overloads. IntrinsicTable::Lookup() takes the intrinsic type and list of arguments, returning either the matched overload, or a sensible error message. The validator has expectations that the TypeDeterminer resolves the return type of an intrinsic call, even when the signature doesn't match. To handle this, create semantic::Intrinsic nodes even when the overload fails to match. A significant portion of the Validator's logic for handling intrinsics can be removed (future change). There are a number of benefits to migrating the TypeDeterminer and Validator over to the IntrinsicTable: * There's far less intrininsic-bespoke code to maintain (no more duplicate `kIntrinsicData` tables in TypeDeterminer and Validator). * Adding or adjusting an intrinsic overload involves adding or adjusting a single Register() line. * Error messages give helpful suggestions for related overloads when given incorrect arguments. * Error messages are consistent for all intrinsics. * Error messages are far more understandable than those produced by the TypeDeterminer. * Further improvements on the error messages produced by the IntrinsicTable will benefit _all_ the intrinsics and their overloads. * The IntrinsicTable generates correct parameter information, including whether parameters are pointers or not. * The IntrinsicTable will help with implementing autocomplete for a language server Change-Id: I4bfa88533396b0b372aef41a62fe47b738531aed Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/40504 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-08 22:42:54 +00:00
};
/// Lookup looks for the intrinsic overload with the given signature.
/// @param builder the program builder
/// @param type the intrinsic type
/// @param args the argument types passed to the intrinsic function
/// @param source the source of the intrinsic call
Add IntrinsicTable Provides a centeralized table for all intrinsic overloads. IntrinsicTable::Lookup() takes the intrinsic type and list of arguments, returning either the matched overload, or a sensible error message. The validator has expectations that the TypeDeterminer resolves the return type of an intrinsic call, even when the signature doesn't match. To handle this, create semantic::Intrinsic nodes even when the overload fails to match. A significant portion of the Validator's logic for handling intrinsics can be removed (future change). There are a number of benefits to migrating the TypeDeterminer and Validator over to the IntrinsicTable: * There's far less intrininsic-bespoke code to maintain (no more duplicate `kIntrinsicData` tables in TypeDeterminer and Validator). * Adding or adjusting an intrinsic overload involves adding or adjusting a single Register() line. * Error messages give helpful suggestions for related overloads when given incorrect arguments. * Error messages are consistent for all intrinsics. * Error messages are far more understandable than those produced by the TypeDeterminer. * Further improvements on the error messages produced by the IntrinsicTable will benefit _all_ the intrinsics and their overloads. * The IntrinsicTable generates correct parameter information, including whether parameters are pointers or not. * The IntrinsicTable will help with implementing autocomplete for a language server Change-Id: I4bfa88533396b0b372aef41a62fe47b738531aed Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/40504 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-08 22:42:54 +00:00
/// @return the semantic intrinsic if found, otherwise nullptr
virtual Result Lookup(ProgramBuilder& builder,
sem::IntrinsicType type,
const std::vector<sem::Type*>& args,
const Source& source) const = 0;
Add IntrinsicTable Provides a centeralized table for all intrinsic overloads. IntrinsicTable::Lookup() takes the intrinsic type and list of arguments, returning either the matched overload, or a sensible error message. The validator has expectations that the TypeDeterminer resolves the return type of an intrinsic call, even when the signature doesn't match. To handle this, create semantic::Intrinsic nodes even when the overload fails to match. A significant portion of the Validator's logic for handling intrinsics can be removed (future change). There are a number of benefits to migrating the TypeDeterminer and Validator over to the IntrinsicTable: * There's far less intrininsic-bespoke code to maintain (no more duplicate `kIntrinsicData` tables in TypeDeterminer and Validator). * Adding or adjusting an intrinsic overload involves adding or adjusting a single Register() line. * Error messages give helpful suggestions for related overloads when given incorrect arguments. * Error messages are consistent for all intrinsics. * Error messages are far more understandable than those produced by the TypeDeterminer. * Further improvements on the error messages produced by the IntrinsicTable will benefit _all_ the intrinsics and their overloads. * The IntrinsicTable generates correct parameter information, including whether parameters are pointers or not. * The IntrinsicTable will help with implementing autocomplete for a language server Change-Id: I4bfa88533396b0b372aef41a62fe47b738531aed Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/40504 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2021-02-08 22:42:54 +00:00
};
} // namespace tint
#endif // SRC_INTRINSIC_TABLE_H_