encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
dawn-cmake/src/ast/intrinsic_texture_helper_te...

1120 lines
51 KiB
C++
Raw Normal View History

Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
// Copyright 2020 The Tint Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "src/ast/intrinsic_texture_helper_test.h"
#include "src/ast/type_constructor_expression.h"
namespace tint {
namespace ast {
namespace intrinsic {
namespace test {
TextureOverloadCase::TextureOverloadCase() = default;
TextureOverloadCase::TextureOverloadCase(
ValidTextureOverload o,
const char* d,
TextureKind tk,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind sk,
type::TextureDimension td,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType tdt,
const char* f,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
std::function<ExpressionList(Builder*)> a)
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
: overload(o),
description(d),
texture_kind(tk),
sampler_kind(sk),
texture_dimension(td),
texture_data_type(tdt),
function(f),
args(std::move(a)) {}
TextureOverloadCase::TextureOverloadCase(const TextureOverloadCase&) = default;
TextureOverloadCase::~TextureOverloadCase() = default;
std::vector<TextureOverloadCase> TextureOverloadCase::ValidCases() {
return {{
ValidTextureOverload::kSample1dF32,
"textureSample(t : texture_1d<f32>,\n"
" s : sampler,\n"
" coords : f32) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k1d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSample",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
1.0f); // coords
},
},
{
ValidTextureOverload::kSample1dArrayF32,
"textureSample(t : texture_1d_array<f32>,\n"
" s : sampler,\n"
" coords : f32,\n"
" array_index : u32) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k1dArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSample",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
1.0f, // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
2); // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
},
},
{
ValidTextureOverload::kSample2dF32,
"textureSample(t : texture_2d<f32>,\n"
" s : sampler,\n"
" coords : vec2<f32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSample",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f)); // coords
},
},
{
ValidTextureOverload::kSample2dOffsetF32,
"textureSample(t : texture_2d<f32>,\n"
" s : sampler,\n"
" coords : vec2<f32>\n"
" offset : vec2<i32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSample",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
using i32 = Builder::i32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
b->vec2<i32>(3, 4)); // offset
},
},
{
ValidTextureOverload::kSample2dArrayF32,
"textureSample(t : texture_2d_array<f32>,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" array_index : u32) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2dArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSample",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
3); // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
},
},
{
ValidTextureOverload::kSample2dArrayOffsetF32,
"textureSample(t : texture_2d_array<f32>,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" array_index : u32\n"
" offset : vec2<i32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2dArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSample",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
using i32 = Builder::i32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
3, // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
b->vec2<i32>(4, 5)); // offset
},
},
{
ValidTextureOverload::kSample3dF32,
"textureSample(t : texture_3d<f32>,\n"
" s : sampler,\n"
" coords : vec3<f32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k3d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSample",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f)); // coords
},
},
{
ValidTextureOverload::kSample3dOffsetF32,
"textureSample(t : texture_3d<f32>,\n"
" s : sampler,\n"
" coords : vec3<f32>\n"
" offset : vec3<i32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k3d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSample",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
using i32 = Builder::i32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f), // coords
b->vec3<i32>(4, 5, 6)); // offset
},
},
{
ValidTextureOverload::kSampleCubeF32,
"textureSample(t : texture_cube<f32>,\n"
" s : sampler,\n"
" coords : vec3<f32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::kCube,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSample",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f)); // coords
},
},
{
ValidTextureOverload::kSampleCubeArrayF32,
"textureSample(t : texture_cube_array<f32>,\n"
" s : sampler,\n"
" coords : vec3<f32>,\n"
" array_index : u32) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::kCubeArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSample",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
4); // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
},
},
{
ValidTextureOverload::kSampleDepth2dF32,
"textureSample(t : texture_depth_2d,\n"
" s : sampler,\n"
" coords : vec2<f32>) -> f32",
TextureKind::kDepth,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSample",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f)); // coords
},
},
{
ValidTextureOverload::kSampleDepth2dOffsetF32,
"textureSample(t : texture_depth_2d,\n"
" s : sampler,\n"
" coords : vec2<f32>\n"
" offset : vec2<i32>) -> f32",
TextureKind::kDepth,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSample",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
using i32 = Builder::i32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
b->vec2<i32>(3, 4)); // offset
},
},
{
ValidTextureOverload::kSampleDepth2dArrayF32,
"textureSample(t : texture_depth_2d_array,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" array_index : u32) -> f32",
TextureKind::kDepth,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2dArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSample",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
3); // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
},
},
{
ValidTextureOverload::kSampleDepth2dArrayOffsetF32,
"textureSample(t : texture_depth_2d_array,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" array_index : u32\n"
" offset : vec2<i32>) -> f32",
TextureKind::kDepth,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2dArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSample",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
using i32 = Builder::i32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
3, // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
b->vec2<i32>(4, 5)); // offset
},
},
{
ValidTextureOverload::kSampleDepthCubeF32,
"textureSample(t : texture_depth_cube,\n"
" s : sampler,\n"
" coords : vec3<f32>) -> f32",
TextureKind::kDepth,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::kCube,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSample",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
ast: Fix vector constructors in ValidCases() A couple of the vector constructors were the wrong width. Noticed when looking at the far-more-readable HLSL writer output. Change-Id: Ibb383eafb55c5f743851aa4500adeda5909f0922 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/33423 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-20 10:25:54 +00:00
b->vec3<f32>(1.f, 2.f, 3.f)); // coords
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
},
},
{
ValidTextureOverload::kSampleDepthCubeArrayF32,
"textureSample(t : texture_depth_cube_array,\n"
" s : sampler,\n"
" coords : vec3<f32>,\n"
" array_index : u32) -> f32",
TextureKind::kDepth,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::kCubeArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSample",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
ast: Fix vector constructors in ValidCases() A couple of the vector constructors were the wrong width. Noticed when looking at the far-more-readable HLSL writer output. Change-Id: Ibb383eafb55c5f743851aa4500adeda5909f0922 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/33423 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-20 10:25:54 +00:00
b->vec3<f32>(1.f, 2.f, 3.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
4); // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
},
},
{
ValidTextureOverload::kSampleBias2dF32,
"textureSampleBias(t : texture_2d<f32>,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" bias : f32) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleBias",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
3.f); // bias
},
},
{
ValidTextureOverload::kSampleBias2dOffsetF32,
"textureSampleBias(t : texture_2d<f32>,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" bias : f32,\n"
" offset : vec2<i32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleBias",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
using i32 = Builder::i32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
3.f, // bias
b->vec2<i32>(4, 5)); // offset
},
},
{
ValidTextureOverload::kSampleBias2dArrayF32,
"textureSampleBias(t : texture_2d_array<f32>,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" array_index : u32,\n"
" bias : f32) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2dArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleBias",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
4, // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
3.f); // bias
},
},
{
ValidTextureOverload::kSampleBias2dArrayOffsetF32,
"textureSampleBias(t : texture_2d_array<f32>,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" array_index : u32,\n"
" bias : f32,\n"
" offset : vec2<i32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2dArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleBias",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
using i32 = Builder::i32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
3, // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
4.f, // bias
b->vec2<i32>(5, 6)); // offset
},
},
{
ValidTextureOverload::kSampleBias3dF32,
"textureSampleBias(t : texture_3d<f32>,\n"
" s : sampler,\n"
" coords : vec3<f32>,\n"
" bias : f32) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k3d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleBias",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f), // coords
4.f); // bias
},
},
{
ValidTextureOverload::kSampleBias3dOffsetF32,
"textureSampleBias(t : texture_3d<f32>,\n"
" s : sampler,\n"
" coords : vec3<f32>,\n"
" bias : f32,\n"
" offset : vec3<i32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k3d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleBias",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
using i32 = Builder::i32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f), // coords
4.f, // bias
b->vec3<i32>(5, 6, 7)); // offset
},
},
{
ValidTextureOverload::kSampleBiasCubeF32,
"textureSampleBias(t : texture_cube<f32>,\n"
" s : sampler,\n"
" coords : vec3<f32>,\n"
" bias : f32) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::kCube,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleBias",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f), // coords
4.f); // bias
},
},
{
ValidTextureOverload::kSampleBiasCubeArrayF32,
"textureSampleBias(t : texture_cube_array<f32>,\n"
" s : sampler,\n"
" coords : vec3<f32>,\n"
" array_index : u32,\n"
" bias : f32) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::kCubeArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleBias",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
3, // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
4.f); // bias
},
},
{
ValidTextureOverload::kSampleLevel2dF32,
"textureSampleLevel(t : texture_2d<f32>,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" level : f32) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleLevel",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
3.f); // level
},
},
{
ValidTextureOverload::kSampleLevel2dOffsetF32,
"textureSampleLevel(t : texture_2d<f32>,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" level : f32,\n"
" offset : vec2<i32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleLevel",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
using i32 = Builder::i32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
3.f, // level
b->vec2<i32>(4, 5)); // offset
},
},
{
ValidTextureOverload::kSampleLevel2dArrayF32,
"textureSampleLevel(t : texture_2d_array<f32>,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" array_index : u32,\n"
" level : f32) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2dArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleLevel",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
3, // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
4.f); // level
},
},
{
ValidTextureOverload::kSampleLevel2dArrayOffsetF32,
"textureSampleLevel(t : texture_2d_array<f32>,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" array_index : u32,\n"
" level : f32,\n"
" offset : vec2<i32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2dArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleLevel",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
using i32 = Builder::i32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
3, // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
4.f, // level
b->vec2<i32>(5, 6)); // offset
},
},
{
ValidTextureOverload::kSampleLevel3dF32,
"textureSampleLevel(t : texture_3d<f32>,\n"
" s : sampler,\n"
" coords : vec3<f32>,\n"
" level : f32) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k3d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleLevel",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f), // coords
4.f); // level
},
},
{
ValidTextureOverload::kSampleLevel3dOffsetF32,
"textureSampleLevel(t : texture_3d<f32>,\n"
" s : sampler,\n"
" coords : vec3<f32>,\n"
" level : f32,\n"
" offset : vec3<i32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k3d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleLevel",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
using i32 = Builder::i32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f), // coords
4.f, // level
b->vec3<i32>(5, 6, 7)); // offset
},
},
{
ValidTextureOverload::kSampleLevelCubeF32,
"textureSampleLevel(t : texture_cube<f32>,\n"
" s : sampler,\n"
" coords : vec3<f32>,\n"
" level : f32) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::kCube,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleLevel",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f), // coords
4.f); // level
},
},
{
ValidTextureOverload::kSampleLevelCubeArrayF32,
"textureSampleLevel(t : texture_cube_array<f32>,\n"
" s : sampler,\n"
" coords : vec3<f32>,\n"
" array_index : u32,\n"
" level : f32) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::kCubeArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleLevel",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
4, // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
5.f); // level
},
},
{
ValidTextureOverload::kSampleLevelDepth2dF32,
"textureSampleLevel(t : texture_depth_2d,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" level : u32) -> f32",
TextureKind::kDepth,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleLevel",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
3); // level
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
},
},
{
ValidTextureOverload::kSampleLevelDepth2dOffsetF32,
"textureSampleLevel(t : texture_depth_2d,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" level : u32,\n"
" offset : vec2<i32>) -> f32",
TextureKind::kDepth,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleLevel",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
using i32 = Builder::i32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
3, // level
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
b->vec2<i32>(4, 5)); // offset
},
},
{
ValidTextureOverload::kSampleLevelDepth2dArrayF32,
"textureSampleLevel(t : texture_depth_2d_array,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" array_index : u32,\n"
" level : u32) -> f32",
TextureKind::kDepth,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2dArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleLevel",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
3, // array_index
4); // level
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
},
},
{
ValidTextureOverload::kSampleLevelDepth2dArrayOffsetF32,
"textureSampleLevel(t : texture_depth_2d_array,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" array_index : u32,\n"
" level : u32,\n"
" offset : vec2<i32>) -> f32",
TextureKind::kDepth,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2dArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleLevel",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
using i32 = Builder::i32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
3, // array_index
4, // level
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
b->vec2<i32>(5, 6)); // offset
},
},
{
ValidTextureOverload::kSampleLevelDepthCubeF32,
"textureSampleLevel(t : texture_depth_cube,\n"
" s : sampler,\n"
" coords : vec3<f32>,\n"
" level : u32) -> f32",
TextureKind::kDepth,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::kCube,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleLevel",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
4); // level
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
},
},
{
ValidTextureOverload::kSampleLevelDepthCubeArrayF32,
"textureSampleLevel(t : texture_depth_cube_array,\n"
" s : sampler,\n"
" coords : vec3<f32>,\n"
" array_index : u32,\n"
" level : u32) -> f32",
TextureKind::kDepth,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::kCubeArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleLevel",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
4, // array_index
5); // level
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
},
},
{
ValidTextureOverload::kSampleGrad2dF32,
"textureSampleGrad(t : texture_2d<f32>,\n"
" s : sampler,\n"
" coords : vec2<f32>\n"
" ddx : vec2<f32>,\n"
" ddy : vec2<f32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleGrad",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.0f, 2.0f), // coords
b->vec2<f32>(3.0f, 4.0f), // ddx
b->vec2<f32>(5.0f, 6.0f)); // ddy
},
},
{
ValidTextureOverload::kSampleGrad2dOffsetF32,
"textureSampleGrad(t : texture_2d<f32>,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" ddx : vec2<f32>,\n"
" ddy : vec2<f32>,\n"
" offset : vec2<i32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleGrad",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
using i32 = Builder::i32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
b->vec2<f32>(3.f, 4.f), // ddx
b->vec2<f32>(5.f, 6.f), // ddy
b->vec2<i32>(7, 8)); // offset
},
},
{
ValidTextureOverload::kSampleGrad2dArrayF32,
"textureSampleGrad(t : texture_2d_array<f32>,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" array_index : u32,\n"
" ddx : vec2<f32>,\n"
" ddy : vec2<f32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2dArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleGrad",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
3, // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
b->vec2<f32>(4.f, 5.f), // ddx
b->vec2<f32>(6.f, 7.f)); // ddy
},
},
{
ValidTextureOverload::kSampleGrad2dArrayOffsetF32,
"textureSampleGrad(t : texture_2d_array<f32>,\n"
" s : sampler,\n"
" coords : vec2<f32>,\n"
" array_index : u32,\n"
" ddx : vec2<f32>,\n"
" ddy : vec2<f32>,\n"
" offset : vec2<i32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k2dArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleGrad",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
using i32 = Builder::i32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
3, // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
b->vec2<f32>(4.f, 5.f), // ddx
b->vec2<f32>(6.f, 7.f), // ddy
b->vec2<i32>(8, 9)); // offset
},
},
{
ValidTextureOverload::kSampleGrad3dF32,
"textureSampleGrad(t : texture_3d<f32>,\n"
" s : sampler,\n"
" coords : vec3<f32>,\n"
" ddx : vec3<f32>,\n"
" ddy : vec3<f32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k3d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleGrad",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f), // coords
b->vec3<f32>(4.f, 5.f, 6.f), // ddx
b->vec3<f32>(7.f, 8.f, 9.f)); // ddy
},
},
{
ValidTextureOverload::kSampleGrad3dOffsetF32,
"textureSampleGrad(t : texture_3d<f32>,\n"
" s : sampler,\n"
" coords : vec3<f32>,\n"
" ddx : vec3<f32>,\n"
" ddy : vec3<f32>,\n"
" offset : vec3<i32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::k3d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleGrad",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
using i32 = Builder::i32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f), // coords
b->vec3<f32>(4.f, 5.f, 6.f), // ddx
b->vec3<f32>(7.f, 8.f, 9.f), // ddy
b->vec3<i32>(10, 11, 12)); // offset
},
},
{
ValidTextureOverload::kSampleGradCubeF32,
"textureSampleGrad(t : texture_cube<f32>,\n"
" s : sampler,\n"
" coords : vec3<f32>,\n"
" ddx : vec3<f32>,\n"
" ddy : vec3<f32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::kCube,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleGrad",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f), // coords
b->vec3<f32>(4.f, 5.f, 6.f), // ddx
b->vec3<f32>(7.f, 8.f, 9.f)); // ddy
},
},
{
ValidTextureOverload::kSampleGradCubeArrayF32,
"textureSampleGrad(t : texture_cube_array<f32>,\n"
" s : sampler,\n"
" coords : vec3<f32>,\n"
" array_index : u32,\n"
" ddx : vec3<f32>,\n"
" ddy : vec3<f32>) -> vec4<f32>",
TextureKind::kRegular,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kSampler,
type::TextureDimension::kCubeArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleGrad",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
4, // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
b->vec3<f32>(5.f, 6.f, 7.f), // ddx
b->vec3<f32>(8.f, 9.f, 10.f)); // ddy
},
},
{
ValidTextureOverload::kSampleGradDepth2dF32,
"textureSampleCompare(t : texture_depth_2d,\n"
" s : sampler_comparison,\n"
" coords : vec2<f32>,\n"
" depth_ref : f32) -> f32",
TextureKind::kDepth,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kComparisonSampler,
type::TextureDimension::k2d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleCompare",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
3.f); // depth_ref
},
},
{
ValidTextureOverload::kSampleGradDepth2dOffsetF32,
"textureSampleCompare(t : texture_depth_2d,\n"
" s : sampler_comparison,\n"
" coords : vec2<f32>,\n"
" depth_ref : f32,\n"
" offset : vec2<i32>) -> f32",
TextureKind::kDepth,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kComparisonSampler,
type::TextureDimension::k2d,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleCompare",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
using i32 = Builder::i32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
3.f, // depth_ref
b->vec2<i32>(4, 5)); // offset
},
},
{
ValidTextureOverload::kSampleGradDepth2dArrayF32,
"textureSampleCompare(t : texture_depth_2d_array,\n"
" s : sampler_comparison,\n"
" coords : vec2<f32>,\n"
" array_index : u32,\n"
" depth_ref : f32) -> f32",
TextureKind::kDepth,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kComparisonSampler,
type::TextureDimension::k2dArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleCompare",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
4, // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
3.f); // depth_ref
},
},
{
ValidTextureOverload::kSampleGradDepth2dArrayOffsetF32,
"textureSampleCompare(t : texture_depth_2d_array,\n"
" s : sampler_comparison,\n"
" coords : vec2<f32>,\n"
" array_index : u32,\n"
" depth_ref : f32,\n"
" offset : vec2<i32>) -> f32",
TextureKind::kDepth,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kComparisonSampler,
type::TextureDimension::k2dArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleCompare",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
using i32 = Builder::i32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec2<f32>(1.f, 2.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
4, // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
3.f, // depth_ref
b->vec2<i32>(5, 6)); // offset
},
},
{
ValidTextureOverload::kSampleGradDepthCubeF32,
"textureSampleCompare(t : texture_depth_cube,\n"
" s : sampler_comparison,\n"
" coords : vec3<f32>,\n"
" depth_ref : f32) -> f32",
TextureKind::kDepth,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kComparisonSampler,
type::TextureDimension::kCube,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleCompare",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f), // coords
4.f); // depth_ref
},
},
{
ValidTextureOverload::kSampleGradDepthCubeArrayF32,
"textureSampleCompare(t : texture_depth_cube_array,\n"
" s : sampler_comparison,\n"
" coords : vec3<f32>,\n"
" array_index : u32,\n"
" depth_ref : f32) -> f32",
TextureKind::kDepth,
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
type::SamplerKind::kComparisonSampler,
type::TextureDimension::kCubeArray,
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
TextureDataType::kF32,
"textureSampleCompare",
Cleanup: Remove unnecessary namespace prefixes No need to prefix with `ast::` when you're in the ast namespace already. Change-Id: Iac6cd3a215c05a80ee2035d582500f1d6c882a06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34320 Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-30 23:30:58 +00:00
[](Builder* b) {
using f32 = Builder::f32;
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
return b->ExprList("texture", // t
"sampler", // s
b->vec3<f32>(1.f, 2.f, 3.f), // coords
Update texture intrinsic writer tests for signed params All unsigned texture intrinsic parameters were recently changed to signed: https://github.com/gpuweb/gpuweb/pull/1271 Update the writer tests to match. The spirv reader side of things will also need to be updated. Bug: tint:391 Change-Id: I280f223f2556355f4b6538ae1ef446e33b017c9f Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34820 Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: Ben Clayton <bclayton@google.com>
2020-12-08 19:39:34 +00:00
4, // array_index
Implement textureSample builtins Handle wsgl parsing and spirv writing of: textureSample(), textureSampleBias(), textureSampleLevel(), textureSampleGrad(), textureSampleCompare() Handle the different signature for array texture types. Includes offset overloads. Change-Id: I6802d97cd9a7083f12439b32725b9a4b666b8c63 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32985 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: David Neto <dneto@google.com> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-11-18 21:19:22 +00:00
5.f); // depth_ref
},
}};
}
} // namespace test
} // namespace intrinsic
} // namespace ast
} // namespace tint