encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove LocalReferencedBuiltinVariables() 

It ignored entry point builtin parameters, meaning it was mostly useless.
Was only used by the FirstIndexOffset, which has been re-written.

Change-Id: I26abd69201576cf33b1a71e8e6a1b914871a2a74
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/47223
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: James Price <jrprice@google.com>
This commit is contained in:
Ben Clayton 2021-04-09 16:54:48 +00:00 committed by Commit Bot service account
parent 962d46ec56
commit 003fa8ffd6
2 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/semantic/function.h
View File

@ -136,11 +136,6 @@ class Function : public Castable<Function, CallTarget> {
/// @returns the referenced storage textures /// @returns the referenced storage textures
VariableBindings ReferencedDepthTextureVariables() const; VariableBindings ReferencedDepthTextureVariables() const;
/// Retrieves any locally referenced builtin variables
/// @returns the <variable, decoration> pairs.
std::vector<std::pair<const Variable*, ast::BuiltinDecoration*>>
LocalReferencedBuiltinVariables() const;
/// Checks if the given entry point is an ancestor /// Checks if the given entry point is an ancestor
/// @param sym the entry point symbol /// @param sym the entry point symbol
/// @returns true if `sym` is an ancestor entry point of this function /// @returns true if `sym` is an ancestor entry point of this function

15
src/semantic/sem_function.cc
View File

@ -170,21 +170,6 @@ Function::VariableBindings Function::ReferencedDepthTextureVariables() const {
return ret; return ret;
} }
std::vector<std::pair<const Variable*, ast::BuiltinDecoration*>>
Function::LocalReferencedBuiltinVariables() const {
std::vector<std::pair<const Variable*, ast::BuiltinDecoration*>> ret;
for (auto* var : LocalReferencedModuleVariables()) {
for (auto* deco : var->Declaration()->decorations()) {
if (auto* builtin = deco->As<ast::BuiltinDecoration>()) {
ret.push_back({var, builtin});
break;
}
}
}
return ret;
}
bool Function::HasAncestorEntryPoint(Symbol symbol) const { bool Function::HasAncestorEntryPoint(Symbol symbol) const {
for (const auto& point : ancestor_entry_points_) { for (const auto& point : ancestor_entry_points_) {
if (point == symbol) { if (point == symbol) {