encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enable OpArrayLengthTests 

arrayLength is well enough supported in Tint that these tests now
pass.

BUG=tint:252

Change-Id: I5d8f00d8ae651a2e075ef33b88a8c4df56895ce8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/39140
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
This commit is contained in:
Ryan Harrison 2021-01-28 18:05:46 +00:00 committed by Commit Bot service account
parent 75e191893f
commit 0228625411
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/tests/end2end/OpArrayLengthTests.cpp
View File

@ -23,9 +23,6 @@ class OpArrayLengthTest : public DawnTest {
void SetUp() { void SetUp() {
DawnTest::SetUp(); DawnTest::SetUp();
// TODO(crbug.com/tint/252): Implement arrayLength.
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator"));
// Create buffers of various size to check the length() implementation // Create buffers of various size to check the length() implementation
wgpu::BufferDescriptor bufferDesc; wgpu::BufferDescriptor bufferDesc;
bufferDesc.size = 4; bufferDesc.size = 4;
@ -216,6 +213,9 @@ TEST_P(OpArrayLengthTest, Vertex) {
DAWN_SKIP_TEST_IF(IsNvidia() && IsOpenGL()); DAWN_SKIP_TEST_IF(IsNvidia() && IsOpenGL());
DAWN_SKIP_TEST_IF(IsNvidia() && IsOpenGLES()); DAWN_SKIP_TEST_IF(IsNvidia() && IsOpenGLES());
// TODO(crbug.com/dawn/657): Returned data is slightly incorrect in this case.
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator") && IsIntel() && IsOpenGL());
utils::BasicRenderPass renderPass = utils::CreateBasicRenderPass(device, 1, 1); utils::BasicRenderPass renderPass = utils::CreateBasicRenderPass(device, 1, 1);
// Create the pipeline that computes the length of the buffers and writes it to the only render // Create the pipeline that computes the length of the buffers and writes it to the only render