encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-06-06 14:43:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace NULL with nullptr

Browse Source 
This patch replaces NULL with nullptr as nullptr is preferred as null
pointers in Chromium coding style.

Bug: None
Change-Id: Ie6ab9d606d791bad2c50001815062c22e9ec0d25
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102102
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
This commit is contained in:
Jiawei Shao 2022-09-14 14:39:37 +00:00 committed by Dawn LUCI CQ
parent a48e46f3a4
commit 060137a712
4 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/dawn/common/SystemUtils.cpp
View File

@ -158,7 +158,7 @@ std::optional<std::string> GetModulePath() {
} }
std::array<char, PATH_MAX> absolutePath; std::array<char, PATH_MAX> absolutePath;
if (realpath(dlInfo.dli_fname, absolutePath.data()) == NULL) { if (realpath(dlInfo.dli_fname, absolutePath.data()) == nullptr) {
return {}; return {};
} }
return absolutePath.data(); return absolutePath.data();

6
src/dawn/native/d3d12/DeviceD3D12.cpp
View File

@ -160,19 +160,19 @@ MaybeError Device::Initialize(const DeviceDescriptor* descriptor) {
programDesc.NumArgumentDescs = 1; programDesc.NumArgumentDescs = 1;
programDesc.pArgumentDescs = &argumentDesc; programDesc.pArgumentDescs = &argumentDesc;
GetD3D12Device()->CreateCommandSignature(&programDesc, NULL, GetD3D12Device()->CreateCommandSignature(&programDesc, nullptr,
IID_PPV_ARGS(&mDispatchIndirectSignature)); IID_PPV_ARGS(&mDispatchIndirectSignature));
argumentDesc.Type = D3D12_INDIRECT_ARGUMENT_TYPE_DRAW; argumentDesc.Type = D3D12_INDIRECT_ARGUMENT_TYPE_DRAW;
programDesc.ByteStride = 4 * sizeof(uint32_t); programDesc.ByteStride = 4 * sizeof(uint32_t);
GetD3D12Device()->CreateCommandSignature(&programDesc, NULL, GetD3D12Device()->CreateCommandSignature(&programDesc, nullptr,
IID_PPV_ARGS(&mDrawIndirectSignature)); IID_PPV_ARGS(&mDrawIndirectSignature));
argumentDesc.Type = D3D12_INDIRECT_ARGUMENT_TYPE_DRAW_INDEXED; argumentDesc.Type = D3D12_INDIRECT_ARGUMENT_TYPE_DRAW_INDEXED;
programDesc.ByteStride = 5 * sizeof(uint32_t); programDesc.ByteStride = 5 * sizeof(uint32_t);
GetD3D12Device()->CreateCommandSignature(&programDesc, NULL, GetD3D12Device()->CreateCommandSignature(&programDesc, nullptr,
IID_PPV_ARGS(&mDrawIndexedIndirectSignature)); IID_PPV_ARGS(&mDrawIndexedIndirectSignature));
DAWN_TRY(DeviceBase::Initialize(Queue::Create(this, &descriptor->defaultQueue))); DAWN_TRY(DeviceBase::Initialize(Queue::Create(this, &descriptor->defaultQueue)));

2
src/dawn/native/vulkan/QuerySetVk.cpp
View File

@ -76,7 +76,7 @@ ResultOrError<Ref<QuerySet>> QuerySet::Create(Device* device,
MaybeError QuerySet::Initialize() { MaybeError QuerySet::Initialize() {
VkQueryPoolCreateInfo createInfo; VkQueryPoolCreateInfo createInfo;
createInfo.sType = VK_STRUCTURE_TYPE_QUERY_POOL_CREATE_INFO; createInfo.sType = VK_STRUCTURE_TYPE_QUERY_POOL_CREATE_INFO;
createInfo.pNext = NULL; createInfo.pNext = nullptr;
createInfo.flags = 0; createInfo.flags = 0;
createInfo.queryType = VulkanQueryType(GetQueryType()); createInfo.queryType = VulkanQueryType(GetQueryType());
createInfo.queryCount = std::max(GetQueryCount(), uint32_t(1u)); createInfo.queryCount = std::max(GetQueryCount(), uint32_t(1u));

8
src/tint/utils/io/command_windows.cc
View File

@ -102,18 +102,18 @@ class Pipe {
/// Queries whether the file at the given path is an executable or DLL. /// Queries whether the file at the given path is an executable or DLL.
bool ExecutableExists(const std::string& path) { bool ExecutableExists(const std::string& path) {
auto file = Handle(CreateFileA(path.c_str(), GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, auto file = Handle(CreateFileA(path.c_str(), GENERIC_READ, FILE_SHARE_READ, nullptr,
FILE_ATTRIBUTE_READONLY, NULL)); OPEN_EXISTING, FILE_ATTRIBUTE_READONLY, nullptr));
if (!file) { if (!file) {
return false; return false;
} }
auto map = Handle(CreateFileMappingA(file, NULL, PAGE_READONLY, 0, 0, NULL)); auto map = Handle(CreateFileMappingA(file, nullptr, PAGE_READONLY, 0, 0, nullptr));
if (map == INVALID_HANDLE_VALUE) { if (map == INVALID_HANDLE_VALUE) {
return false; return false;
} }
void* addr_header = MapViewOfFileEx(map, FILE_MAP_READ, 0, 0, 0, NULL); void* addr_header = MapViewOfFileEx(map, FILE_MAP_READ, 0, 0, 0, nullptr);
// Dynamically obtain the address of, and call ImageNtHeader. This is done to avoid tint.exe // Dynamically obtain the address of, and call ImageNtHeader. This is done to avoid tint.exe
// needing to statically link Dbghelp.lib. // needing to statically link Dbghelp.lib.