encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix -Wunreachable-code-return with newer clang version. 

When the emit_continuing lambda always returns true, clang is able to
detect it and finds that some code is unreachable.

This commit changes places that use the lambdas directly to instead use
the stored emit_continuing_ member.

Bud: dawn:824
Change-Id: Idfd804a6ec53ac793e8988dce79991c659fbbc36
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/75060
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Corentin Wallez 2022-01-04 10:18:39 +00:00 committed by Tint LUCI CQ
parent 7913982f87
commit 09c49b34d9
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/writer/glsl/generator_impl.cc
View File

@ -2110,7 +2110,7 @@ bool GeneratorImpl::EmitLoop(const ast::LoopStatement* stmt) {
if (!EmitStatements(stmt->body->statements)) { if (!EmitStatements(stmt->body->statements)) {
return false; return false;
} }
if (!emit_continuing()) { if (!emit_continuing_()) {
return false; return false;
} }
} }
@ -2190,7 +2190,7 @@ bool GeneratorImpl::EmitForLoop(const ast::ForLoopStatement* stmt) {
return false; return false;
} }
if (!emit_continuing()) { if (!emit_continuing_()) {
return false; return false;
} }
} else { } else {

4
src/writer/hlsl/generator_impl.cc
View File

@ -3203,7 +3203,7 @@ bool GeneratorImpl::EmitLoop(const ast::LoopStatement* stmt) {
if (!EmitStatements(stmt->body->statements)) { if (!EmitStatements(stmt->body->statements)) {
return false; return false;
} }
if (!emit_continuing()) { if (!emit_continuing_()) {
return false; return false;
} }
} }
@ -3283,7 +3283,7 @@ bool GeneratorImpl::EmitForLoop(const ast::ForLoopStatement* stmt) {
return false; return false;
} }
if (!emit_continuing()) { if (!emit_continuing_()) {
return false; return false;
} }
} else { } else {

4
src/writer/msl/generator_impl.cc
View File

@ -1827,7 +1827,7 @@ bool GeneratorImpl::EmitLoop(const ast::LoopStatement* stmt) {
if (!EmitStatements(stmt->body->statements)) { if (!EmitStatements(stmt->body->statements)) {
return false; return false;
} }
if (!emit_continuing()) { if (!emit_continuing_()) {
return false; return false;
} }
} }
@ -1908,7 +1908,7 @@ bool GeneratorImpl::EmitForLoop(const ast::ForLoopStatement* stmt) {
return false; return false;
} }
if (!emit_continuing()) { if (!emit_continuing_()) {
return false; return false;
} }
} else { } else {