encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove NOLINT lines from c++17 headers 

The depot_tools cpplint.py has been updated to accept the c++17 headers
so we no-longer need to mark with NOLINT.

Bug: dawn:1379
Change-Id: I938a4cac5ca881cd1b556f4b8d58741b6a1e6af1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/94240
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
This commit is contained in:
dan sinclair 2022-06-18 14:34:00 +00:00 committed by Dawn LUCI CQ
parent c7f7ca3d9e
commit 0a4e2a1373
16 changed files with 19 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/dawn/native/vulkan/ShaderModuleVk.h
View File

@ -17,8 +17,7 @@
#include <memory> #include <memory>
#include <mutex> #include <mutex>
// TODO(https://crbug.com/dawn/1379) Update cpplint and remove NOLINT #include <optional>
#include <optional> // NOLINT(build/include_order))
#include <unordered_map> #include <unordered_map>
#include <utility> #include <utility>
#include <vector> #include <vector>

6
src/dawn/node/interop/Core.h
View File

@ -20,14 +20,12 @@
#include <cstdint> #include <cstdint>
#include <limits> #include <limits>
// TODO(https://crbug.com/dawn/1379) Update cpplint and remove NOLINT #include <optional>
#include <optional> // NOLINT(build/include_order)
#include <string> #include <string>
#include <type_traits> #include <type_traits>
#include <unordered_map> #include <unordered_map>
#include <utility> #include <utility>
// TODO(https://crbug.com/dawn/1379) Update cpplint and remove NOLINT #include <variant>
#include <variant> // NOLINT(build/include_order)
#include <vector> #include <vector>
#include "src/dawn/node/interop/Napi.h" #include "src/dawn/node/interop/Napi.h"

6
src/dawn/node/utils/Debug.h
View File

@ -16,13 +16,11 @@
#define SRC_DAWN_NODE_UTILS_DEBUG_H_ #define SRC_DAWN_NODE_UTILS_DEBUG_H_
#include <iostream> #include <iostream>
// TODO(https://crbug.com/dawn/1379) Update cpplint and remove NOLINT #include <optional>
#include <optional> // NOLINT(build/include_order)
#include <sstream> #include <sstream>
#include <unordered_map> #include <unordered_map>
#include <utility> #include <utility>
// TODO(https://crbug.com/dawn/1379) Update cpplint and remove NOLINT #include <variant>
#include <variant> // NOLINT(build/include_order)
#include <vector> #include <vector>
#include "dawn/webgpu_cpp_print.h" #include "dawn/webgpu_cpp_print.h"

3
src/tint/bench/benchmark.h
View File

@ -17,8 +17,7 @@
#include <memory> #include <memory>
#include <string> #include <string>
// TODO(https://crbug.com/dawn/1379) Update cpplint and remove NOLINT #include <variant>
#include <variant> // NOLINT: Found C system header after C++ system header.
#include "benchmark/benchmark.h" #include "benchmark/benchmark.h"
#include "src/tint/utils/concat.h" #include "src/tint/utils/concat.h"

2
src/tint/cmd/main.cc
View File

@ -17,7 +17,7 @@
#include <iostream> #include <iostream>
#include <limits> #include <limits>
#include <memory> #include <memory>
#include <optional> // NOLINT(build/include_order) #include <optional>
#include <sstream> #include <sstream>
#include <string> #include <string>
#include <vector> #include <vector>

3
src/tint/number.h
View File

@ -18,9 +18,8 @@
#include <stdint.h> #include <stdint.h>
#include <functional> #include <functional>
#include <limits> #include <limits>
#include <optional>
#include <ostream> #include <ostream>
// TODO(https://crbug.com/dawn/1379) Update cpplint and remove NOLINT
#include <optional> // NOLINT(build/include_order))
#include "src/tint/utils/compiler_macros.h" #include "src/tint/utils/compiler_macros.h"
#include "src/tint/utils/result.h" #include "src/tint/utils/result.h"

2
src/tint/reader/wgsl/lexer.cc
View File

@ -19,7 +19,7 @@
#include <cstring> #include <cstring>
#include <functional> #include <functional>
#include <limits> #include <limits>
#include <optional> // NOLINT(build/include_order) #include <optional>
#include <tuple> #include <tuple>
#include <type_traits> #include <type_traits>
#include <utility> #include <utility>

3
src/tint/reader/wgsl/token.h
View File

@ -17,8 +17,7 @@
#include <string> #include <string>
#include <string_view> #include <string_view>
// TODO(https://crbug.com/dawn/1379) Update cpplint and remove NOLINT #include <variant>
#include <variant> // NOLINT(build/include_order))
#include "src/tint/source.h" #include "src/tint/source.h"

3
src/tint/resolver/resolver_constants.cc
View File

@ -15,8 +15,7 @@
#include "src/tint/resolver/resolver.h" #include "src/tint/resolver/resolver.h"
#include <cmath> #include <cmath>
// TODO(https://crbug.com/dawn/1379) Update cpplint and remove NOLINT #include <optional>
#include <optional> // NOLINT(build/include_order))
#include "src/tint/sem/abstract_float.h" #include "src/tint/sem/abstract_float.h"
#include "src/tint/sem/abstract_int.h" #include "src/tint/sem/abstract_int.h"

3
src/tint/sem/constant.h
View File

@ -16,9 +16,8 @@
#define SRC_TINT_SEM_CONSTANT_H_ #define SRC_TINT_SEM_CONSTANT_H_
#include <ostream> #include <ostream>
// TODO(https://crbug.com/dawn/1379) Update cpplint and remove NOLINT
#include <utility> #include <utility>
#include <variant> // NOLINT(build/include_order) #include <variant>
#include <vector> #include <vector>
#include "src/tint/program_builder.h" #include "src/tint/program_builder.h"

2
src/tint/transform/num_workgroups_from_uniform.h
View File

@ -15,7 +15,7 @@
#ifndef SRC_TINT_TRANSFORM_NUM_WORKGROUPS_FROM_UNIFORM_H_ #ifndef SRC_TINT_TRANSFORM_NUM_WORKGROUPS_FROM_UNIFORM_H_
#define SRC_TINT_TRANSFORM_NUM_WORKGROUPS_FROM_UNIFORM_H_ #define SRC_TINT_TRANSFORM_NUM_WORKGROUPS_FROM_UNIFORM_H_
#include <optional> // NOLINT(build/include_order) #include <optional>
#include "src/tint/sem/binding_point.h" #include "src/tint/sem/binding_point.h"
#include "src/tint/transform/transform.h" #include "src/tint/transform/transform.h"

3
src/tint/utils/result.h
View File

@ -16,8 +16,7 @@
#define SRC_TINT_UTILS_RESULT_H_ #define SRC_TINT_UTILS_RESULT_H_
#include <ostream> #include <ostream>
// TODO(https://crbug.com/dawn/1379) Update cpplint and remove NOLINT #include <variant>
#include <variant> // NOLINT(build/include_order)
namespace tint::utils { namespace tint::utils {

2
src/tint/writer/hlsl/generator.h
View File

@ -16,7 +16,7 @@
#define SRC_TINT_WRITER_HLSL_GENERATOR_H_ #define SRC_TINT_WRITER_HLSL_GENERATOR_H_
#include <memory> #include <memory>
#include <optional> // NOLINT(build/include_order) #include <optional>
#include <string> #include <string>
#include <unordered_set> #include <unordered_set>
#include <utility> #include <utility>

3
src/tint/writer/spirv/operand.h
View File

@ -17,8 +17,7 @@
#include <cstring> #include <cstring>
#include <string> #include <string>
// TODO(https://crbug.com/dawn/1379) Update cpplint and remove NOLINT #include <variant>
#include <variant> // NOLINT(build/include_order)
#include <vector> #include <vector>
#include "src/tint/utils/hash.h" #include "src/tint/utils/hash.h"

3
tools/src/cmd/remote-compile/main.cc
View File

@ -17,11 +17,10 @@
#include <fstream> #include <fstream>
#include <sstream> #include <sstream>
#include <string> #include <string>
#include <thread>
#include <type_traits> #include <type_traits>
#include <vector> #include <vector>
#include <thread> // NOLINT
#include "tools/src/cmd/remote-compile/compile.h" #include "tools/src/cmd/remote-compile/compile.h"
#include "tools/src/cmd/remote-compile/socket.h" #include "tools/src/cmd/remote-compile/socket.h"

4
tools/src/cmd/remote-compile/rwmutex.h
View File

@ -15,8 +15,8 @@
#ifndef TOOLS_SRC_CMD_REMOTE_COMPILE_RWMUTEX_H_ #ifndef TOOLS_SRC_CMD_REMOTE_COMPILE_RWMUTEX_H_
#define TOOLS_SRC_CMD_REMOTE_COMPILE_RWMUTEX_H_ #define TOOLS_SRC_CMD_REMOTE_COMPILE_RWMUTEX_H_
#include <condition_variable> // NOLINT #include <condition_variable>
#include <mutex> // NOLINT #include <mutex>
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
// RWMutex // RWMutex