encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tests: Validate WGSL output 

WGSL was the only format that wasn't being validated for our E2E
tests, and this meant that WGSL backend bugs were sometimes going
unnoticed.

This change uses Tint's WGSL reader to validate the WGSL output.

Change-Id: I7d9e1c22feda530e7ba594725f21e576cf928647
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/80961
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
This commit is contained in:
James Price 2022-02-17 20:43:19 +00:00
parent 7161ae55c2
commit 0f56ed9759
1 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
samples/main.cc
View File

@ -623,7 +623,24 @@ bool GenerateWgsl(const tint::Program* program, const Options& options) {
return false;
}
return WriteFile(options.output_file, "w", result.wgsl);
if (!WriteFile(options.output_file, "w", result.wgsl)) {
return false;
}
if (options.validate) {
// Attempt to re-parse the output program with Tint's WGSL reader.
auto source = std::make_unique<tint::Source::File>(options.input_filename,
result.wgsl);
auto reparsed_program = tint::reader::wgsl::Parse(source.get());
if (!reparsed_program.IsValid()) {
auto diag_printer = tint::diag::Printer::create(stderr, true);
tint::diag::Formatter diag_formatter;
diag_formatter.format(reparsed_program.Diagnostics(), diag_printer.get());
return false;
}
}
return true;
#else
(void)program;
(void)options;