spirv: Use generic transform to process shader IO

The refactored CanonicalizeEntryPointIO transform makes it much easier
to handle SPIR-V style IO as well, and doing this removes a lot of
duplicated code. Remove all of the SPIR-V transform code for shader IO
and vertex point size.

Bug: tint:920
Change-Id: Id1b97517619b4d2fd09b45d5aee848259f3dfa77
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/60840
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: James Price <jrprice@google.com>
Auto-Submit: James Price <jrprice@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

test/vk-gl-cts/graphicsfuzz/cov-loop-clamp-to-one-empty-condition/0-opt.spvasm.expected.spvasm

@@ -1,13 +1,14 @@
 ; SPIR-V
 ; Version: 1.3
 ; Generator: Google Tint Compiler; 0
-; Bound: 107
+; Bound: 106
 ; Schema: 0
                OpCapability Shader
          %65 = OpExtInstImport "GLSL.std.450"
                OpMemoryModel Logical GLSL450
-               OpEntryPoint Fragment %main "main" %tint_symbol_1
+               OpEntryPoint Fragment %main "main" %x_GLF_color_1_1
                OpExecutionMode %main OriginUpperLeft
+               OpName %x_GLF_color_1_1 "x_GLF_color_1_1"
                OpName %x_GLF_global_loop_count "x_GLF_global_loop_count"
                OpName %buf0 "buf0"
                OpMemberName %buf0 0 "x_GLF_uniform_float_values"
@@ -16,15 +17,14 @@
                OpMemberName %buf1 0 "x_GLF_uniform_int_values"
                OpName %x_10 "x_10"
                OpName %x_GLF_color "x_GLF_color"
-               OpName %tint_symbol_1 "tint_symbol_1"
                OpName %main_1 "main_1"
                OpName %f "f"
                OpName %i "i"
                OpName %main_out "main_out"
                OpMemberName %main_out 0 "x_GLF_color_1"
-               OpName %tint_symbol_2 "tint_symbol_2"
-               OpName %tint_symbol "tint_symbol"
+               OpName %main_inner "main_inner"
                OpName %main "main"
+               OpDecorate %x_GLF_color_1_1 Location 0
                OpDecorate %buf0 Block
                OpMemberDecorate %buf0 0 Offset 0
                OpDecorate %_arr_float_uint_3 ArrayStride 16
@@ -37,13 +37,16 @@
                OpDecorate %x_10 NonWritable
                OpDecorate %x_10 DescriptorSet 0
                OpDecorate %x_10 Binding 1
-               OpDecorate %tint_symbol_1 Location 0
                OpMemberDecorate %main_out 0 Offset 0
+      %float = OpTypeFloat 32
+    %v4float = OpTypeVector %float 4
+%_ptr_Output_v4float = OpTypePointer Output %v4float
+          %5 = OpConstantNull %v4float
+%x_GLF_color_1_1 = OpVariable %_ptr_Output_v4float Output %5
         %int = OpTypeInt 32 1
 %_ptr_Private_int = OpTypePointer Private %int
-          %4 = OpConstantNull %int
-%x_GLF_global_loop_count = OpVariable %_ptr_Private_int Private %4
-      %float = OpTypeFloat 32
+          %9 = OpConstantNull %int
+%x_GLF_global_loop_count = OpVariable %_ptr_Private_int Private %9
        %uint = OpTypeInt 32 0
      %uint_3 = OpConstant %uint 3
 %_arr_float_uint_3 = OpTypeArray %float %uint_3
@@ -54,12 +57,8 @@
        %buf1 = OpTypeStruct %_arr_int_uint_3
 %_ptr_Uniform_buf1 = OpTypePointer Uniform %buf1
        %x_10 = OpVariable %_ptr_Uniform_buf1 Uniform
-    %v4float = OpTypeVector %float 4
 %_ptr_Private_v4float = OpTypePointer Private %v4float
-         %19 = OpConstantNull %v4float
-%x_GLF_color = OpVariable %_ptr_Private_v4float Private %19
-%_ptr_Output_v4float = OpTypePointer Output %v4float
-%tint_symbol_1 = OpVariable %_ptr_Output_v4float Output %19
+%x_GLF_color = OpVariable %_ptr_Private_v4float Private %5
        %void = OpTypeVoid
          %22 = OpTypeFunction %void
 %_ptr_Function_float = OpTypePointer Function %float
@@ -74,11 +73,11 @@
        %bool = OpTypeBool
     %float_1 = OpConstant %float 1
    %main_out = OpTypeStruct %v4float
-         %95 = OpTypeFunction %void %main_out
+         %95 = OpTypeFunction %main_out
      %main_1 = OpFunction %void None %22
          %25 = OpLabel
           %f = OpVariable %_ptr_Function_float Function %28
-          %i = OpVariable %_ptr_Function_int Function %4
+          %i = OpVariable %_ptr_Function_int Function %9
                OpStore %x_GLF_global_loop_count %int_0
          %35 = OpAccessChain %_ptr_Uniform_float %x_7 %uint_0 %int_1
          %36 = OpLoad %float %35
@@ -160,18 +159,17 @@
          %75 = OpLabel
                OpReturn
                OpFunctionEnd
-%tint_symbol_2 = OpFunction %void None %95
-%tint_symbol = OpFunctionParameter %main_out
-         %99 = OpLabel
-        %100 = OpCompositeExtract %v4float %tint_symbol 0
-               OpStore %tint_symbol_1 %100
-               OpReturn
+ %main_inner = OpFunction %main_out None %95
+         %98 = OpLabel
+         %99 = OpFunctionCall %void %main_1
+        %100 = OpLoad %v4float %x_GLF_color
+        %101 = OpCompositeConstruct %main_out %100
+               OpReturnValue %101
                OpFunctionEnd
        %main = OpFunction %void None %22
-        %102 = OpLabel
-        %103 = OpFunctionCall %void %main_1
-        %105 = OpLoad %v4float %x_GLF_color
-        %106 = OpCompositeConstruct %main_out %105
-        %104 = OpFunctionCall %void %tint_symbol_2 %106
+        %103 = OpLabel
+        %104 = OpFunctionCall %main_out %main_inner
+        %105 = OpCompositeExtract %v4float %104 0
+               OpStore %x_GLF_color_1_1 %105
                OpReturn
                OpFunctionEnd

test/vk-gl-cts/graphicsfuzz/cov-loop-clamp-to-one-empty-condition/0-opt.wgsl.expected.spvasm

@@ -1,13 +1,14 @@
 ; SPIR-V
 ; Version: 1.3
 ; Generator: Google Tint Compiler; 0
-; Bound: 107
+; Bound: 106
 ; Schema: 0
                OpCapability Shader
          %65 = OpExtInstImport "GLSL.std.450"
                OpMemoryModel Logical GLSL450
-               OpEntryPoint Fragment %main "main" %tint_symbol_1
+               OpEntryPoint Fragment %main "main" %x_GLF_color_1_1
                OpExecutionMode %main OriginUpperLeft
+               OpName %x_GLF_color_1_1 "x_GLF_color_1_1"
                OpName %x_GLF_global_loop_count "x_GLF_global_loop_count"
                OpName %buf0 "buf0"
                OpMemberName %buf0 0 "x_GLF_uniform_float_values"
@@ -16,15 +17,14 @@
                OpMemberName %buf1 0 "x_GLF_uniform_int_values"
                OpName %x_10 "x_10"
                OpName %x_GLF_color "x_GLF_color"
-               OpName %tint_symbol_1 "tint_symbol_1"
                OpName %main_1 "main_1"
                OpName %f "f"
                OpName %i "i"
                OpName %main_out "main_out"
                OpMemberName %main_out 0 "x_GLF_color_1"
-               OpName %tint_symbol_2 "tint_symbol_2"
-               OpName %tint_symbol "tint_symbol"
+               OpName %main_inner "main_inner"
                OpName %main "main"
+               OpDecorate %x_GLF_color_1_1 Location 0
                OpDecorate %buf0 Block
                OpMemberDecorate %buf0 0 Offset 0
                OpDecorate %_arr_float_uint_3 ArrayStride 16
@@ -37,13 +37,16 @@
                OpDecorate %x_10 NonWritable
                OpDecorate %x_10 DescriptorSet 0
                OpDecorate %x_10 Binding 1
-               OpDecorate %tint_symbol_1 Location 0
                OpMemberDecorate %main_out 0 Offset 0
+      %float = OpTypeFloat 32
+    %v4float = OpTypeVector %float 4
+%_ptr_Output_v4float = OpTypePointer Output %v4float
+          %5 = OpConstantNull %v4float
+%x_GLF_color_1_1 = OpVariable %_ptr_Output_v4float Output %5
         %int = OpTypeInt 32 1
 %_ptr_Private_int = OpTypePointer Private %int
-          %4 = OpConstantNull %int
-%x_GLF_global_loop_count = OpVariable %_ptr_Private_int Private %4
-      %float = OpTypeFloat 32
+          %9 = OpConstantNull %int
+%x_GLF_global_loop_count = OpVariable %_ptr_Private_int Private %9
        %uint = OpTypeInt 32 0
      %uint_3 = OpConstant %uint 3
 %_arr_float_uint_3 = OpTypeArray %float %uint_3
@@ -54,12 +57,8 @@
        %buf1 = OpTypeStruct %_arr_int_uint_3
 %_ptr_Uniform_buf1 = OpTypePointer Uniform %buf1
        %x_10 = OpVariable %_ptr_Uniform_buf1 Uniform
-    %v4float = OpTypeVector %float 4
 %_ptr_Private_v4float = OpTypePointer Private %v4float
-         %19 = OpConstantNull %v4float
-%x_GLF_color = OpVariable %_ptr_Private_v4float Private %19
-%_ptr_Output_v4float = OpTypePointer Output %v4float
-%tint_symbol_1 = OpVariable %_ptr_Output_v4float Output %19
+%x_GLF_color = OpVariable %_ptr_Private_v4float Private %5
        %void = OpTypeVoid
          %22 = OpTypeFunction %void
 %_ptr_Function_float = OpTypePointer Function %float
@@ -74,11 +73,11 @@
        %bool = OpTypeBool
     %float_1 = OpConstant %float 1
    %main_out = OpTypeStruct %v4float
-         %95 = OpTypeFunction %void %main_out
+         %95 = OpTypeFunction %main_out
      %main_1 = OpFunction %void None %22
          %25 = OpLabel
           %f = OpVariable %_ptr_Function_float Function %28
-          %i = OpVariable %_ptr_Function_int Function %4
+          %i = OpVariable %_ptr_Function_int Function %9
                OpStore %x_GLF_global_loop_count %int_0
          %35 = OpAccessChain %_ptr_Uniform_float %x_7 %uint_0 %int_1
          %36 = OpLoad %float %35
@@ -160,18 +159,17 @@
          %75 = OpLabel
                OpReturn
                OpFunctionEnd
-%tint_symbol_2 = OpFunction %void None %95
-%tint_symbol = OpFunctionParameter %main_out
-         %99 = OpLabel
-        %100 = OpCompositeExtract %v4float %tint_symbol 0
-               OpStore %tint_symbol_1 %100
-               OpReturn
+ %main_inner = OpFunction %main_out None %95
+         %98 = OpLabel
+         %99 = OpFunctionCall %void %main_1
+        %100 = OpLoad %v4float %x_GLF_color
+        %101 = OpCompositeConstruct %main_out %100
+               OpReturnValue %101
                OpFunctionEnd
        %main = OpFunction %void None %22
-        %102 = OpLabel
-        %103 = OpFunctionCall %void %main_1
-        %105 = OpLoad %v4float %x_GLF_color
-        %106 = OpCompositeConstruct %main_out %105
-        %104 = OpFunctionCall %void %tint_symbol_2 %106
+        %103 = OpLabel
+        %104 = OpFunctionCall %main_out %main_inner
+        %105 = OpCompositeExtract %v4float %104 0
+               OpStore %x_GLF_color_1_1 %105
                OpReturn
                OpFunctionEnd