spirv: Use generic transform to process shader IO

The refactored CanonicalizeEntryPointIO transform makes it much easier
to handle SPIR-V style IO as well, and doing this removes a lot of
duplicated code. Remove all of the SPIR-V transform code for shader IO
and vertex point size.

Bug: tint:920
Change-Id: Id1b97517619b4d2fd09b45d5aee848259f3dfa77
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/60840
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: James Price <jrprice@google.com>
Auto-Submit: James Price <jrprice@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

test/vk-gl-cts/graphicsfuzz/do-while-loop-in-conditionals/0-opt.spvasm.expected.spvasm

@@ -5,31 +5,31 @@
 ; Schema: 0
                OpCapability Shader
                OpMemoryModel Logical GLSL450
-               OpEntryPoint Fragment %main "main" %tint_symbol %tint_symbol_2
+               OpEntryPoint Fragment %main "main" %gl_FragCoord_param_1 %x_GLF_color_1_1
                OpExecutionMode %main OriginUpperLeft
+               OpName %gl_FragCoord_param_1 "gl_FragCoord_param_1"
+               OpName %x_GLF_color_1_1 "x_GLF_color_1_1"
                OpName %x_GLF_color "x_GLF_color"
                OpName %gl_FragCoord "gl_FragCoord"
-               OpName %tint_symbol "tint_symbol"
-               OpName %tint_symbol_2 "tint_symbol_2"
                OpName %main_1 "main_1"
                OpName %main_out "main_out"
                OpMemberName %main_out 0 "x_GLF_color_1"
-               OpName %tint_symbol_3 "tint_symbol_3"
-               OpName %tint_symbol_1 "tint_symbol_1"
+               OpName %main_inner "main_inner"
+               OpName %gl_FragCoord_param "gl_FragCoord_param"
                OpName %main "main"
-               OpDecorate %tint_symbol BuiltIn FragCoord
-               OpDecorate %tint_symbol_2 Location 0
+               OpDecorate %gl_FragCoord_param_1 BuiltIn FragCoord
+               OpDecorate %x_GLF_color_1_1 Location 0
                OpMemberDecorate %main_out 0 Offset 0
       %float = OpTypeFloat 32
     %v4float = OpTypeVector %float 4
-%_ptr_Private_v4float = OpTypePointer Private %v4float
-          %5 = OpConstantNull %v4float
-%x_GLF_color = OpVariable %_ptr_Private_v4float Private %5
-%gl_FragCoord = OpVariable %_ptr_Private_v4float Private %5
 %_ptr_Input_v4float = OpTypePointer Input %v4float
-%tint_symbol = OpVariable %_ptr_Input_v4float Input
+%gl_FragCoord_param_1 = OpVariable %_ptr_Input_v4float Input
 %_ptr_Output_v4float = OpTypePointer Output %v4float
-%tint_symbol_2 = OpVariable %_ptr_Output_v4float Output %5
+          %7 = OpConstantNull %v4float
+%x_GLF_color_1_1 = OpVariable %_ptr_Output_v4float Output %7
+%_ptr_Private_v4float = OpTypePointer Private %v4float
+%x_GLF_color = OpVariable %_ptr_Private_v4float Private %7
+%gl_FragCoord = OpVariable %_ptr_Private_v4float Private %7
        %void = OpTypeVoid
          %11 = OpTypeFunction %void
     %float_1 = OpConstant %float 1
@@ -41,7 +41,7 @@
      %uint_0 = OpConstant %uint 0
 %_ptr_Private_float = OpTypePointer Private %float
    %main_out = OpTypeStruct %v4float
-         %37 = OpTypeFunction %void %main_out
+         %37 = OpTypeFunction %main_out %v4float
      %main_1 = OpFunction %void None %11
          %14 = OpLabel
                OpStore %x_GLF_color %17
@@ -73,20 +73,20 @@
          %20 = OpLabel
                OpReturn
                OpFunctionEnd
-%tint_symbol_3 = OpFunction %void None %37
-%tint_symbol_1 = OpFunctionParameter %main_out
+ %main_inner = OpFunction %main_out None %37
+%gl_FragCoord_param = OpFunctionParameter %v4float
          %41 = OpLabel
-         %42 = OpCompositeExtract %v4float %tint_symbol_1 0
-               OpStore %tint_symbol_2 %42
-               OpReturn
+               OpStore %gl_FragCoord %gl_FragCoord_param
+         %42 = OpFunctionCall %void %main_1
+         %43 = OpLoad %v4float %x_GLF_color
+         %44 = OpCompositeConstruct %main_out %43
+               OpReturnValue %44
                OpFunctionEnd
        %main = OpFunction %void None %11
-         %44 = OpLabel
-         %45 = OpLoad %v4float %tint_symbol
-               OpStore %gl_FragCoord %45
-         %46 = OpFunctionCall %void %main_1
-         %48 = OpLoad %v4float %x_GLF_color
-         %49 = OpCompositeConstruct %main_out %48
-         %47 = OpFunctionCall %void %tint_symbol_3 %49
+         %46 = OpLabel
+         %48 = OpLoad %v4float %gl_FragCoord_param_1
+         %47 = OpFunctionCall %main_out %main_inner %48
+         %49 = OpCompositeExtract %v4float %47 0
+               OpStore %x_GLF_color_1_1 %49
                OpReturn
                OpFunctionEnd

test/vk-gl-cts/graphicsfuzz/do-while-loop-in-conditionals/0-opt.wgsl.expected.spvasm

@@ -5,31 +5,31 @@
 ; Schema: 0
                OpCapability Shader
                OpMemoryModel Logical GLSL450
-               OpEntryPoint Fragment %main "main" %tint_symbol %tint_symbol_2
+               OpEntryPoint Fragment %main "main" %gl_FragCoord_param_1 %x_GLF_color_1_1
                OpExecutionMode %main OriginUpperLeft
+               OpName %gl_FragCoord_param_1 "gl_FragCoord_param_1"
+               OpName %x_GLF_color_1_1 "x_GLF_color_1_1"
                OpName %x_GLF_color "x_GLF_color"
                OpName %gl_FragCoord "gl_FragCoord"
-               OpName %tint_symbol "tint_symbol"
-               OpName %tint_symbol_2 "tint_symbol_2"
                OpName %main_1 "main_1"
                OpName %main_out "main_out"
                OpMemberName %main_out 0 "x_GLF_color_1"
-               OpName %tint_symbol_3 "tint_symbol_3"
-               OpName %tint_symbol_1 "tint_symbol_1"
+               OpName %main_inner "main_inner"
+               OpName %gl_FragCoord_param "gl_FragCoord_param"
                OpName %main "main"
-               OpDecorate %tint_symbol BuiltIn FragCoord
-               OpDecorate %tint_symbol_2 Location 0
+               OpDecorate %gl_FragCoord_param_1 BuiltIn FragCoord
+               OpDecorate %x_GLF_color_1_1 Location 0
                OpMemberDecorate %main_out 0 Offset 0
       %float = OpTypeFloat 32
     %v4float = OpTypeVector %float 4
-%_ptr_Private_v4float = OpTypePointer Private %v4float
-          %5 = OpConstantNull %v4float
-%x_GLF_color = OpVariable %_ptr_Private_v4float Private %5
-%gl_FragCoord = OpVariable %_ptr_Private_v4float Private %5
 %_ptr_Input_v4float = OpTypePointer Input %v4float
-%tint_symbol = OpVariable %_ptr_Input_v4float Input
+%gl_FragCoord_param_1 = OpVariable %_ptr_Input_v4float Input
 %_ptr_Output_v4float = OpTypePointer Output %v4float
-%tint_symbol_2 = OpVariable %_ptr_Output_v4float Output %5
+          %7 = OpConstantNull %v4float
+%x_GLF_color_1_1 = OpVariable %_ptr_Output_v4float Output %7
+%_ptr_Private_v4float = OpTypePointer Private %v4float
+%x_GLF_color = OpVariable %_ptr_Private_v4float Private %7
+%gl_FragCoord = OpVariable %_ptr_Private_v4float Private %7
        %void = OpTypeVoid
          %11 = OpTypeFunction %void
     %float_1 = OpConstant %float 1
@@ -41,7 +41,7 @@
      %uint_0 = OpConstant %uint 0
 %_ptr_Private_float = OpTypePointer Private %float
    %main_out = OpTypeStruct %v4float
-         %37 = OpTypeFunction %void %main_out
+         %37 = OpTypeFunction %main_out %v4float
      %main_1 = OpFunction %void None %11
          %14 = OpLabel
                OpStore %x_GLF_color %17
@@ -73,20 +73,20 @@
          %20 = OpLabel
                OpReturn
                OpFunctionEnd
-%tint_symbol_3 = OpFunction %void None %37
-%tint_symbol_1 = OpFunctionParameter %main_out
+ %main_inner = OpFunction %main_out None %37
+%gl_FragCoord_param = OpFunctionParameter %v4float
          %41 = OpLabel
-         %42 = OpCompositeExtract %v4float %tint_symbol_1 0
-               OpStore %tint_symbol_2 %42
-               OpReturn
+               OpStore %gl_FragCoord %gl_FragCoord_param
+         %42 = OpFunctionCall %void %main_1
+         %43 = OpLoad %v4float %x_GLF_color
+         %44 = OpCompositeConstruct %main_out %43
+               OpReturnValue %44
                OpFunctionEnd
        %main = OpFunction %void None %11
-         %44 = OpLabel
-         %45 = OpLoad %v4float %tint_symbol
-               OpStore %gl_FragCoord %45
-         %46 = OpFunctionCall %void %main_1
-         %48 = OpLoad %v4float %x_GLF_color
-         %49 = OpCompositeConstruct %main_out %48
-         %47 = OpFunctionCall %void %tint_symbol_3 %49
+         %46 = OpLabel
+         %48 = OpLoad %v4float %gl_FragCoord_param_1
+         %47 = OpFunctionCall %main_out %main_inner %48
+         %49 = OpCompositeExtract %v4float %47 0
+               OpStore %x_GLF_color_1_1 %49
                OpReturn
                OpFunctionEnd