encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tint: Minor improvements 

I forgot to fold this into crbug.com/tint/100861

Bug: tint:1581
Change-Id: I8f8faef7765b525316e2c927504cce88a93d24ee
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101303
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
This commit is contained in:
Antonio Maiorano 2022-09-06 18:40:33 +00:00 committed by Dawn LUCI CQ
parent 185fd3deca
commit 11e2571aed
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/tint/number.h
View File

@ -78,16 +78,18 @@ constexpr bool IsFloatingPoint =
std::is_floating_point_v<U> || std::is_same_v<T, detail::NumberKindF16>; std::is_floating_point_v<U> || std::is_same_v<T, detail::NumberKindF16>;
/// Evaluates to true iff T or Number<T> is an integral type. /// Evaluates to true iff T or Number<T> is an integral type.
template <typename T, typename U = std::conditional_t<IsNumber<T>, UnwrapNumber<T>, T>> template <typename T>
constexpr bool IsIntegral = std::is_integral_v<U>; constexpr bool IsIntegral = std::is_integral_v<UnwrapNumber<T>>;
/// Evaluates to true iff T or Number<T> is a signed integer type. /// Evaluates to true iff T or Number<T> is a signed integer type.
template <typename T, typename U = std::conditional_t<IsNumber<T>, UnwrapNumber<T>, T>> template <typename T>
constexpr bool IsSignedIntegral = std::is_integral_v<U> && std::is_signed_v<U>; constexpr bool IsSignedIntegral =
std::is_integral_v<UnwrapNumber<T>> && std::is_signed_v<UnwrapNumber<T>>;
/// Evaluates to true iff T or Number<T> is an unsigned integer type. /// Evaluates to true iff T or Number<T> is an unsigned integer type.
template <typename T, typename U = std::conditional_t<IsNumber<T>, UnwrapNumber<T>, T>> template <typename T>
constexpr bool IsUnsignedIntegral = std::is_integral_v<U> && std::is_unsigned_v<U>; constexpr bool IsUnsignedIntegral =
std::is_integral_v<UnwrapNumber<T>> && std::is_unsigned_v<UnwrapNumber<T>>;
/// Evaluates to true iff T is an integer type, floating-point type or is NumberKindF16. /// Evaluates to true iff T is an integer type, floating-point type or is NumberKindF16.
template <typename T> template <typename T>

2
src/tint/resolver/const_eval_test.cc
View File

@ -99,6 +99,7 @@ template <typename Vec, typename... Vecs>
return std::move(v1); return std::move(v1);
} }
// Concats vectors `vs` into `v1`
template <typename Vec, typename... Vecs> template <typename Vec, typename... Vecs>
void ConcatInto(Vec& v1, Vecs&&... vs) { void ConcatInto(Vec& v1, Vecs&&... vs) {
auto total_size = v1.size() + (vs.size() + ...); auto total_size = v1.size() + (vs.size() + ...);
@ -106,6 +107,7 @@ void ConcatInto(Vec& v1, Vecs&&... vs) {
(std::move(vs.begin(), vs.end(), std::back_inserter(v1)), ...); (std::move(vs.begin(), vs.end(), std::back_inserter(v1)), ...);
} }
// Concats vectors `vs` into `v1` iff `condition` is true
template <bool condition, typename Vec, typename... Vecs> template <bool condition, typename Vec, typename... Vecs>
void ConcatIntoIf([[maybe_unused]] Vec& v1, [[maybe_unused]] Vecs&&... vs) { void ConcatIntoIf([[maybe_unused]] Vec& v1, [[maybe_unused]] Vecs&&... vs) {
if constexpr (condition) { if constexpr (condition) {