encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make formatting an error on presubmit 

Currently the presubmit will emit a warning if the formatting fails
but this is easy to miss as the bot goes green. This CL changes
the presubmit to make formatting an error so the issue will be
caught and fixedup before landing.

Change-Id: Ifb83d2a7e524fd086e86b47f7518fea1e65f6d3e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/109563
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
This commit is contained in:
dan sinclair 2022-11-10 18:23:41 +00:00 committed by Dawn LUCI CQ
parent b77332edd2
commit 17f204769c
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
PRESUBMIT.py
View File

@ -131,10 +131,17 @@ def _DoCommonChecks(input_api, output_api):
results = [] results = []
results.extend( results.extend(
input_api.canned_checks.CheckChangedLUCIConfigs(input_api, output_api)) input_api.canned_checks.CheckChangedLUCIConfigs(input_api, output_api))
result_factory = output_api.PresubmitPromptWarning
if input_api.is_committing:
result_factory = output_api.PresubmitError
results.extend( results.extend(
input_api.canned_checks.CheckPatchFormatted(input_api, input_api.canned_checks.CheckPatchFormatted(
output_api, input_api,
check_python=True)) output_api,
check_python=True,
result_factory=result_factory))
results.extend( results.extend(
input_api.canned_checks.CheckChangeHasDescription( input_api.canned_checks.CheckChangeHasDescription(
input_api, output_api)) input_api, output_api))