encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Moves remaining logic in BindGroup dtor into Destroy. 

Bug: dawn:628
Change-Id: I2e6a403c89e450efc952c91a2d497b99aa60c298
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71244
Commit-Queue: Loko Kung <lokokung@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
This commit is contained in:
Loko Kung 2021-12-01 19:32:00 +00:00 committed by Dawn LUCI CQ
parent 6331f959c1
commit 1d47bac0fc
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/dawn_native/BindGroup.cpp
View File

@ -399,7 +399,9 @@ namespace dawn_native {
TrackInDevice(); TrackInDevice();
} }
BindGroupBase::~BindGroupBase() { BindGroupBase::~BindGroupBase() = default;
void BindGroupBase::DestroyImpl() {
if (mLayout != nullptr) { if (mLayout != nullptr) {
ASSERT(!IsError()); ASSERT(!IsError());
for (BindingIndex i{0}; i < mLayout->GetBindingCount(); ++i) { for (BindingIndex i{0}; i < mLayout->GetBindingCount(); ++i) {
@ -408,9 +410,6 @@ namespace dawn_native {
} }
} }
void BindGroupBase::DestroyImpl() {
}
void BindGroupBase::DeleteThis() { void BindGroupBase::DeleteThis() {
// Add another ref to the layout so that if this is the last ref, the layout // Add another ref to the layout so that if this is the last ref, the layout
// is destroyed after the bind group. The bind group is slab-allocated inside // is destroyed after the bind group. The bind group is slab-allocated inside