encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-07-23 13:35:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Skip some end2end tests for Vulkan validation layers enable on Windows"

Browse Source 
This reverts commit 4cc1891039150a63ded4ba3e9a61facb67745fa5.

Reason for revert: dawn:210 has been fixed, we can add these tests back.

Original change's description:
> Skip some end2end tests for Vulkan validation layers enable on Windows
> 
> Temporarily skip some tests to make Vulkan validation layers could be
> enabled on Windows, these tests are failing on Vulkan with validation
> layers enabled.
> 
> BUG=dawn:210
> 
> Change-Id: I03a6ab6aca94f7c7044cc27cc1ff5d79ad1f88d2
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11141
> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>

TBR=cwallez@chromium.org,yunchao.he@intel.com,jiawei.shao@intel.com,shaobo.yan@intel.com,hao.x.li@intel.com,enga@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: dawn:210
Change-Id: I4f86369aa0dbfe366b0597cc844af4e74d687eea
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11280
Reviewed-by: Hao Li <hao.x.li@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Hao Li <hao.x.li@intel.com>
This commit is contained in:
Hao Li 2019-09-17 02:36:22 +00:00 committed by Commit Bot service account
parent 785ec66b66
commit 2383fd4fbf
3 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/tests/end2end/MultisampledRenderingTests.cpp
View File

@ -255,10 +255,6 @@ TEST_P(MultisampledRenderingTest, ResolveInto2DTexture) {
// Test multisampled rendering with depth test works correctly.
TEST_P(MultisampledRenderingTest, MultisampledRenderingWithDepthTest) {
// Test failing on Vulkan with validation layer enabled
// See https://bugs.chromium.org/p/dawn/issues/detail?id=210
DAWN_SKIP_TEST_IF(IsVulkan() && IsBackendValidationEnabled());
constexpr bool kTestDepth = true;
dawn::CommandEncoder commandEncoder = device.CreateCommandEncoder();
dawn::RenderPipeline pipeline = CreateRenderPipelineWithOneOutputForTest(kTestDepth);

12
src/tests/end2end/TextureZeroInitTests.cpp
View File

@ -300,10 +300,6 @@ TEST_P(TextureZeroInitTest, CopyTextureToTextureHalf) {
// This tests the texture with depth attachment and load op load will init depth stencil texture to
// 0s.
TEST_P(TextureZeroInitTest, RenderingLoadingDepth) {
// Test failing on Vulkan with validation layer enabled
// See https://bugs.chromium.org/p/dawn/issues/detail?id=210
DAWN_SKIP_TEST_IF(IsVulkan() && IsBackendValidationEnabled());
dawn::TextureDescriptor srcDescriptor =
CreateTextureDescriptor(1, 1,
dawn::TextureUsage::CopySrc | dawn::TextureUsage::CopyDst |
@ -341,10 +337,6 @@ TEST_P(TextureZeroInitTest, RenderingLoadingDepth) {
// This tests the texture with stencil attachment and load op load will init depth stencil texture
// to 0s.
TEST_P(TextureZeroInitTest, RenderingLoadingStencil) {
// Test failing on Vulkan with validation layer enabled
// See https://bugs.chromium.org/p/dawn/issues/detail?id=210
DAWN_SKIP_TEST_IF(IsVulkan() && IsBackendValidationEnabled());
dawn::TextureDescriptor srcDescriptor =
CreateTextureDescriptor(1, 1,
dawn::TextureUsage::CopySrc | dawn::TextureUsage::CopyDst |
@ -382,10 +374,6 @@ TEST_P(TextureZeroInitTest, RenderingLoadingStencil) {
// This tests the texture with depth stencil attachment and load op load will init depth stencil
// texture to 0s.
TEST_P(TextureZeroInitTest, RenderingLoadingDepthStencil) {
// Test failing on Vulkan with validation layer enabled
// See https://bugs.chromium.org/p/dawn/issues/detail?id=210
DAWN_SKIP_TEST_IF(IsVulkan() && IsBackendValidationEnabled());
dawn::TextureDescriptor srcDescriptor =
CreateTextureDescriptor(1, 1,
dawn::TextureUsage::CopySrc | dawn::TextureUsage::CopyDst |

4
src/tests/end2end/VertexInputTests.cpp
View File

@ -523,10 +523,6 @@ class OptionalVertexInputTest : public DawnTest {};
// Test that vertex input is not required in render pipeline descriptor.
TEST_P(OptionalVertexInputTest, Basic) {
// Test failing on Vulkan with validation layer enabled
// See https://bugs.chromium.org/p/dawn/issues/detail?id=210
DAWN_SKIP_TEST_IF(IsVulkan() && IsBackendValidationEnabled());
utils::BasicRenderPass renderPass = utils::CreateBasicRenderPass(device, 3, 3);
dawn::ShaderModule vsModule =