encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[validation]: Add disabled test for validating return statement type matches function types 

Bug: tint: 6
Change-Id: I573cd4fb5759f1d72dd2e0f04a1dd183879745d6
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/26723
Commit-Queue: Sarah Mashayekhi <sarahmashay@google.com>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
This commit is contained in:
Sarah Mashayekhi 2020-08-13 19:17:49 +00:00 committed by Commit Bot service account
parent d73f812c84
commit 23c3fee354
1 changed files with 76 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
src/validator_function_test.cc
View File

@ -16,6 +16,7 @@
#include "gtest/gtest.h"
#include "spirv/unified1/GLSL.std.450.h"
#include "src/ast/return_statement.h"
#include "src/ast/scalar_constructor_expression.h"
#include "src/ast/sint_literal.h"
#include "src/ast/type/f32_type.h"
@ -87,5 +88,80 @@ TEST_F(ValidateFunctionTest, FunctionEndWithoutReturnStatementEmptyBody_Fail) {
"12:34: v-0002: function must end with a return statement");
}
TEST_F(ValidateFunctionTest,
DISABLED_FunctionTypeMustMatchReturnStatementType_pass) {
// TODO(sarahM0): remove DISABLED after implementing function type must match
// return type
// fn func -> void { return; }
ast::type::VoidType void_type;
ast::VariableList params;
auto func =
std::make_unique<ast::Function>("func", std::move(params), &void_type);
auto body = std::make_unique<ast::BlockStatement>();
body->append(std::make_unique<ast::ReturnStatement>());
func->set_body(std::move(body));
mod()->AddFunction(std::move(func));
EXPECT_TRUE(td()->Determine()) << td()->error();
tint::ValidatorImpl v;
EXPECT_TRUE(v.Validate(mod())) << v.error();
}
TEST_F(ValidateFunctionTest,
DISABLED_FunctionTypeMustMatchReturnStatementType_fail) {
// TODO(sarahM0): remove DISABLED after implementing function type must match
// return type
// fn func -> void { return 2; }
ast::type::VoidType void_type;
ast::type::I32Type i32;
ast::VariableList params;
auto func =
std::make_unique<ast::Function>("func", std::move(params), &void_type);
auto body = std::make_unique<ast::BlockStatement>();
auto return_expr = std::make_unique<ast::ScalarConstructorExpression>(
std::make_unique<ast::SintLiteral>(&i32, 2));
body->append(std::make_unique<ast::ReturnStatement>(Source{12, 34},
std::move(return_expr)));
func->set_body(std::move(body));
mod()->AddFunction(std::move(func));
EXPECT_TRUE(td()->Determine()) << td()->error();
tint::ValidatorImpl v;
EXPECT_FALSE(v.Validate(mod()));
// TODO(sarahM0): replace 000y with a rule number
EXPECT_EQ(
v.error(),
"12:34: v-000y: function type must match its return statement type");
}
TEST_F(ValidateFunctionTest,
DISABLED_FunctionTypeMustMatchReturnStatementTypeF32_fail) {
// TODO(sarahM0): remove DISABLED after implementing function type must match
// return type
// fn func -> f32 { return 2; }
ast::type::VoidType void_type;
ast::type::I32Type i32;
ast::type::F32Type f32;
ast::VariableList params;
auto func = std::make_unique<ast::Function>("func", std::move(params), &f32);
auto body = std::make_unique<ast::BlockStatement>();
auto return_expr = std::make_unique<ast::ScalarConstructorExpression>(
std::make_unique<ast::SintLiteral>(&i32, 2));
body->append(std::make_unique<ast::ReturnStatement>(Source{12, 34},
std::move(return_expr)));
func->set_body(std::move(body));
mod()->AddFunction(std::move(func));
EXPECT_TRUE(td()->Determine()) << td()->error();
tint::ValidatorImpl v;
EXPECT_FALSE(v.Validate(mod()));
// TODO(sarahM0): replace 000y with a rule number
EXPECT_EQ(
v.error(),
"12:34: v-000y: function type must match its return statement type");
}
} // namespace
} // namespace tint