encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

D3D12: Re-enable FXC tests 

Enough FXC workaround have been added to tint that these tests now pass again.

Fixed: tint:904
Change-Id: I6dd355d131ab903ae579391c0bfce93979dfc4f1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/57041
Commit-Queue: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Ben Clayton 2021-07-06 10:49:50 +00:00 committed by Dawn LUCI CQ
parent 435ebfcc40
commit 2828f35a71
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/tests/end2end/VertexFormatTests.cpp
View File

@ -52,9 +52,6 @@ class VertexFormatTest : public DawnTest {
// TODO(crbug.com/dawn/259): Failing because of a SPIRV-Cross issue.
DAWN_SUPPRESS_TEST_IF(IsMetal() && IsIntel());
// TODO(crbug.com/tint/904): FXC emits bad output for this test
DAWN_SUPPRESS_TEST_IF(IsD3D12() && !IsDXC() && HasToggleEnabled("use_tint_generator"));
renderPass = utils::CreateBasicRenderPass(device, kRTSize, kRTSize);
}

3
src/tests/perf_tests/ShaderRobustnessPerf.cpp
View File

@ -409,9 +409,6 @@ void ShaderRobustnessPerf::SetUp() {
// TODO(crbug.com/dawn/786): D3D12_Microsoft_Basic_Render_Driver_CPU
DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsWARP());
// TODO(crbug.com/tint/904): FXC emits bad output for this test
DAWN_SUPPRESS_TEST_IF(IsD3D12() && !IsDXC() && HasToggleEnabled("use_tint_generator"));
// TODO(crbug.com/dawn/945): Generation via SPIRV-Cross fails
DAWN_SUPPRESS_TEST_IF(IsOpenGL() || !HasToggleEnabled("use_tint_generator"));