encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove double test instantiation with/without use_tint_generator 

The test bots now instantiate separate test suites with/without
this toggle.

Bug: dawn:571
Change-Id: Ib4e8e89ac347d0030b233d1a3b14b318aa862aa6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/56440
Commit-Queue: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Austin Eng 2021-06-29 17:29:23 +00:00 committed by Dawn LUCI CQ
parent 3194a08615
commit 2a5fd58832
1 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/tests/DawnTest.cpp
View File

@ -549,21 +549,6 @@ std::vector<AdapterTestParam> DawnTestEnvironment::GetAvailableAdapterTestParams
if (params[i].backendType == adapterProperties.backendType &&
adapterProperties.selected) {
testParams.push_back(AdapterTestParam(params[i], adapterProperties));
// HACK: This is a hack to get Tint generator enabled on all tests
// without adding a new test suite in Chromium's infra config but skipping
// that suite on all unsupported platforms. Once we have basic functionality and
// test skips on all backends, we can remove this and use a test suite with
// use_tint_generator in the command line args instead.
if (params[i].backendType == wgpu::BackendType::Vulkan ||
params[i].backendType == wgpu::BackendType::D3D12 ||
params[i].backendType == wgpu::BackendType::Metal ||
params[i].backendType == wgpu::BackendType::OpenGL ||
params[i].backendType == wgpu::BackendType::OpenGLES) {
BackendTestConfig configWithTint = params[i];
configWithTint.forceEnabledWorkarounds.push_back("use_tint_generator");
testParams.push_back(AdapterTestParam(configWithTint, adapterProperties));
}
}
}
}