encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-14 07:36:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make ComboVertexStateDescriptor non-copyable non-movable.

Browse Source 
The VertexState tests were failing on MSVC debug x64 because the
ComboVertexStateDescriptor was copied but internal pointer to
itself weren't updated. This commit makes the structure non-movable and
non-copyable so the problem doesn't happen in the future and fixes
compilation errors.

Bug: dawn:602
Change-Id: Idd3a68933920eb47939217362e9e137dd7581014
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/38400
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Corentin Wallez
2021-01-22 17:51:45 +00:00
committed by Commit Bot service account
parent db1572102b
commit 2c32fa6476
3 changed files with 76 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/utils/ComboRenderPipelineDescriptor.h
View File

@@ -27,6 +27,11 @@ namespace utils {
public:
ComboVertexStateDescriptor();
ComboVertexStateDescriptor(const ComboVertexStateDescriptor&) = delete;
ComboVertexStateDescriptor& operator=(const ComboVertexStateDescriptor&) = delete;
ComboVertexStateDescriptor(ComboVertexStateDescriptor&&) = delete;
ComboVertexStateDescriptor& operator=(ComboVertexStateDescriptor&&) = delete;
std::array<wgpu::VertexBufferLayoutDescriptor, kMaxVertexBuffers> cVertexBuffers;
std::array<wgpu::VertexAttributeDescriptor, kMaxVertexAttributes> cAttributes;
};