encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Delint RefBaseTests.cpp 

This commit removes the lines from RefBaseTests.cpp that access
a moved-from object after move. This change removes "use-after-
move" clang-tidy warning.

There is no pointing testing the behavior of moved-from objects
because it can be avoided with clang-tidy check.

Bug: dawn:1439
Change-Id: If2144db2b50ad3f5a6d7a8d402b2978db4d8bd16
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/92620
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Takahiro <hogehoge@gachapin.jp>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Takahiro 2022-06-04 03:40:41 +00:00 committed by Dawn LUCI CQ
parent 9e6997ff68
commit 2f5d8e33d7
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/dawn/tests/unittests/RefBaseTests.cpp
View File

@ -244,11 +244,7 @@ TEST(RefBase, RefMoveAssignmentSelf) {
Ref& self = ref;
events.clear();
{
ref = std::move(self);
ref = std::move(self);
ref = std::move(self);
}
{ ref = std::move(self); }
EXPECT_THAT(events, testing::ElementsAre());
}