encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-11 22:44:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

writer/hlsl: Use unsigned indices for UBOs

Browse Source 
These indices were a mix of signed and unsigned.
Modulus on the signed integers was producing FXC warnings about performance.

Change-Id: Ib82f4296199a09d2f03be8b06314feefce0022e2
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/56765
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: David Neto <dneto@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
This commit is contained in:
Ben Clayton
2021-07-02 19:27:42 +00:00
parent 2bb45389b7
commit 3124d43fda
16 changed files with 73 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/writer/hlsl/generator_impl.cc
View File

@@ -623,7 +623,7 @@ bool GeneratorImpl::EmitUniformBufferAccess(
std::string scalar_offset = UniqueIdentifier("scalar_offset");
{
auto pre = line();
pre << "const int " << scalar_offset << " = (";
pre << "const uint " << scalar_offset << " = (";
if (!EmitExpression(pre, params[1])) { // offset
return false;
}