encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enable two cases in TextureZeroInitTests with swiftshader 

This patch enables two tests with swiftshader after the fix in
https://dawn-review.googlesource.com/c/dawn/+/23200.

BUG=dawn:22
TEST=dawn_end2end_tests

Change-Id: I27ff5afe6735aff3c416cbe65d039006b1ceae55
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/24040
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Jiawei Shao 2020-06-29 08:30:03 +00:00 committed by Commit Bot service account
parent ff90599cdf
commit 330c272fc4
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/tests/end2end/TextureZeroInitTests.cpp
View File

@ -133,10 +133,6 @@ TEST_P(TextureZeroInitTest, CopyTextureToBufferSource) {
// This tests that the code path of CopyTextureToBuffer with multiple texture array layers clears // This tests that the code path of CopyTextureToBuffer with multiple texture array layers clears
// correctly to Zero after first usage // correctly to Zero after first usage
TEST_P(TextureZeroInitTest, CopyMultipleTextureArrayLayersToBufferSource) { TEST_P(TextureZeroInitTest, CopyMultipleTextureArrayLayersToBufferSource) {
// TODO(jiawei.shao@intel.com): investigate why copies with multiple texture array layers fail
// with swiftshader.
DAWN_SKIP_TEST_IF(IsSwiftshader());
constexpr uint32_t kArrayLayers = 6u; constexpr uint32_t kArrayLayers = 6u;
const wgpu::TextureDescriptor descriptor = CreateTextureDescriptor( const wgpu::TextureDescriptor descriptor = CreateTextureDescriptor(
@ -328,10 +324,6 @@ TEST_P(TextureZeroInitTest, CopyBufferToTextureHalf) {
// This tests CopyBufferToTexture fully overwrites a range of subresources, so lazy initialization // This tests CopyBufferToTexture fully overwrites a range of subresources, so lazy initialization
// is needed for neither the subresources involved in the copy nor the other subresources. // is needed for neither the subresources involved in the copy nor the other subresources.
TEST_P(TextureZeroInitTest, CopyBufferToTextureMultipleArrayLayers) { TEST_P(TextureZeroInitTest, CopyBufferToTextureMultipleArrayLayers) {
// TODO(jiawei.shao@intel.com): investigate why copies with multiple texture array layers fail
// with swiftshader.
DAWN_SKIP_TEST_IF(IsSwiftshader());
wgpu::TextureDescriptor descriptor = CreateTextureDescriptor( wgpu::TextureDescriptor descriptor = CreateTextureDescriptor(
1, 6, wgpu::TextureUsage::CopyDst | wgpu::TextureUsage::CopySrc, kColorFormat); 1, 6, wgpu::TextureUsage::CopyDst | wgpu::TextureUsage::CopySrc, kColorFormat);
wgpu::Texture texture = device.CreateTexture(&descriptor); wgpu::Texture texture = device.CreateTexture(&descriptor);