Replace Type::(Is|As)Sampler with Castable

Change-Id: Iaa43e607199e25308ecb121c61bb7a37abff197c
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/34270
Reviewed-by: dan sinclair <dsinclair@chromium.org>
This commit is contained in:
Ben Clayton
2020-11-30 23:30:58 +00:00
parent c52f4214ad
commit 351128a41e
28 changed files with 36 additions and 63 deletions

View File

@@ -37,8 +37,8 @@ TEST_F(ParserImplTest, SamplerType_Sampler) {
EXPECT_TRUE(t.matched);
EXPECT_FALSE(t.errored);
ASSERT_NE(t.value, nullptr);
ASSERT_TRUE(t->IsSampler());
EXPECT_FALSE(t->AsSampler()->IsComparison());
ASSERT_TRUE(t->Is<ast::type::SamplerType>());
EXPECT_FALSE(t->As<ast::type::SamplerType>()->IsComparison());
EXPECT_FALSE(p->has_error());
}
@@ -48,8 +48,8 @@ TEST_F(ParserImplTest, SamplerType_ComparisonSampler) {
EXPECT_TRUE(t.matched);
EXPECT_FALSE(t.errored);
ASSERT_NE(t.value, nullptr);
ASSERT_TRUE(t->IsSampler());
EXPECT_TRUE(t->AsSampler()->IsComparison());
ASSERT_TRUE(t->Is<ast::type::SamplerType>());
EXPECT_TRUE(t->As<ast::type::SamplerType>()->IsComparison());
EXPECT_FALSE(p->has_error());
}

View File

@@ -42,8 +42,8 @@ TEST_F(ParserImplTest, TextureSamplerTypes_Sampler) {
EXPECT_TRUE(t.matched);
EXPECT_FALSE(t.errored);
ASSERT_NE(t.value, nullptr);
ASSERT_TRUE(t->IsSampler());
ASSERT_FALSE(t->AsSampler()->IsComparison());
ASSERT_TRUE(t->Is<ast::type::SamplerType>());
ASSERT_FALSE(t->As<ast::type::SamplerType>()->IsComparison());
}
TEST_F(ParserImplTest, TextureSamplerTypes_SamplerComparison) {
@@ -53,8 +53,8 @@ TEST_F(ParserImplTest, TextureSamplerTypes_SamplerComparison) {
EXPECT_TRUE(t.matched);
EXPECT_FALSE(t.errored);
ASSERT_NE(t.value, nullptr);
ASSERT_TRUE(t->IsSampler());
ASSERT_TRUE(t->AsSampler()->IsComparison());
ASSERT_TRUE(t->Is<ast::type::SamplerType>());
ASSERT_TRUE(t->As<ast::type::SamplerType>()->IsComparison());
}
TEST_F(ParserImplTest, TextureSamplerTypes_DepthTexture) {

View File

@@ -747,8 +747,8 @@ TEST_F(ParserImplTest, TypeDecl_Sampler) {
EXPECT_FALSE(t.errored);
ASSERT_NE(t.value, nullptr) << p->error();
EXPECT_EQ(t.value, type);
ASSERT_TRUE(t->IsSampler());
ASSERT_FALSE(t->AsSampler()->IsComparison());
ASSERT_TRUE(t->Is<ast::type::SamplerType>());
ASSERT_FALSE(t->As<ast::type::SamplerType>()->IsComparison());
}
TEST_F(ParserImplTest, TypeDecl_Texture_Old) {