encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Un-skip use_tint_generator tests using runtime arrays 

This is using the Tint -> SPIRV-Cross path, but Tint supports
the SPIR-V part now, so it works correctly in Dawn's tests.

Bug: tint:400
Change-Id: I6efd9447a9b454fb866467d65fda9350ec772f18
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/42560
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
This commit is contained in:
Austin Eng 2021-02-25 16:17:31 +00:00 committed by Commit Bot service account
parent 584ba432e9
commit 36dcb1a51a
3 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/tests/end2end/BufferZeroInitTests.cpp
View File

@ -1212,10 +1212,6 @@ TEST_P(BufferZeroInitTest, ResolveQuerySet) {
// Skip if timestamp extension is not supported on device // Skip if timestamp extension is not supported on device
DAWN_SKIP_TEST_IF(!SupportsExtensions({"timestamp_query"})); DAWN_SKIP_TEST_IF(!SupportsExtensions({"timestamp_query"}));
// TODO(crbug.com/tint/255, crbug.com/tint/256, crbug.com/tint/400, crbug.com/tint/417):
// Skip due to runtime array not currently supported in WGSL
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator"));
constexpr uint64_t kBufferSize = 16u; constexpr uint64_t kBufferSize = 16u;
constexpr wgpu::BufferUsage kBufferUsage = constexpr wgpu::BufferUsage kBufferUsage =
wgpu::BufferUsage::QueryResolve | wgpu::BufferUsage::CopyDst; wgpu::BufferUsage::QueryResolve | wgpu::BufferUsage::CopyDst;

4
src/tests/end2end/QueryTests.cpp
View File

@ -319,10 +319,6 @@ class TimestampQueryTests : public QueryTests {
// Skip all tests if timestamp extension is not supported // Skip all tests if timestamp extension is not supported
DAWN_SKIP_TEST_IF(!SupportsExtensions({"timestamp_query"})); DAWN_SKIP_TEST_IF(!SupportsExtensions({"timestamp_query"}));
// TODO(crbug.com/tint/255, crbug.com/tint/256, crbug.com/tint/400, crbug.com/tint/417):
// Skip use_tint_generator due to runtime array not supported in WGSL
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator"));
} }
std::vector<const char*> GetRequiredExtensions() override { std::vector<const char*> GetRequiredExtensions() override {

4
src/tests/white_box/QueryInternalShaderTests.cpp
View File

@ -88,10 +88,6 @@ class QueryInternalShaderTests : public DawnTest {};
TEST_P(QueryInternalShaderTests, TimestampComputeShader) { TEST_P(QueryInternalShaderTests, TimestampComputeShader) {
DAWN_SKIP_TEST_IF(UsesWire()); DAWN_SKIP_TEST_IF(UsesWire());
// TODO(crbug.com/tint/255, crbug.com/tint/256, crbug.com/tint/400, crbug.com/tint/417):
// There is no builtin support for doing the runtime array.
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator"));
constexpr uint32_t kTimestampCount = 10u; constexpr uint32_t kTimestampCount = 10u;
// A gpu frequency on Intel D3D12 (ticks/second) // A gpu frequency on Intel D3D12 (ticks/second)
constexpr uint64_t kGPUFrequency = 12000048u; constexpr uint64_t kGPUFrequency = 12000048u;