encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Resolve TODO in ResolveQuerySet validation 

The unavailable queries are allowed in ResolveQuerySet and resolved to
0s, which has been fixed in
https://dawn-review.googlesource.com/c/dawn/+/48320.

BUG: dawn:434
Change-Id: I72b1f0b621fc22a7a0d30c407c7359e59d7b905c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/53762
Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Hao Li 2021-06-08 10:04:34 +00:00 committed by Dawn LUCI CQ
parent e557296b08
commit 3a07f7410f
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/dawn_native/CommandEncoder.cpp
View File

@ -399,9 +399,6 @@ namespace dawn_native {
"set"); "set");
} }
// TODO(crbug.com/dawn/434): Validate that the queries between [firstQuery, firstQuery +
// queryCount - 1] must be available(written by query operations).
// The destinationOffset must be a multiple of 8 bytes on D3D12 and Vulkan // The destinationOffset must be a multiple of 8 bytes on D3D12 and Vulkan
if (destinationOffset % 8 != 0) { if (destinationOffset % 8 != 0) {
return DAWN_VALIDATION_ERROR( return DAWN_VALIDATION_ERROR(