encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-07-15 09:35:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "spirv-reader: add disabled test for compare sampling with explicit Lod"

Browse Source 
This reverts commit 4a7981e300f3e61fe0f7cb6e55e993dc3b7c2a93.

Reason for revert: Empty GTest Values() causes compilation error in Chromium.

Original change's description:
> spirv-reader: add disabled test for compare sampling with explicit Lod
>
> This is blocked by discussion at W3C
> https://github.com/gpuweb/gpuweb/issues/1319
>
> Bug: tint:482
> Change-Id: Ic3a2b32fb09a431edbd7716a394a9eb3f163fb85
> Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/40621
> Commit-Queue: Ben Clayton <bclayton@google.com>
> Reviewed-by: Ben Clayton <bclayton@google.com>
> Auto-Submit: David Neto <dneto@google.com>

TBR=dneto@google.com,bclayton@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: tint:482
Change-Id: I637c40950cd343196c2703c9854f584bf8f1c084
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/40603
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Corentin Wallez 2021-02-08 09:49:09 +00:00 committed by Commit Bot service account
parent 4a7981e300
commit 3c568f188d
1 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/reader/spirv/parser_impl_handle_test.cc
View File

@ -2494,20 +2494,6 @@ INSTANTIATE_TEST_SUITE_P(
ScalarConstructor[not set]{0.000000} ScalarConstructor[not set]{0.000000}
})"}})); })"}}));
INSTANTIATE_TEST_SUITE_P(DISABLED_ImageSampleDrefExplicitLod,
SpvParserTest_SampledImageAccessTest,
// crbug.com/tint/482
// Disabled pending the outcome of
// https://github.com/gpuweb/gpuweb/issues/1319
::testing::Values(
// depth 2D
// depth 2D offset
// depth 2D-array
// depth 2D-array offset
// depth cube
// depth cube-array
));
using SpvParserTest_ImageAccessTest = using SpvParserTest_ImageAccessTest =
SpvParserTestBase<::testing::TestWithParam<ImageAccessCase>>; SpvParserTestBase<::testing::TestWithParam<ImageAccessCase>>;