encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Only add extra warnings when building in standalone. 

This avoids breaking dependents when they use a version of clang that's
different than the one being tested on Dawn CQ.

Also re-enable -Wdeprecated-copy(-dtor)

Bug: chromium:1201858
Change-Id: I09763fdb98e7dba53b4d9fa66fa4c606620a0078
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/49100
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
This commit is contained in:
Corentin Wallez 2021-04-26 17:18:16 +00:00 committed by Commit Bot service account
parent 6d099f05e6
commit 3d71624bfd
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/common/BUILD.gn
View File

@ -89,12 +89,17 @@ config("dawn_internal") {
cflags = [] cflags = []
# Enable more warnings that were found when using Dawn in other projects # Enable more warnings that were found when using Dawn in other projects.
if (is_clang) { # Add them only when building in standalone because we control which clang
# version we use. Otherwise we risk breaking projects depending on Dawn when
# the use a different clang version.
if (dawn_standalone && is_clang) {
cflags += [ cflags += [
"-Wconditional-uninitialized", "-Wconditional-uninitialized",
"-Wcstring-format-directive", "-Wcstring-format-directive",
"-Wc++11-narrowing", "-Wc++11-narrowing",
"-Wdeprecated-copy",
"-Wdeprecated-copy-dtor",
"-Wduplicate-enum", "-Wduplicate-enum",
"-Wextra-semi-stmt", "-Wextra-semi-stmt",
"-Wimplicit-fallthrough", "-Wimplicit-fallthrough",