tint: Remove support for smoothStep builtin

The new spelling `smoothstep` was introduced in M102.

Fixed: tint:1483
Change-Id: Ia5e1401f8f09450a3a767b0bb975216bd85be8db
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/93360
Commit-Queue: James Price <jrprice@google.com>
Auto-Submit: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

docs/tint/origin-trial-changes.md

@@ -2,6 +2,10 @@
 
 ## Changes for M105
 
+### Breaking changes
+
+* The `smoothStep()` builtin has been removed (use `smoothstep` instead). [tint:1483](crbug.com/tint/1483)
+
 ### Deprecated Features
 
 * The `@stage` attribute has been deprecated. The short forms should be used

src/tint/intrinsics.def

@@ -448,8 +448,6 @@ fn sinh(f32) -> f32
 fn sinh<N: num>(vec<N, f32>) -> vec<N, f32>
 fn smoothstep(f32, f32, f32) -> f32
 fn smoothstep<N: num>(vec<N, f32>, vec<N, f32>, vec<N, f32>) -> vec<N, f32>
-@deprecated fn smoothStep(f32, f32, f32) -> f32
-@deprecated fn smoothStep<N: num>(vec<N, f32>, vec<N, f32>, vec<N, f32>) -> vec<N, f32>
 fn sqrt(f32) -> f32
 fn sqrt<N: num>(vec<N, f32>) -> vec<N, f32>
 fn step(f32, f32) -> f32

src/tint/resolver/builtin_test.cc

@@ -1263,7 +1263,6 @@ INSTANTIATE_TEST_SUITE_P(ResolverTest,
                          ResolverBuiltinTest_ThreeParam,
                          testing::Values(BuiltinData{"mix", BuiltinType::kMix},
                                          BuiltinData{"smoothstep", BuiltinType::kSmoothstep},
-                                         BuiltinData{"smoothStep", BuiltinType::kSmoothStep},
                                          BuiltinData{"fma", BuiltinType::kFma}));
 
 using ResolverBuiltinTest_ThreeParam_FloatOrInt = ResolverTestWithParam<BuiltinData>;

src/tint/sem/builtin_test.cc

@@ -93,7 +93,6 @@ INSTANTIATE_TEST_SUITE_P(
                     BuiltinData{"sin", BuiltinType::kSin},
                     BuiltinData{"sinh", BuiltinType::kSinh},
                     BuiltinData{"smoothstep", BuiltinType::kSmoothstep},
-                    BuiltinData{"smoothStep", BuiltinType::kSmoothStep},
                     BuiltinData{"sqrt", BuiltinType::kSqrt},
                     BuiltinData{"step", BuiltinType::kStep},
                     BuiltinData{"storageBarrier", BuiltinType::kStorageBarrier},

src/tint/sem/builtin_type.cc

@@ -233,9 +233,6 @@ BuiltinType ParseBuiltinType(const std::string& name) {
     if (name == "smoothstep") {
         return BuiltinType::kSmoothstep;
     }
-    if (name == "smoothStep") {
-        return BuiltinType::kSmoothStep;
-    }
     if (name == "sqrt") {
         return BuiltinType::kSqrt;
     }
@@ -493,8 +490,6 @@ const char* str(BuiltinType i) {
             return "sinh";
         case BuiltinType::kSmoothstep:
             return "smoothstep";
-        case BuiltinType::kSmoothStep:
-            return "smoothStep";
         case BuiltinType::kSqrt:
             return "sqrt";
         case BuiltinType::kStep:

src/tint/sem/builtin_type.h

@@ -101,7 +101,6 @@ enum class BuiltinType {
     kSin,
     kSinh,
     kSmoothstep,
-    kSmoothStep,
     kSqrt,
     kStep,
     kStorageBarrier,

src/tint/writer/glsl/generator_impl.cc

@@ -1701,7 +1701,6 @@ std::string GeneratorImpl::generate_builtin_name(const sem::Builtin* builtin) {
         case sem::BuiltinType::kReverseBits:
             return "bitfieldReverse";
         case sem::BuiltinType::kSmoothstep:
-        case sem::BuiltinType::kSmoothStep:
             return "smoothstep";
         case sem::BuiltinType::kUnpack2x16float:
             return "unpackHalf2x16";

src/tint/writer/glsl/generator_impl_builtin_test.cc

@@ -112,7 +112,6 @@ const ast::CallExpression* GenerateCall(BuiltinType builtin,
         case BuiltinType::kMix:
         case BuiltinType::kFaceForward:
         case BuiltinType::kSmoothstep:
-        case BuiltinType::kSmoothStep:
             return builder->Call(str.str(), "f2", "f2", "f2");
         case BuiltinType::kAll:
         case BuiltinType::kAny:
@@ -233,7 +232,6 @@ INSTANTIATE_TEST_SUITE_P(
                     BuiltinData{BuiltinType::kSin, ParamType::kF32, "sin"},
                     BuiltinData{BuiltinType::kSinh, ParamType::kF32, "sinh"},
                     BuiltinData{BuiltinType::kSmoothstep, ParamType::kF32, "smoothstep"},
-                    BuiltinData{BuiltinType::kSmoothStep, ParamType::kF32, "smoothstep"},
                     BuiltinData{BuiltinType::kSqrt, ParamType::kF32, "sqrt"},
                     BuiltinData{BuiltinType::kStep, ParamType::kF32, "step"},
                     BuiltinData{BuiltinType::kTan, ParamType::kF32, "tan"},

src/tint/writer/hlsl/generator_impl.cc

@@ -2577,7 +2577,6 @@ std::string GeneratorImpl::generate_builtin_name(const sem::Builtin* builtin) {
         case sem::BuiltinType::kReverseBits:  // uint
             return "reversebits";
         case sem::BuiltinType::kSmoothstep:
-        case sem::BuiltinType::kSmoothStep:
             return "smoothstep";
         default:
             diagnostics_.add_error(diag::System::Writer,

src/tint/writer/hlsl/generator_impl_builtin_test.cc

@@ -111,7 +111,6 @@ const ast::CallExpression* GenerateCall(BuiltinType builtin,
         case BuiltinType::kMix:
         case BuiltinType::kFaceForward:
         case BuiltinType::kSmoothstep:
-        case BuiltinType::kSmoothStep:
             return builder->Call(str.str(), "f2", "f2", "f2");
         case BuiltinType::kAll:
         case BuiltinType::kAny:
@@ -232,7 +231,6 @@ INSTANTIATE_TEST_SUITE_P(
                     BuiltinData{BuiltinType::kSin, ParamType::kF32, "sin"},
                     BuiltinData{BuiltinType::kSinh, ParamType::kF32, "sinh"},
                     BuiltinData{BuiltinType::kSmoothstep, ParamType::kF32, "smoothstep"},
-                    BuiltinData{BuiltinType::kSmoothStep, ParamType::kF32, "smoothstep"},
                     BuiltinData{BuiltinType::kSqrt, ParamType::kF32, "sqrt"},
                     BuiltinData{BuiltinType::kStep, ParamType::kF32, "step"},
                     BuiltinData{BuiltinType::kTan, ParamType::kF32, "tan"},

src/tint/writer/msl/generator_impl.cc

@@ -1452,7 +1452,6 @@ std::string GeneratorImpl::generate_builtin_name(const sem::Builtin* builtin) {
             out += "rint";
             break;
         case sem::BuiltinType::kSmoothstep:
-        case sem::BuiltinType::kSmoothStep:
             out += "smoothstep";
             break;
         case sem::BuiltinType::kInverseSqrt:

src/tint/writer/msl/generator_impl_builtin_test.cc

@@ -110,7 +110,6 @@ const ast::CallExpression* GenerateCall(BuiltinType builtin,
         case BuiltinType::kMix:
         case BuiltinType::kFaceForward:
         case BuiltinType::kSmoothstep:
-        case BuiltinType::kSmoothStep:
             return builder->Call(str.str(), "f2", "f2", "f2");
         case BuiltinType::kAll:
         case BuiltinType::kAny:
@@ -262,7 +261,6 @@ INSTANTIATE_TEST_SUITE_P(
         BuiltinData{BuiltinType::kSin, ParamType::kF32, "sin"},
         BuiltinData{BuiltinType::kSinh, ParamType::kF32, "sinh"},
         BuiltinData{BuiltinType::kSmoothstep, ParamType::kF32, "smoothstep"},
-        BuiltinData{BuiltinType::kSmoothStep, ParamType::kF32, "smoothstep"},
         BuiltinData{BuiltinType::kSqrt, ParamType::kF32, "sqrt"},
         BuiltinData{BuiltinType::kStep, ParamType::kF32, "step"},
         BuiltinData{BuiltinType::kTan, ParamType::kF32, "tan"},

src/tint/writer/spirv/builder.cc

@@ -204,7 +204,6 @@ uint32_t builtin_to_glsl_method(const sem::Builtin* builtin) {
         case BuiltinType::kSinh:
             return GLSLstd450Sinh;
         case BuiltinType::kSmoothstep:
-        case BuiltinType::kSmoothStep:
             return GLSLstd450SmoothStep;
         case BuiltinType::kSqrt:
             return GLSLstd450Sqrt;

test/tint/builtins/gen/gen.wgsl.tmpl

@@ -11,9 +11,8 @@ See:
 
 {{- /* For each permutation of each overload of each function... */ -}}
 {{- range .Sem.Builtins -}}
-{{- /* TODO(crbug.com/tint/1483): Remove the bodge below after smoothStep is removed from intrinsics.def */}}
 {{- /* TODO(crbug.com/tint/1536): Remove the bodge below after we support [[extension("extension_name")]] in intrinsics.def */}}
-{{- if not (or (eq .Name "smoothStep") (eq .Name "dot4I8Packed") (eq .Name "dot4U8Packed"))}}
+{{- if not (or (eq .Name "dot4I8Packed") (eq .Name "dot4U8Packed"))}}
 {{-   range .Overloads  -}}
 {{-     range Permute . -}}
 {{- /*    Generate a ./literal/<function>/<permuataion-hash>.wgsl file using

test/tint/builtins/gen/literal/smoothstep/5f615b.wgsl

@@ -1,45 +0,0 @@
-// Copyright 2021 The Tint Authors.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-////////////////////////////////////////////////////////////////////////////////
-// File generated by tools/builtin-gen
-// using the template:
-//   test/tint/builtins/builtins.wgsl.tmpl
-// and the builtin defintion file:
-//   src/tint/builtins.def
-//
-// Do not modify this file directly
-////////////////////////////////////////////////////////////////////////////////
-
-
-// fn smoothStep(vec<4, f32>, vec<4, f32>, vec<4, f32>) -> vec<4, f32>
-fn smoothStep_5f615b() {
-  var res: vec4<f32> = smoothStep(vec4<f32>(), vec4<f32>(), vec4<f32>());
-}
-
-@vertex
-fn vertex_main() -> @builtin(position) vec4<f32> {
-  smoothStep_5f615b();
-  return vec4<f32>();
-}
-
-@fragment
-fn fragment_main() {
-  smoothStep_5f615b();
-}
-
-@compute @workgroup_size(1)
-fn compute_main() {
-  smoothStep_5f615b();
-}

test/tint/builtins/gen/literal/smoothstep/5f615b.wgsl.expected.glsl

@@ -1,53 +0,0 @@
-builtins/gen/literal/smoothstep/5f615b.wgsl:28:24 warning: use of deprecated builtin
-  var res: vec4<f32> = smoothStep(vec4<f32>(), vec4<f32>(), vec4<f32>());
-                       ^^^^^^^^^^
-
-#version 310 es
-
-void smoothStep_5f615b() {
-  vec4 res = smoothstep(vec4(0.0f), vec4(0.0f), vec4(0.0f));
-}
-
-vec4 vertex_main() {
-  smoothStep_5f615b();
-  return vec4(0.0f);
-}
-
-void main() {
-  gl_PointSize = 1.0;
-  vec4 inner_result = vertex_main();
-  gl_Position = inner_result;
-  gl_Position.y = -(gl_Position.y);
-  gl_Position.z = ((2.0f * gl_Position.z) - gl_Position.w);
-  return;
-}
-#version 310 es
-precision mediump float;
-
-void smoothStep_5f615b() {
-  vec4 res = smoothstep(vec4(0.0f), vec4(0.0f), vec4(0.0f));
-}
-
-void fragment_main() {
-  smoothStep_5f615b();
-}
-
-void main() {
-  fragment_main();
-  return;
-}
-#version 310 es
-
-void smoothStep_5f615b() {
-  vec4 res = smoothstep(vec4(0.0f), vec4(0.0f), vec4(0.0f));
-}
-
-void compute_main() {
-  smoothStep_5f615b();
-}
-
-layout(local_size_x = 1, local_size_y = 1, local_size_z = 1) in;
-void main() {
-  compute_main();
-  return;
-}

test/tint/builtins/gen/literal/smoothstep/5f615b.wgsl.expected.hlsl

@@ -1,34 +0,0 @@
-builtins/gen/literal/smoothstep/5f615b.wgsl:28:24 warning: use of deprecated builtin
-  var res: vec4<f32> = smoothStep(vec4<f32>(), vec4<f32>(), vec4<f32>());
-                       ^^^^^^^^^^
-
-void smoothStep_5f615b() {
-  float4 res = smoothstep((0.0f).xxxx, (0.0f).xxxx, (0.0f).xxxx);
-}
-
-struct tint_symbol {
-  float4 value : SV_Position;
-};
-
-float4 vertex_main_inner() {
-  smoothStep_5f615b();
-  return (0.0f).xxxx;
-}
-
-tint_symbol vertex_main() {
-  const float4 inner_result = vertex_main_inner();
-  tint_symbol wrapper_result = (tint_symbol)0;
-  wrapper_result.value = inner_result;
-  return wrapper_result;
-}
-
-void fragment_main() {
-  smoothStep_5f615b();
-  return;
-}
-
-[numthreads(1, 1, 1)]
-void compute_main() {
-  smoothStep_5f615b();
-  return;
-}

test/tint/builtins/gen/literal/smoothstep/5f615b.wgsl.expected.msl

@@ -1,37 +0,0 @@
-builtins/gen/literal/smoothstep/5f615b.wgsl:28:24 warning: use of deprecated builtin
-  var res: vec4<f32> = smoothStep(vec4<f32>(), vec4<f32>(), vec4<f32>());
-                       ^^^^^^^^^^
-
-#include <metal_stdlib>
-
-using namespace metal;
-void smoothStep_5f615b() {
-  float4 res = smoothstep(float4(0.0f), float4(0.0f), float4(0.0f));
-}
-
-struct tint_symbol {
-  float4 value [[position]];
-};
-
-float4 vertex_main_inner() {
-  smoothStep_5f615b();
-  return float4(0.0f);
-}
-
-vertex tint_symbol vertex_main() {
-  float4 const inner_result = vertex_main_inner();
-  tint_symbol wrapper_result = {};
-  wrapper_result.value = inner_result;
-  return wrapper_result;
-}
-
-fragment void fragment_main() {
-  smoothStep_5f615b();
-  return;
-}
-
-kernel void compute_main() {
-  smoothStep_5f615b();
-  return;
-}
-

test/tint/builtins/gen/literal/smoothstep/5f615b.wgsl.expected.spvasm

@@ -1,69 +0,0 @@
-builtins/gen/literal/smoothstep/5f615b.wgsl:28:24 warning: use of deprecated builtin
-  var res: vec4<f32> = smoothStep(vec4<f32>(), vec4<f32>(), vec4<f32>());
-                       ^^^^^^^^^^
-
-; SPIR-V
-; Version: 1.3
-; Generator: Google Tint Compiler; 0
-; Bound: 31
-; Schema: 0
-               OpCapability Shader
-         %14 = OpExtInstImport "GLSL.std.450"
-               OpMemoryModel Logical GLSL450
-               OpEntryPoint Vertex %vertex_main "vertex_main" %value %vertex_point_size
-               OpEntryPoint Fragment %fragment_main "fragment_main"
-               OpEntryPoint GLCompute %compute_main "compute_main"
-               OpExecutionMode %fragment_main OriginUpperLeft
-               OpExecutionMode %compute_main LocalSize 1 1 1
-               OpName %value "value"
-               OpName %vertex_point_size "vertex_point_size"
-               OpName %smoothStep_5f615b "smoothStep_5f615b"
-               OpName %res "res"
-               OpName %vertex_main_inner "vertex_main_inner"
-               OpName %vertex_main "vertex_main"
-               OpName %fragment_main "fragment_main"
-               OpName %compute_main "compute_main"
-               OpDecorate %value BuiltIn Position
-               OpDecorate %vertex_point_size BuiltIn PointSize
-      %float = OpTypeFloat 32
-    %v4float = OpTypeVector %float 4
-%_ptr_Output_v4float = OpTypePointer Output %v4float
-          %5 = OpConstantNull %v4float
-      %value = OpVariable %_ptr_Output_v4float Output %5
-%_ptr_Output_float = OpTypePointer Output %float
-          %8 = OpConstantNull %float
-%vertex_point_size = OpVariable %_ptr_Output_float Output %8
-       %void = OpTypeVoid
-          %9 = OpTypeFunction %void
-%_ptr_Function_v4float = OpTypePointer Function %v4float
-         %17 = OpTypeFunction %v4float
-    %float_1 = OpConstant %float 1
-%smoothStep_5f615b = OpFunction %void None %9
-         %12 = OpLabel
-        %res = OpVariable %_ptr_Function_v4float Function %5
-         %13 = OpExtInst %v4float %14 SmoothStep %5 %5 %5
-               OpStore %res %13
-               OpReturn
-               OpFunctionEnd
-%vertex_main_inner = OpFunction %v4float None %17
-         %19 = OpLabel
-         %20 = OpFunctionCall %void %smoothStep_5f615b
-               OpReturnValue %5
-               OpFunctionEnd
-%vertex_main = OpFunction %void None %9
-         %22 = OpLabel
-         %23 = OpFunctionCall %v4float %vertex_main_inner
-               OpStore %value %23
-               OpStore %vertex_point_size %float_1
-               OpReturn
-               OpFunctionEnd
-%fragment_main = OpFunction %void None %9
-         %26 = OpLabel
-         %27 = OpFunctionCall %void %smoothStep_5f615b
-               OpReturn
-               OpFunctionEnd
-%compute_main = OpFunction %void None %9
-         %29 = OpLabel
-         %30 = OpFunctionCall %void %smoothStep_5f615b
-               OpReturn
-               OpFunctionEnd

test/tint/builtins/gen/literal/smoothstep/5f615b.wgsl.expected.wgsl

@@ -1,23 +0,0 @@
-builtins/gen/literal/smoothstep/5f615b.wgsl:28:24 warning: use of deprecated builtin
-  var res: vec4<f32> = smoothStep(vec4<f32>(), vec4<f32>(), vec4<f32>());
-                       ^^^^^^^^^^
-
-fn smoothStep_5f615b() {
-  var res : vec4<f32> = smoothStep(vec4<f32>(), vec4<f32>(), vec4<f32>());
-}
-
-@vertex
-fn vertex_main() -> @builtin(position) vec4<f32> {
-  smoothStep_5f615b();
-  return vec4<f32>();
-}
-
-@fragment
-fn fragment_main() {
-  smoothStep_5f615b();
-}
-
-@compute @workgroup_size(1)
-fn compute_main() {
-  smoothStep_5f615b();
-}

test/tint/builtins/gen/literal/smoothstep/658be3.wgsl

@@ -1,45 +0,0 @@
-// Copyright 2021 The Tint Authors.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-////////////////////////////////////////////////////////////////////////////////
-// File generated by tools/builtin-gen
-// using the template:
-//   test/tint/builtins/builtins.wgsl.tmpl
-// and the builtin defintion file:
-//   src/tint/builtins.def
-//
-// Do not modify this file directly
-////////////////////////////////////////////////////////////////////////////////
-
-
-// fn smoothStep(vec<3, f32>, vec<3, f32>, vec<3, f32>) -> vec<3, f32>
-fn smoothStep_658be3() {
-  var res: vec3<f32> = smoothStep(vec3<f32>(), vec3<f32>(), vec3<f32>());
-}
-
-@vertex
-fn vertex_main() -> @builtin(position) vec4<f32> {
-  smoothStep_658be3();
-  return vec4<f32>();
-}
-
-@fragment
-fn fragment_main() {
-  smoothStep_658be3();
-}
-
-@compute @workgroup_size(1)
-fn compute_main() {
-  smoothStep_658be3();
-}

test/tint/builtins/gen/literal/smoothstep/658be3.wgsl.expected.glsl

@@ -1,53 +0,0 @@
-builtins/gen/literal/smoothstep/658be3.wgsl:28:24 warning: use of deprecated builtin
-  var res: vec3<f32> = smoothStep(vec3<f32>(), vec3<f32>(), vec3<f32>());
-                       ^^^^^^^^^^
-
-#version 310 es
-
-void smoothStep_658be3() {
-  vec3 res = smoothstep(vec3(0.0f), vec3(0.0f), vec3(0.0f));
-}
-
-vec4 vertex_main() {
-  smoothStep_658be3();
-  return vec4(0.0f);
-}
-
-void main() {
-  gl_PointSize = 1.0;
-  vec4 inner_result = vertex_main();
-  gl_Position = inner_result;
-  gl_Position.y = -(gl_Position.y);
-  gl_Position.z = ((2.0f * gl_Position.z) - gl_Position.w);
-  return;
-}
-#version 310 es
-precision mediump float;
-
-void smoothStep_658be3() {
-  vec3 res = smoothstep(vec3(0.0f), vec3(0.0f), vec3(0.0f));
-}
-
-void fragment_main() {
-  smoothStep_658be3();
-}
-
-void main() {
-  fragment_main();
-  return;
-}
-#version 310 es
-
-void smoothStep_658be3() {
-  vec3 res = smoothstep(vec3(0.0f), vec3(0.0f), vec3(0.0f));
-}
-
-void compute_main() {
-  smoothStep_658be3();
-}
-
-layout(local_size_x = 1, local_size_y = 1, local_size_z = 1) in;
-void main() {
-  compute_main();
-  return;
-}

test/tint/builtins/gen/literal/smoothstep/658be3.wgsl.expected.hlsl

@@ -1,34 +0,0 @@
-builtins/gen/literal/smoothstep/658be3.wgsl:28:24 warning: use of deprecated builtin
-  var res: vec3<f32> = smoothStep(vec3<f32>(), vec3<f32>(), vec3<f32>());
-                       ^^^^^^^^^^
-
-void smoothStep_658be3() {
-  float3 res = smoothstep((0.0f).xxx, (0.0f).xxx, (0.0f).xxx);
-}
-
-struct tint_symbol {
-  float4 value : SV_Position;
-};
-
-float4 vertex_main_inner() {
-  smoothStep_658be3();
-  return (0.0f).xxxx;
-}
-
-tint_symbol vertex_main() {
-  const float4 inner_result = vertex_main_inner();
-  tint_symbol wrapper_result = (tint_symbol)0;
-  wrapper_result.value = inner_result;
-  return wrapper_result;
-}
-
-void fragment_main() {
-  smoothStep_658be3();
-  return;
-}
-
-[numthreads(1, 1, 1)]
-void compute_main() {
-  smoothStep_658be3();
-  return;
-}

test/tint/builtins/gen/literal/smoothstep/658be3.wgsl.expected.msl

@@ -1,37 +0,0 @@
-builtins/gen/literal/smoothstep/658be3.wgsl:28:24 warning: use of deprecated builtin
-  var res: vec3<f32> = smoothStep(vec3<f32>(), vec3<f32>(), vec3<f32>());
-                       ^^^^^^^^^^
-
-#include <metal_stdlib>
-
-using namespace metal;
-void smoothStep_658be3() {
-  float3 res = smoothstep(float3(0.0f), float3(0.0f), float3(0.0f));
-}
-
-struct tint_symbol {
-  float4 value [[position]];
-};
-
-float4 vertex_main_inner() {
-  smoothStep_658be3();
-  return float4(0.0f);
-}
-
-vertex tint_symbol vertex_main() {
-  float4 const inner_result = vertex_main_inner();
-  tint_symbol wrapper_result = {};
-  wrapper_result.value = inner_result;
-  return wrapper_result;
-}
-
-fragment void fragment_main() {
-  smoothStep_658be3();
-  return;
-}
-
-kernel void compute_main() {
-  smoothStep_658be3();
-  return;
-}
-

test/tint/builtins/gen/literal/smoothstep/658be3.wgsl.expected.spvasm

@@ -1,71 +0,0 @@
-builtins/gen/literal/smoothstep/658be3.wgsl:28:24 warning: use of deprecated builtin
-  var res: vec3<f32> = smoothStep(vec3<f32>(), vec3<f32>(), vec3<f32>());
-                       ^^^^^^^^^^
-
-; SPIR-V
-; Version: 1.3
-; Generator: Google Tint Compiler; 0
-; Bound: 33
-; Schema: 0
-               OpCapability Shader
-         %15 = OpExtInstImport "GLSL.std.450"
-               OpMemoryModel Logical GLSL450
-               OpEntryPoint Vertex %vertex_main "vertex_main" %value %vertex_point_size
-               OpEntryPoint Fragment %fragment_main "fragment_main"
-               OpEntryPoint GLCompute %compute_main "compute_main"
-               OpExecutionMode %fragment_main OriginUpperLeft
-               OpExecutionMode %compute_main LocalSize 1 1 1
-               OpName %value "value"
-               OpName %vertex_point_size "vertex_point_size"
-               OpName %smoothStep_658be3 "smoothStep_658be3"
-               OpName %res "res"
-               OpName %vertex_main_inner "vertex_main_inner"
-               OpName %vertex_main "vertex_main"
-               OpName %fragment_main "fragment_main"
-               OpName %compute_main "compute_main"
-               OpDecorate %value BuiltIn Position
-               OpDecorate %vertex_point_size BuiltIn PointSize
-      %float = OpTypeFloat 32
-    %v4float = OpTypeVector %float 4
-%_ptr_Output_v4float = OpTypePointer Output %v4float
-          %5 = OpConstantNull %v4float
-      %value = OpVariable %_ptr_Output_v4float Output %5
-%_ptr_Output_float = OpTypePointer Output %float
-          %8 = OpConstantNull %float
-%vertex_point_size = OpVariable %_ptr_Output_float Output %8
-       %void = OpTypeVoid
-          %9 = OpTypeFunction %void
-    %v3float = OpTypeVector %float 3
-         %16 = OpConstantNull %v3float
-%_ptr_Function_v3float = OpTypePointer Function %v3float
-         %19 = OpTypeFunction %v4float
-    %float_1 = OpConstant %float 1
-%smoothStep_658be3 = OpFunction %void None %9
-         %12 = OpLabel
-        %res = OpVariable %_ptr_Function_v3float Function %16
-         %13 = OpExtInst %v3float %15 SmoothStep %16 %16 %16
-               OpStore %res %13
-               OpReturn
-               OpFunctionEnd
-%vertex_main_inner = OpFunction %v4float None %19
-         %21 = OpLabel
-         %22 = OpFunctionCall %void %smoothStep_658be3
-               OpReturnValue %5
-               OpFunctionEnd
-%vertex_main = OpFunction %void None %9
-         %24 = OpLabel
-         %25 = OpFunctionCall %v4float %vertex_main_inner
-               OpStore %value %25
-               OpStore %vertex_point_size %float_1
-               OpReturn
-               OpFunctionEnd
-%fragment_main = OpFunction %void None %9
-         %28 = OpLabel
-         %29 = OpFunctionCall %void %smoothStep_658be3
-               OpReturn
-               OpFunctionEnd
-%compute_main = OpFunction %void None %9
-         %31 = OpLabel
-         %32 = OpFunctionCall %void %smoothStep_658be3
-               OpReturn
-               OpFunctionEnd

test/tint/builtins/gen/literal/smoothstep/658be3.wgsl.expected.wgsl

@@ -1,23 +0,0 @@
-builtins/gen/literal/smoothstep/658be3.wgsl:28:24 warning: use of deprecated builtin
-  var res: vec3<f32> = smoothStep(vec3<f32>(), vec3<f32>(), vec3<f32>());
-                       ^^^^^^^^^^
-
-fn smoothStep_658be3() {
-  var res : vec3<f32> = smoothStep(vec3<f32>(), vec3<f32>(), vec3<f32>());
-}
-
-@vertex
-fn vertex_main() -> @builtin(position) vec4<f32> {
-  smoothStep_658be3();
-  return vec4<f32>();
-}
-
-@fragment
-fn fragment_main() {
-  smoothStep_658be3();
-}
-
-@compute @workgroup_size(1)
-fn compute_main() {
-  smoothStep_658be3();
-}

test/tint/builtins/gen/literal/smoothstep/c11eef.wgsl

@@ -1,45 +0,0 @@
-// Copyright 2021 The Tint Authors.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-////////////////////////////////////////////////////////////////////////////////
-// File generated by tools/builtin-gen
-// using the template:
-//   test/tint/builtins/builtins.wgsl.tmpl
-// and the builtin defintion file:
-//   src/tint/builtins.def
-//
-// Do not modify this file directly
-////////////////////////////////////////////////////////////////////////////////
-
-
-// fn smoothStep(vec<2, f32>, vec<2, f32>, vec<2, f32>) -> vec<2, f32>
-fn smoothStep_c11eef() {
-  var res: vec2<f32> = smoothStep(vec2<f32>(), vec2<f32>(), vec2<f32>());
-}
-
-@vertex
-fn vertex_main() -> @builtin(position) vec4<f32> {
-  smoothStep_c11eef();
-  return vec4<f32>();
-}
-
-@fragment
-fn fragment_main() {
-  smoothStep_c11eef();
-}
-
-@compute @workgroup_size(1)
-fn compute_main() {
-  smoothStep_c11eef();
-}

test/tint/builtins/gen/literal/smoothstep/c11eef.wgsl.expected.glsl

@@ -1,53 +0,0 @@
-builtins/gen/literal/smoothstep/c11eef.wgsl:28:24 warning: use of deprecated builtin
-  var res: vec2<f32> = smoothStep(vec2<f32>(), vec2<f32>(), vec2<f32>());
-                       ^^^^^^^^^^
-
-#version 310 es
-
-void smoothStep_c11eef() {
-  vec2 res = smoothstep(vec2(0.0f), vec2(0.0f), vec2(0.0f));
-}
-
-vec4 vertex_main() {
-  smoothStep_c11eef();
-  return vec4(0.0f);
-}
-
-void main() {
-  gl_PointSize = 1.0;
-  vec4 inner_result = vertex_main();
-  gl_Position = inner_result;
-  gl_Position.y = -(gl_Position.y);
-  gl_Position.z = ((2.0f * gl_Position.z) - gl_Position.w);
-  return;
-}
-#version 310 es
-precision mediump float;
-
-void smoothStep_c11eef() {
-  vec2 res = smoothstep(vec2(0.0f), vec2(0.0f), vec2(0.0f));
-}
-
-void fragment_main() {
-  smoothStep_c11eef();
-}
-
-void main() {
-  fragment_main();
-  return;
-}
-#version 310 es
-
-void smoothStep_c11eef() {
-  vec2 res = smoothstep(vec2(0.0f), vec2(0.0f), vec2(0.0f));
-}
-
-void compute_main() {
-  smoothStep_c11eef();
-}
-
-layout(local_size_x = 1, local_size_y = 1, local_size_z = 1) in;
-void main() {
-  compute_main();
-  return;
-}

test/tint/builtins/gen/literal/smoothstep/c11eef.wgsl.expected.hlsl

@@ -1,34 +0,0 @@
-builtins/gen/literal/smoothstep/c11eef.wgsl:28:24 warning: use of deprecated builtin
-  var res: vec2<f32> = smoothStep(vec2<f32>(), vec2<f32>(), vec2<f32>());
-                       ^^^^^^^^^^
-
-void smoothStep_c11eef() {
-  float2 res = smoothstep((0.0f).xx, (0.0f).xx, (0.0f).xx);
-}
-
-struct tint_symbol {
-  float4 value : SV_Position;
-};
-
-float4 vertex_main_inner() {
-  smoothStep_c11eef();
-  return (0.0f).xxxx;
-}
-
-tint_symbol vertex_main() {
-  const float4 inner_result = vertex_main_inner();
-  tint_symbol wrapper_result = (tint_symbol)0;
-  wrapper_result.value = inner_result;
-  return wrapper_result;
-}
-
-void fragment_main() {
-  smoothStep_c11eef();
-  return;
-}
-
-[numthreads(1, 1, 1)]
-void compute_main() {
-  smoothStep_c11eef();
-  return;
-}

test/tint/builtins/gen/literal/smoothstep/c11eef.wgsl.expected.msl

@@ -1,37 +0,0 @@
-builtins/gen/literal/smoothstep/c11eef.wgsl:28:24 warning: use of deprecated builtin
-  var res: vec2<f32> = smoothStep(vec2<f32>(), vec2<f32>(), vec2<f32>());
-                       ^^^^^^^^^^
-
-#include <metal_stdlib>
-
-using namespace metal;
-void smoothStep_c11eef() {
-  float2 res = smoothstep(float2(0.0f), float2(0.0f), float2(0.0f));
-}
-
-struct tint_symbol {
-  float4 value [[position]];
-};
-
-float4 vertex_main_inner() {
-  smoothStep_c11eef();
-  return float4(0.0f);
-}
-
-vertex tint_symbol vertex_main() {
-  float4 const inner_result = vertex_main_inner();
-  tint_symbol wrapper_result = {};
-  wrapper_result.value = inner_result;
-  return wrapper_result;
-}
-
-fragment void fragment_main() {
-  smoothStep_c11eef();
-  return;
-}
-
-kernel void compute_main() {
-  smoothStep_c11eef();
-  return;
-}
-

test/tint/builtins/gen/literal/smoothstep/c11eef.wgsl.expected.spvasm

@@ -1,71 +0,0 @@
-builtins/gen/literal/smoothstep/c11eef.wgsl:28:24 warning: use of deprecated builtin
-  var res: vec2<f32> = smoothStep(vec2<f32>(), vec2<f32>(), vec2<f32>());
-                       ^^^^^^^^^^
-
-; SPIR-V
-; Version: 1.3
-; Generator: Google Tint Compiler; 0
-; Bound: 33
-; Schema: 0
-               OpCapability Shader
-         %15 = OpExtInstImport "GLSL.std.450"
-               OpMemoryModel Logical GLSL450
-               OpEntryPoint Vertex %vertex_main "vertex_main" %value %vertex_point_size
-               OpEntryPoint Fragment %fragment_main "fragment_main"
-               OpEntryPoint GLCompute %compute_main "compute_main"
-               OpExecutionMode %fragment_main OriginUpperLeft
-               OpExecutionMode %compute_main LocalSize 1 1 1
-               OpName %value "value"
-               OpName %vertex_point_size "vertex_point_size"
-               OpName %smoothStep_c11eef "smoothStep_c11eef"
-               OpName %res "res"
-               OpName %vertex_main_inner "vertex_main_inner"
-               OpName %vertex_main "vertex_main"
-               OpName %fragment_main "fragment_main"
-               OpName %compute_main "compute_main"
-               OpDecorate %value BuiltIn Position
-               OpDecorate %vertex_point_size BuiltIn PointSize
-      %float = OpTypeFloat 32
-    %v4float = OpTypeVector %float 4
-%_ptr_Output_v4float = OpTypePointer Output %v4float
-          %5 = OpConstantNull %v4float
-      %value = OpVariable %_ptr_Output_v4float Output %5
-%_ptr_Output_float = OpTypePointer Output %float
-          %8 = OpConstantNull %float
-%vertex_point_size = OpVariable %_ptr_Output_float Output %8
-       %void = OpTypeVoid
-          %9 = OpTypeFunction %void
-    %v2float = OpTypeVector %float 2
-         %16 = OpConstantNull %v2float
-%_ptr_Function_v2float = OpTypePointer Function %v2float
-         %19 = OpTypeFunction %v4float
-    %float_1 = OpConstant %float 1
-%smoothStep_c11eef = OpFunction %void None %9
-         %12 = OpLabel
-        %res = OpVariable %_ptr_Function_v2float Function %16
-         %13 = OpExtInst %v2float %15 SmoothStep %16 %16 %16
-               OpStore %res %13
-               OpReturn
-               OpFunctionEnd
-%vertex_main_inner = OpFunction %v4float None %19
-         %21 = OpLabel
-         %22 = OpFunctionCall %void %smoothStep_c11eef
-               OpReturnValue %5
-               OpFunctionEnd
-%vertex_main = OpFunction %void None %9
-         %24 = OpLabel
-         %25 = OpFunctionCall %v4float %vertex_main_inner
-               OpStore %value %25
-               OpStore %vertex_point_size %float_1
-               OpReturn
-               OpFunctionEnd
-%fragment_main = OpFunction %void None %9
-         %28 = OpLabel
-         %29 = OpFunctionCall %void %smoothStep_c11eef
-               OpReturn
-               OpFunctionEnd
-%compute_main = OpFunction %void None %9
-         %31 = OpLabel
-         %32 = OpFunctionCall %void %smoothStep_c11eef
-               OpReturn
-               OpFunctionEnd

test/tint/builtins/gen/literal/smoothstep/c11eef.wgsl.expected.wgsl

@@ -1,23 +0,0 @@
-builtins/gen/literal/smoothstep/c11eef.wgsl:28:24 warning: use of deprecated builtin
-  var res: vec2<f32> = smoothStep(vec2<f32>(), vec2<f32>(), vec2<f32>());
-                       ^^^^^^^^^^
-
-fn smoothStep_c11eef() {
-  var res : vec2<f32> = smoothStep(vec2<f32>(), vec2<f32>(), vec2<f32>());
-}
-
-@vertex
-fn vertex_main() -> @builtin(position) vec4<f32> {
-  smoothStep_c11eef();
-  return vec4<f32>();
-}
-
-@fragment
-fn fragment_main() {
-  smoothStep_c11eef();
-}
-
-@compute @workgroup_size(1)
-fn compute_main() {
-  smoothStep_c11eef();
-}

test/tint/builtins/gen/literal/smoothstep/cb0bfb.wgsl

@@ -1,45 +0,0 @@
-// Copyright 2021 The Tint Authors.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-////////////////////////////////////////////////////////////////////////////////
-// File generated by tools/builtin-gen
-// using the template:
-//   test/tint/builtins/builtins.wgsl.tmpl
-// and the builtin defintion file:
-//   src/tint/builtins.def
-//
-// Do not modify this file directly
-////////////////////////////////////////////////////////////////////////////////
-
-
-// fn smoothStep(f32, f32, f32) -> f32
-fn smoothStep_cb0bfb() {
-  var res: f32 = smoothStep(1.0, 1.0, 1.0);
-}
-
-@vertex
-fn vertex_main() -> @builtin(position) vec4<f32> {
-  smoothStep_cb0bfb();
-  return vec4<f32>();
-}
-
-@fragment
-fn fragment_main() {
-  smoothStep_cb0bfb();
-}
-
-@compute @workgroup_size(1)
-fn compute_main() {
-  smoothStep_cb0bfb();
-}

test/tint/builtins/gen/literal/smoothstep/cb0bfb.wgsl.expected.glsl

@@ -1,53 +0,0 @@
-builtins/gen/literal/smoothstep/cb0bfb.wgsl:28:18 warning: use of deprecated builtin
-  var res: f32 = smoothStep(1.0, 1.0, 1.0);
-                 ^^^^^^^^^^
-
-#version 310 es
-
-void smoothStep_cb0bfb() {
-  float res = smoothstep(1.0f, 1.0f, 1.0f);
-}
-
-vec4 vertex_main() {
-  smoothStep_cb0bfb();
-  return vec4(0.0f);
-}
-
-void main() {
-  gl_PointSize = 1.0;
-  vec4 inner_result = vertex_main();
-  gl_Position = inner_result;
-  gl_Position.y = -(gl_Position.y);
-  gl_Position.z = ((2.0f * gl_Position.z) - gl_Position.w);
-  return;
-}
-#version 310 es
-precision mediump float;
-
-void smoothStep_cb0bfb() {
-  float res = smoothstep(1.0f, 1.0f, 1.0f);
-}
-
-void fragment_main() {
-  smoothStep_cb0bfb();
-}
-
-void main() {
-  fragment_main();
-  return;
-}
-#version 310 es
-
-void smoothStep_cb0bfb() {
-  float res = smoothstep(1.0f, 1.0f, 1.0f);
-}
-
-void compute_main() {
-  smoothStep_cb0bfb();
-}
-
-layout(local_size_x = 1, local_size_y = 1, local_size_z = 1) in;
-void main() {
-  compute_main();
-  return;
-}

test/tint/builtins/gen/literal/smoothstep/cb0bfb.wgsl.expected.hlsl

@@ -1,34 +0,0 @@
-builtins/gen/literal/smoothstep/cb0bfb.wgsl:28:18 warning: use of deprecated builtin
-  var res: f32 = smoothStep(1.0, 1.0, 1.0);
-                 ^^^^^^^^^^
-
-void smoothStep_cb0bfb() {
-  float res = smoothstep(1.0f, 1.0f, 1.0f);
-}
-
-struct tint_symbol {
-  float4 value : SV_Position;
-};
-
-float4 vertex_main_inner() {
-  smoothStep_cb0bfb();
-  return (0.0f).xxxx;
-}
-
-tint_symbol vertex_main() {
-  const float4 inner_result = vertex_main_inner();
-  tint_symbol wrapper_result = (tint_symbol)0;
-  wrapper_result.value = inner_result;
-  return wrapper_result;
-}
-
-void fragment_main() {
-  smoothStep_cb0bfb();
-  return;
-}
-
-[numthreads(1, 1, 1)]
-void compute_main() {
-  smoothStep_cb0bfb();
-  return;
-}

test/tint/builtins/gen/literal/smoothstep/cb0bfb.wgsl.expected.msl

@@ -1,37 +0,0 @@
-builtins/gen/literal/smoothstep/cb0bfb.wgsl:28:18 warning: use of deprecated builtin
-  var res: f32 = smoothStep(1.0, 1.0, 1.0);
-                 ^^^^^^^^^^
-
-#include <metal_stdlib>
-
-using namespace metal;
-void smoothStep_cb0bfb() {
-  float res = smoothstep(1.0f, 1.0f, 1.0f);
-}
-
-struct tint_symbol {
-  float4 value [[position]];
-};
-
-float4 vertex_main_inner() {
-  smoothStep_cb0bfb();
-  return float4(0.0f);
-}
-
-vertex tint_symbol vertex_main() {
-  float4 const inner_result = vertex_main_inner();
-  tint_symbol wrapper_result = {};
-  wrapper_result.value = inner_result;
-  return wrapper_result;
-}
-
-fragment void fragment_main() {
-  smoothStep_cb0bfb();
-  return;
-}
-
-kernel void compute_main() {
-  smoothStep_cb0bfb();
-  return;
-}
-

test/tint/builtins/gen/literal/smoothstep/cb0bfb.wgsl.expected.spvasm

@@ -1,69 +0,0 @@
-builtins/gen/literal/smoothstep/cb0bfb.wgsl:28:18 warning: use of deprecated builtin
-  var res: f32 = smoothStep(1.0, 1.0, 1.0);
-                 ^^^^^^^^^^
-
-; SPIR-V
-; Version: 1.3
-; Generator: Google Tint Compiler; 0
-; Bound: 31
-; Schema: 0
-               OpCapability Shader
-         %14 = OpExtInstImport "GLSL.std.450"
-               OpMemoryModel Logical GLSL450
-               OpEntryPoint Vertex %vertex_main "vertex_main" %value %vertex_point_size
-               OpEntryPoint Fragment %fragment_main "fragment_main"
-               OpEntryPoint GLCompute %compute_main "compute_main"
-               OpExecutionMode %fragment_main OriginUpperLeft
-               OpExecutionMode %compute_main LocalSize 1 1 1
-               OpName %value "value"
-               OpName %vertex_point_size "vertex_point_size"
-               OpName %smoothStep_cb0bfb "smoothStep_cb0bfb"
-               OpName %res "res"
-               OpName %vertex_main_inner "vertex_main_inner"
-               OpName %vertex_main "vertex_main"
-               OpName %fragment_main "fragment_main"
-               OpName %compute_main "compute_main"
-               OpDecorate %value BuiltIn Position
-               OpDecorate %vertex_point_size BuiltIn PointSize
-      %float = OpTypeFloat 32
-    %v4float = OpTypeVector %float 4
-%_ptr_Output_v4float = OpTypePointer Output %v4float
-          %5 = OpConstantNull %v4float
-      %value = OpVariable %_ptr_Output_v4float Output %5
-%_ptr_Output_float = OpTypePointer Output %float
-          %8 = OpConstantNull %float
-%vertex_point_size = OpVariable %_ptr_Output_float Output %8
-       %void = OpTypeVoid
-          %9 = OpTypeFunction %void
-    %float_1 = OpConstant %float 1
-%_ptr_Function_float = OpTypePointer Function %float
-         %18 = OpTypeFunction %v4float
-%smoothStep_cb0bfb = OpFunction %void None %9
-         %12 = OpLabel
-        %res = OpVariable %_ptr_Function_float Function %8
-         %13 = OpExtInst %float %14 SmoothStep %float_1 %float_1 %float_1
-               OpStore %res %13
-               OpReturn
-               OpFunctionEnd
-%vertex_main_inner = OpFunction %v4float None %18
-         %20 = OpLabel
-         %21 = OpFunctionCall %void %smoothStep_cb0bfb
-               OpReturnValue %5
-               OpFunctionEnd
-%vertex_main = OpFunction %void None %9
-         %23 = OpLabel
-         %24 = OpFunctionCall %v4float %vertex_main_inner
-               OpStore %value %24
-               OpStore %vertex_point_size %float_1
-               OpReturn
-               OpFunctionEnd
-%fragment_main = OpFunction %void None %9
-         %26 = OpLabel
-         %27 = OpFunctionCall %void %smoothStep_cb0bfb
-               OpReturn
-               OpFunctionEnd
-%compute_main = OpFunction %void None %9
-         %29 = OpLabel
-         %30 = OpFunctionCall %void %smoothStep_cb0bfb
-               OpReturn
-               OpFunctionEnd

test/tint/builtins/gen/literal/smoothstep/cb0bfb.wgsl.expected.wgsl

@@ -1,23 +0,0 @@
-builtins/gen/literal/smoothstep/cb0bfb.wgsl:28:18 warning: use of deprecated builtin
-  var res: f32 = smoothStep(1.0, 1.0, 1.0);
-                 ^^^^^^^^^^
-
-fn smoothStep_cb0bfb() {
-  var res : f32 = smoothStep(1.0, 1.0, 1.0);
-}
-
-@vertex
-fn vertex_main() -> @builtin(position) vec4<f32> {
-  smoothStep_cb0bfb();
-  return vec4<f32>();
-}
-
-@fragment
-fn fragment_main() {
-  smoothStep_cb0bfb();
-}
-
-@compute @workgroup_size(1)
-fn compute_main() {
-  smoothStep_cb0bfb();
-}