encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tint: use struct instead of tuple for test cases 

googletest doesn't print test parameters properly when they are a tuple
of variants.

Change-Id: I070697bb0118282dd4841df23c936e0171934628
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106380
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
This commit is contained in:
Antonio Maiorano 2022-10-19 17:20:58 +00:00 committed by Dawn LUCI CQ
parent f148f0891b
commit 3fa6887679
1 changed files with 50 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

87
src/tint/resolver/const_eval_binary_op_test.cc
View File

@ -30,6 +30,11 @@ struct Case {
bool overflow; bool overflow;
}; };
struct ErrorCase {
Types lhs;
Types rhs;
};
/// Creates a Case with Values of any type /// Creates a Case with Values of any type
template <typename T, typename U, typename V> template <typename T, typename U, typename V>
Case C(Value<T> lhs, Value<U> rhs, Value<V> expected, bool overflow = false) { Case C(Value<T> lhs, Value<U> rhs, Value<V> expected, bool overflow = false) {
@ -42,12 +47,19 @@ Case C(T lhs, U rhs, V expected, bool overflow = false) {
return Case{Val(lhs), Val(rhs), Val(expected), overflow}; return Case{Val(lhs), Val(rhs), Val(expected), overflow};
} }
/// Prints Case to ostream
static std::ostream& operator<<(std::ostream& o, const Case& c) { static std::ostream& operator<<(std::ostream& o, const Case& c) {
o << "lhs: " << c.lhs << ", rhs: " << c.rhs << ", expected: " << c.expected o << "lhs: " << c.lhs << ", rhs: " << c.rhs << ", expected: " << c.expected
<< ", overflow: " << c.overflow; << ", overflow: " << c.overflow;
return o; return o;
} }
/// Prints ErrorCase to ostream
std::ostream& operator<<(std::ostream& o, const ErrorCase& c) {
o << c.lhs << ", " << c.rhs;
return o;
}
using ResolverConstEvalBinaryOpTest = ResolverTestWithParam<std::tuple<ast::BinaryOp, Case>>; using ResolverConstEvalBinaryOpTest = ResolverTestWithParam<std::tuple<ast::BinaryOp, Case>>;
TEST_P(ResolverConstEvalBinaryOpTest, Test) { TEST_P(ResolverConstEvalBinaryOpTest, Test) {
Enable(ast::Extension::kF16); Enable(ast::Extension::kF16);
@ -856,11 +868,10 @@ TEST_F(ResolverConstEvalTest, BinaryAbstractShiftLeftByNegativeValue_Error) {
} }
// i32/u32 left shift by >= 32 -> error // i32/u32 left shift by >= 32 -> error
using ResolverConstEvalShiftLeftConcreteGeqBitWidthError = using ResolverConstEvalShiftLeftConcreteGeqBitWidthError = ResolverTestWithParam<ErrorCase>;
ResolverTestWithParam<std::tuple<Types, Types>>;
TEST_P(ResolverConstEvalShiftLeftConcreteGeqBitWidthError, Test) { TEST_P(ResolverConstEvalShiftLeftConcreteGeqBitWidthError, Test) {
auto* lhs_expr = ToValueBase(std::get<0>(GetParam()))->Expr(*this); auto* lhs_expr = ToValueBase(GetParam().lhs)->Expr(*this);
auto* rhs_expr = ToValueBase(std::get<1>(GetParam()))->Expr(*this); auto* rhs_expr = ToValueBase(GetParam().rhs)->Expr(*this);
GlobalConst("c", Shl(Source{{1, 1}}, lhs_expr, rhs_expr)); GlobalConst("c", Shl(Source{{1, 1}}, lhs_expr, rhs_expr));
EXPECT_FALSE(r()->Resolve()); EXPECT_FALSE(r()->Resolve());
EXPECT_EQ( EXPECT_EQ(
@ -870,49 +881,49 @@ TEST_P(ResolverConstEvalShiftLeftConcreteGeqBitWidthError, Test) {
INSTANTIATE_TEST_SUITE_P(Test, INSTANTIATE_TEST_SUITE_P(Test,
ResolverConstEvalShiftLeftConcreteGeqBitWidthError, ResolverConstEvalShiftLeftConcreteGeqBitWidthError,
testing::Values( // testing::Values( //
std::make_tuple(Val(0_u), Val(32_u)), // ErrorCase{Val(0_u), Val(32_u)}, //
std::make_tuple(Val(0_u), Val(33_u)), // ErrorCase{Val(0_u), Val(33_u)}, //
std::make_tuple(Val(0_u), Val(34_u)), // ErrorCase{Val(0_u), Val(34_u)}, //
std::make_tuple(Val(0_u), Val(10000_u)), // ErrorCase{Val(0_u), Val(10000_u)}, //
std::make_tuple(Val(0_u), Val(u32::Highest())), // ErrorCase{Val(0_u), Val(u32::Highest())}, //
std::make_tuple(Val(0_i), Val(32_u)), // ErrorCase{Val(0_i), Val(32_u)}, //
std::make_tuple(Val(0_i), Val(33_u)), // ErrorCase{Val(0_i), Val(33_u)}, //
std::make_tuple(Val(0_i), Val(34_u)), // ErrorCase{Val(0_i), Val(34_u)}, //
std::make_tuple(Val(0_i), Val(10000_u)), // ErrorCase{Val(0_i), Val(10000_u)}, //
std::make_tuple(Val(0_i), Val(u32::Highest())), // ErrorCase{Val(0_i), Val(u32::Highest())}, //
std::make_tuple(Val(Negate(0_u)), Val(32_u)), // ErrorCase{Val(Negate(0_u)), Val(32_u)}, //
std::make_tuple(Val(Negate(0_u)), Val(33_u)), // ErrorCase{Val(Negate(0_u)), Val(33_u)}, //
std::make_tuple(Val(Negate(0_u)), Val(34_u)), // ErrorCase{Val(Negate(0_u)), Val(34_u)}, //
std::make_tuple(Val(Negate(0_u)), Val(10000_u)), // ErrorCase{Val(Negate(0_u)), Val(10000_u)}, //
std::make_tuple(Val(Negate(0_u)), Val(u32::Highest())), // ErrorCase{Val(Negate(0_u)), Val(u32::Highest())}, //
std::make_tuple(Val(Negate(0_i)), Val(32_u)), // ErrorCase{Val(Negate(0_i)), Val(32_u)}, //
std::make_tuple(Val(Negate(0_i)), Val(33_u)), // ErrorCase{Val(Negate(0_i)), Val(33_u)}, //
std::make_tuple(Val(Negate(0_i)), Val(34_u)), // ErrorCase{Val(Negate(0_i)), Val(34_u)}, //
std::make_tuple(Val(Negate(0_i)), Val(10000_u)), // ErrorCase{Val(Negate(0_i)), Val(10000_u)}, //
std::make_tuple(Val(Negate(0_i)), Val(u32::Highest())), // ErrorCase{Val(Negate(0_i)), Val(u32::Highest())}, //
std::make_tuple(Val(1_i), Val(32_u)), // ErrorCase{Val(1_i), Val(32_u)}, //
std::make_tuple(Val(1_i), Val(33_u)), // ErrorCase{Val(1_i), Val(33_u)}, //
std::make_tuple(Val(1_i), Val(34_u)), // ErrorCase{Val(1_i), Val(34_u)}, //
std::make_tuple(Val(1_i), Val(10000_u)), // ErrorCase{Val(1_i), Val(10000_u)}, //
std::make_tuple(Val(1_i), Val(u32::Highest())), // ErrorCase{Val(1_i), Val(u32::Highest())}, //
std::make_tuple(Val(1_u), Val(32_u)), // ErrorCase{Val(1_u), Val(32_u)}, //
std::make_tuple(Val(1_u), Val(33_u)), // ErrorCase{Val(1_u), Val(33_u)}, //
std::make_tuple(Val(1_u), Val(34_u)), // ErrorCase{Val(1_u), Val(34_u)}, //
std::make_tuple(Val(1_u), Val(10000_u)), // ErrorCase{Val(1_u), Val(10000_u)}, //
std::make_tuple(Val(1_u), Val(u32::Highest())) // ErrorCase{Val(1_u), Val(u32::Highest())} //
)); ));
// AInt left shift results in sign change error // AInt left shift results in sign change error
using ResolverConstEvalShiftLeftSignChangeError = ResolverTestWithParam<std::tuple<Types, Types>>; using ResolverConstEvalShiftLeftSignChangeError = ResolverTestWithParam<ErrorCase>;
TEST_P(ResolverConstEvalShiftLeftSignChangeError, Test) { TEST_P(ResolverConstEvalShiftLeftSignChangeError, Test) {
auto* lhs_expr = ToValueBase(std::get<0>(GetParam()))->Expr(*this); auto* lhs_expr = ToValueBase(GetParam().lhs)->Expr(*this);
auto* rhs_expr = ToValueBase(std::get<1>(GetParam()))->Expr(*this); auto* rhs_expr = ToValueBase(GetParam().rhs)->Expr(*this);
GlobalConst("c", Shl(Source{{1, 1}}, lhs_expr, rhs_expr)); GlobalConst("c", Shl(Source{{1, 1}}, lhs_expr, rhs_expr));
EXPECT_FALSE(r()->Resolve()); EXPECT_FALSE(r()->Resolve());
EXPECT_EQ(r()->error(), "1:1 error: shift left operation results in sign change"); EXPECT_EQ(r()->error(), "1:1 error: shift left operation results in sign change");
} }
template <typename T> template <typename T>
std::vector<std::tuple<Types, Types>> ShiftLeftSignChangeErrorCases() { std::vector<ErrorCase> ShiftLeftSignChangeErrorCases() {
// Shift type is u32 for non-abstract // Shift type is u32 for non-abstract
using ST = std::conditional_t<IsAbstract<T>, T, u32>; using ST = std::conditional_t<IsAbstract<T>, T, u32>;
using B = BitValues<T>; using B = BitValues<T>;