encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-05-17 04:41:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Directly enable -Wglobal-constructors

Browse Source 
Relying on the config inside //build breaks in projects that use their
own version of //build instead of Chromium's.

Bug: dawn:1405
Change-Id: I18bbf5c6ddce18e6900f5f4b937d91a152bb2b32
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/90524
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
This commit is contained in:
Corentin Wallez 2022-05-18 17:11:17 +00:00 committed by Dawn LUCI CQ
parent 5ff7d67bf3
commit 420b1fd94e
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/dawn/native/BUILD.gn
View File

@ -157,11 +157,13 @@ source_set("sources") {
configs += [ configs += [
":internal", ":internal",
]
# Enable -Wglobal-constructors here only, instead of in internal_config, # Enable -Wglobal-constructors here only, instead of in internal_config,
# because gtest and some other targets don't build with it. # because gtest and some other targets don't build with it.
"//build/config/compiler:wglobal_constructors", if (is_clang) {
] cflags = [ "-Wglobal-constructors" ]
}
# Dependencies that are needed to compile dawn native entry points in # Dependencies that are needed to compile dawn native entry points in
# FooBackend.cpp need to be public deps so they are propagated to the # FooBackend.cpp need to be public deps so they are propagated to the