Enable build/header_guard

This CL enables the build/header_guard lint check. The existing headers
which failed the check were updated, missing headers added. An exclusion
file for the generator templates was added as well.

Bug: dawn:1339
Change-Id: If572e460179ad501293d5d6cf01e0ea900daa979
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86207
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>

include/dawn/CPPLINT.cfg

@@ -1,4 +1,3 @@
-filter=-build/header_guard
 filter=-build/include_order
 filter=-readability/inheritance
 filter=-runtime/explicit

include/dawn/EnumClassBitmasks.h

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef DAWN_ENUM_CLASS_BITMASKS_H_
-#define DAWN_ENUM_CLASS_BITMASKS_H_
+#ifndef INCLUDE_DAWN_ENUMCLASSBITMASKS_H_
+#define INCLUDE_DAWN_ENUMCLASSBITMASKS_H_
 
 #include <type_traits>
 
@@ -153,4 +153,4 @@ namespace dawn {
 
 }  // namespace dawn
 
-#endif  // DAWN_ENUM_CLASS_BITMASKS_H_
+#endif  // INCLUDE_DAWN_ENUMCLASSBITMASKS_H_

include/dawn/dawn_proc.h

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef DAWN_DAWN_PROC_H_
-#define DAWN_DAWN_PROC_H_
+#ifndef INCLUDE_DAWN_DAWN_PROC_H_
+#define INCLUDE_DAWN_DAWN_PROC_H_
 
 #include "dawn/dawn_proc_table.h"
 #include "dawn/webgpu.h"
@@ -33,4 +33,4 @@ WGPU_EXPORT void dawnProcSetProcs(const DawnProcTable* procs);
 }  // extern "C"
 #endif
 
-#endif  // DAWN_DAWN_PROC_H_
+#endif  // INCLUDE_DAWN_DAWN_PROC_H_

include/dawn/dawn_thread_dispatch_proc.h

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef DAWN_DAWN_THREAD_DISPATCH_PROC_H_
-#define DAWN_DAWN_THREAD_DISPATCH_PROC_H_
+#ifndef INCLUDE_DAWN_DAWN_THREAD_DISPATCH_PROC_H_
+#define INCLUDE_DAWN_DAWN_THREAD_DISPATCH_PROC_H_
 
 #include "dawn/dawn_proc.h"
 
@@ -30,4 +30,4 @@ WGPU_EXPORT void dawnProcSetPerThreadProcs(const DawnProcTable* procs);
 }  // extern "C"
 #endif
 
-#endif  // DAWN_DAWN_THREAD_DISPATCH_PROC_H_
+#endif  // INCLUDE_DAWN_DAWN_THREAD_DISPATCH_PROC_H_

include/dawn/dawn_wsi.h

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef DAWN_DAWN_WSI_H_
-#define DAWN_DAWN_WSI_H_
+#ifndef INCLUDE_DAWN_DAWN_WSI_H_
+#define INCLUDE_DAWN_DAWN_WSI_H_
 
 #include <dawn/webgpu.h>
 
@@ -83,4 +83,4 @@ typedef struct {
 } DawnWSIContextVulkan;
 #endif
 
-#endif  // DAWN_DAWN_WSI_H
+#endif  // INCLUDE_DAWN_DAWN_WSI_H_

include/dawn/native/D3D12Backend.h

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef DAWNNATIVE_D3D12BACKEND_H_
-#define DAWNNATIVE_D3D12BACKEND_H_
+#ifndef INCLUDE_DAWN_NATIVE_D3D12BACKEND_H_
+#define INCLUDE_DAWN_NATIVE_D3D12BACKEND_H_
 
 #include <dawn/dawn_wsi.h>
 #include <dawn/native/DawnNative.h>
@@ -108,4 +108,4 @@ namespace dawn::native::d3d12 {
 
 }  // namespace dawn::native::d3d12
 
-#endif  // DAWNNATIVE_D3D12BACKEND_H_
+#endif  // INCLUDE_DAWN_NATIVE_D3D12BACKEND_H_

include/dawn/native/DawnNative.h

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef DAWNNATIVE_DAWNNATIVE_H_
-#define DAWNNATIVE_DAWNNATIVE_H_
+#ifndef INCLUDE_DAWN_NATIVE_DAWNNATIVE_H_
+#define INCLUDE_DAWN_NATIVE_DAWNNATIVE_H_
 
 #include <dawn/dawn_proc_table.h>
 #include <dawn/native/dawn_native_export.h>
@@ -258,4 +258,4 @@ namespace dawn::native {
 // TODO(dawn:824): Remove once the deprecation period is passed.
 namespace dawn_native = dawn::native;
 
-#endif  // DAWNNATIVE_DAWNNATIVE_H_
+#endif  // INCLUDE_DAWN_NATIVE_DAWNNATIVE_H_

include/dawn/native/MetalBackend.h

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef DAWNNATIVE_METALBACKEND_H_
-#define DAWNNATIVE_METALBACKEND_H_
+#ifndef INCLUDE_DAWN_NATIVE_METALBACKEND_H_
+#define INCLUDE_DAWN_NATIVE_METALBACKEND_H_
 
 #include <dawn/dawn_wsi.h>
 #include <dawn/native/DawnNative.h>
@@ -70,4 +70,4 @@ namespace dawn::native::metal {
 
 #pragma clang diagnostic pop
 
-#endif  // DAWNNATIVE_METALBACKEND_H_
+#endif  // INCLUDE_DAWN_NATIVE_METALBACKEND_H_

include/dawn/native/NullBackend.h

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef DAWNNATIVE_NULLBACKEND_H_
-#define DAWNNATIVE_NULLBACKEND_H_
+#ifndef INCLUDE_DAWN_NATIVE_NULLBACKEND_H_
+#define INCLUDE_DAWN_NATIVE_NULLBACKEND_H_
 
 #include <dawn/dawn_wsi.h>
 #include <dawn/native/DawnNative.h>
@@ -22,4 +22,4 @@ namespace dawn::native::null {
     DAWN_NATIVE_EXPORT DawnSwapChainImplementation CreateNativeSwapChainImpl();
 }  // namespace dawn::native::null
 
-#endif  // DAWNNATIVE_NULLBACKEND_H_
+#endif  // INCLUDE_DAWN_NATIVE_NULLBACKEND_H_

include/dawn/native/OpenGLBackend.h

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef DAWNNATIVE_OPENGLBACKEND_H_
-#define DAWNNATIVE_OPENGLBACKEND_H_
+#ifndef INCLUDE_DAWN_NATIVE_OPENGLBACKEND_H_
+#define INCLUDE_DAWN_NATIVE_OPENGLBACKEND_H_
 
 typedef void* EGLImage;
 
@@ -52,4 +52,4 @@ namespace dawn::native::opengl {
 
 }  // namespace dawn::native::opengl
 
-#endif  // DAWNNATIVE_OPENGLBACKEND_H_
+#endif  // INCLUDE_DAWN_NATIVE_OPENGLBACKEND_H_

include/dawn/native/VulkanBackend.h

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef DAWNNATIVE_VULKANBACKEND_H_
-#define DAWNNATIVE_VULKANBACKEND_H_
+#ifndef INCLUDE_DAWN_NATIVE_VULKANBACKEND_H_
+#define INCLUDE_DAWN_NATIVE_VULKANBACKEND_H_
 
 #include <dawn/dawn_wsi.h>
 #include <dawn/native/DawnNative.h>
@@ -137,4 +137,4 @@ namespace dawn::native::vulkan {
 
 }  // namespace dawn::native::vulkan
 
-#endif  // DAWNNATIVE_VULKANBACKEND_H_
+#endif  // INCLUDE_DAWN_NATIVE_VULKANBACKEND_H_

include/dawn/native/dawn_native_export.h

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef DAWNNATIVE_EXPORT_H_
-#define DAWNNATIVE_EXPORT_H_
+#ifndef INCLUDE_DAWN_NATIVE_DAWN_NATIVE_EXPORT_H_
+#define INCLUDE_DAWN_NATIVE_DAWN_NATIVE_EXPORT_H_
 
 #if defined(DAWN_NATIVE_SHARED_LIBRARY)
 #    if defined(_WIN32)
@@ -33,4 +33,4 @@
 #    define DAWN_NATIVE_EXPORT
 #endif  // defined(DAWN_NATIVE_SHARED_LIBRARY)
 
-#endif  // DAWNNATIVE_EXPORT_H_
+#endif  // INCLUDE_DAWN_NATIVE_DAWN_NATIVE_EXPORT_H_

include/dawn/platform/DawnPlatform.h

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef DAWNPLATFORM_DAWNPLATFORM_H_
-#define DAWNPLATFORM_DAWNPLATFORM_H_
+#ifndef INCLUDE_DAWN_PLATFORM_DAWNPLATFORM_H_
+#define INCLUDE_DAWN_PLATFORM_DAWNPLATFORM_H_
 
 #include "dawn/platform/dawn_platform_export.h"
 
@@ -116,4 +116,4 @@ namespace dawn::platform {
 // TODO(dawn:824): Remove once the deprecation period is passed.
 namespace dawn_platform = dawn::platform;
 
-#endif  // DAWNPLATFORM_DAWNPLATFORM_H_
+#endif  // INCLUDE_DAWN_PLATFORM_DAWNPLATFORM_H_

include/dawn/platform/dawn_platform_export.h

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef DAWNPLATFORM_EXPORT_H_
-#define DAWNPLATFORM_EXPORT_H_
+#ifndef INCLUDE_DAWN_PLATFORM_DAWN_PLATFORM_EXPORT_H_
+#define INCLUDE_DAWN_PLATFORM_DAWN_PLATFORM_EXPORT_H_
 
 #if defined(DAWN_PLATFORM_SHARED_LIBRARY)
 #    if defined(_WIN32)
@@ -33,4 +33,4 @@
 #    define DAWN_PLATFORM_EXPORT
 #endif  // defined(DAWN_PLATFORM_SHARED_LIBRARY)
 
-#endif  // DAWNPLATFORM_EXPORT_H_
+#endif  // INCLUDE_DAWN_PLATFORM_DAWN_PLATFORM_EXPORT_H_

include/dawn/wire/Wire.h

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef DAWNWIRE_WIRE_H_
-#define DAWNWIRE_WIRE_H_
+#ifndef INCLUDE_DAWN_WIRE_WIRE_H_
+#define INCLUDE_DAWN_WIRE_WIRE_H_
 
 #include <cstdint>
 #include <limits>
@@ -76,4 +76,4 @@ namespace dawn::wire {
 // TODO(dawn:824): Remove once the deprecation period is passed.
 namespace dawn_wire = dawn::wire;
 
-#endif  // DAWNWIRE_WIRE_H_
+#endif  // INCLUDE_DAWN_WIRE_WIRE_H_

include/dawn/wire/WireClient.h

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef DAWNWIRE_WIRECLIENT_H_
-#define DAWNWIRE_WIRECLIENT_H_
+#ifndef INCLUDE_DAWN_WIRE_WIRECLIENT_H_
+#define INCLUDE_DAWN_WIRE_WIRECLIENT_H_
 
 #include "dawn/dawn_proc_table.h"
 #include "dawn/wire/Wire.h"
@@ -180,4 +180,4 @@ namespace dawn::wire {
     }  // namespace client
 }  // namespace dawn::wire
 
-#endif  // DAWNWIRE_WIRECLIENT_H_
+#endif  // INCLUDE_DAWN_WIRE_WIRECLIENT_H_

include/dawn/wire/WireServer.h

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef DAWNWIRE_WIRESERVER_H_
-#define DAWNWIRE_WIRESERVER_H_
+#ifndef INCLUDE_DAWN_WIRE_WIRESERVER_H_
+#define INCLUDE_DAWN_WIRE_WIRESERVER_H_
 
 #include <memory>
 
@@ -147,4 +147,4 @@ namespace dawn::wire {
 
 }  // namespace dawn::wire
 
-#endif  // DAWNWIRE_WIRESERVER_H_
+#endif  // INCLUDE_DAWN_WIRE_WIRESERVER_H_

include/dawn/wire/dawn_wire_export.h

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#ifndef DAWNWIRE_EXPORT_H_
-#define DAWNWIRE_EXPORT_H_
+#ifndef INCLUDE_DAWN_WIRE_DAWN_WIRE_EXPORT_H_
+#define INCLUDE_DAWN_WIRE_DAWN_WIRE_EXPORT_H_
 
 #if defined(DAWN_WIRE_SHARED_LIBRARY)
 #    if defined(_WIN32)
@@ -33,4 +33,4 @@
 #    define DAWN_WIRE_EXPORT
 #endif  // defined(DAWN_WIRE_SHARED_LIBRARY)
 
-#endif  // DAWNWIRE_EXPORT_H_
+#endif  // INCLUDE_DAWN_WIRE_DAWN_WIRE_EXPORT_H_

include/webgpu/CPPLINT.cfg

@@ -1,2 +1 @@
-filter=-build/header_guard
 filter=-legal/copyright

include/webgpu/webgpu.h

@@ -1 +1,6 @@
+#ifndef INCLUDE_WEBGPU_WEBGPU_H_
+#define INCLUDE_WEBGPU_WEBGPU_H_
+
 #include "dawn/webgpu.h"
+
+#endif  // INCLUDE_WEBGPU_WEBGPU_H_

include/webgpu/webgpu_cpp.h

@@ -1 +1,6 @@
+#ifndef INCLUDE_WEBGPU_WEBGPU_CPP_H_
+#define INCLUDE_WEBGPU_WEBGPU_CPP_H_
+
 #include <dawn/webgpu_cpp.h>
+
+#endif  // INCLUDE_WEBGPU_WEBGPU_CPP_H_