encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

dawn/tests: Remove OverridesWithZeroDefault test 

It's not invalid to have create a shader module using zero-defaulted `override`s as workgroup size parameters.
These can be initialized with non-zero pipeline override values.

Bug: dawn:1504
Change-Id: I2636cbe2d26a6604735b0c8b0f5526bbc14e8ce2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103220
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Shrek Shao <shrekshao@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
This commit is contained in:
Ben Clayton 2022-09-21 16:42:34 +00:00 committed by Dawn LUCI CQ
parent 849dff2ada
commit 4953dabab7
1 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/dawn/tests/end2end/ShaderValidationTests.cpp
View File

@ -32,17 +32,6 @@ override x: u32 = 1u;
override y: u32 = 1u; override y: u32 = 1u;
override z: u32 = 1u; override z: u32 = 1u;
@compute @workgroup_size(x, y, z) fn main() {
_ = 0u;
})");
}
wgpu::ShaderModule SetUpShaderWithZeroDefaultValueConstants() {
return utils::CreateShaderModule(device, R"(
override x: u32 = 0u;
override y: u32 = 0u;
override z: u32 = 0u;
@compute @workgroup_size(x, y, z) fn main() { @compute @workgroup_size(x, y, z) fn main() {
_ = 0u; _ = 0u;
})"); })");
@ -237,12 +226,6 @@ TEST_P(WorkgroupSizeValidationTest, OverridesWithValidDefault) {
} }
} }
// Test workgroup size validation with zero as the overrides default values.
TEST_P(WorkgroupSizeValidationTest, OverridesWithZeroDefault) {
// Error: zero is detected as invalid at shader creation time
ASSERT_DEVICE_ERROR(SetUpShaderWithZeroDefaultValueConstants());
}
// Test workgroup size validation with out-of-limits overrides default values. // Test workgroup size validation with out-of-limits overrides default values.
TEST_P(WorkgroupSizeValidationTest, OverridesWithOutOfLimitsDefault) { TEST_P(WorkgroupSizeValidationTest, OverridesWithOutOfLimitsDefault) {
wgpu::ShaderModule module = SetUpShaderWithOutOfLimitsDefaultValueConstants(); wgpu::ShaderModule module = SetUpShaderWithOutOfLimitsDefaultValueConstants();