encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-05-15 11:51:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Set correct ASAN flags for SPIRV-cross fuzzers

Browse Source 
These fuzzers currently depend on being able to change the signal
handler at runtime, but the default flags being used forbid this. This
CL overrides the upstream default to allow changing the handler.

BUG=chromium:904725,chromium:904712

Change-Id: I68423564981b7f2e39f7c00744b92da982cf19e9
Reviewed-on: https://dawn-review.googlesource.com/c/2361
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Ryan Harrison 2018-11-14 21:04:16 +00:00 committed by Commit Bot service account
parent b5bced2fce
commit 499bc0318d
1 changed files with 26 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/fuzzers/BUILD.gn
View File

@ -42,6 +42,7 @@ if (build_with_chromium) {
test(target_name) { test(target_name) {
forward_variables_from(invoker, forward_variables_from(invoker,
[ [
"asan_options",
"cflags", "cflags",
"cflags_cc", "cflags_cc",
"check_includes", "check_includes",
@ -51,6 +52,10 @@ if (build_with_chromium) {
"sources", "sources",
]) ])
if (defined(asan_options)) {
not_needed([ "asan_options" ])
}
if (!defined(configs)) { if (!defined(configs)) {
configs = [] configs = []
} }
@ -75,6 +80,8 @@ static_library("dawn_spirv_cross_fuzzer_common") {
] ]
} }
# TODO(rharrison): Remove asan_options once signal trap is no longer
# needed.
# Uses Dawn specific options and varies input data # Uses Dawn specific options and varies input data
dawn_fuzzer_test("dawn_spirv_cross_glsl_fast_fuzzer") { dawn_fuzzer_test("dawn_spirv_cross_glsl_fast_fuzzer") {
sources = [ sources = [
@ -83,9 +90,12 @@ dawn_fuzzer_test("dawn_spirv_cross_glsl_fast_fuzzer") {
deps = [ deps = [
":dawn_spirv_cross_fuzzer_common", ":dawn_spirv_cross_fuzzer_common",
] ]
asan_options = [ "allow_user_segv_handler=1" ]
} }
# Varies bother the options and input data # TODO(rharrison): Remove asan_options once signal trap is no longer
# needed.
# Varies both the options and input data
dawn_fuzzer_test("dawn_spirv_cross_glsl_full_fuzzer") { dawn_fuzzer_test("dawn_spirv_cross_glsl_full_fuzzer") {
sources = [ sources = [
"DawnSPIRVCrossGLSLFullFuzzer.cpp", "DawnSPIRVCrossGLSLFullFuzzer.cpp",
@ -93,8 +103,11 @@ dawn_fuzzer_test("dawn_spirv_cross_glsl_full_fuzzer") {
deps = [ deps = [
":dawn_spirv_cross_fuzzer_common", ":dawn_spirv_cross_fuzzer_common",
] ]
asan_options = [ "allow_user_segv_handler=1" ]
} }
# TODO(rharrison): Remove asan_options once signal trap is no longer
# needed.
# Uses Dawn specific options and varies input data # Uses Dawn specific options and varies input data
dawn_fuzzer_test("dawn_spirv_cross_hlsl_fast_fuzzer") { dawn_fuzzer_test("dawn_spirv_cross_hlsl_fast_fuzzer") {
sources = [ sources = [
@ -103,9 +116,12 @@ dawn_fuzzer_test("dawn_spirv_cross_hlsl_fast_fuzzer") {
deps = [ deps = [
":dawn_spirv_cross_fuzzer_common", ":dawn_spirv_cross_fuzzer_common",
] ]
asan_options = [ "allow_user_segv_handler=1" ]
} }
# Varies bother the options and input data # TODO(rharrison): Remove asan_options once signal trap is no longer
# needed.
# Varies both the options and input data
dawn_fuzzer_test("dawn_spirv_cross_hlsl_full_fuzzer") { dawn_fuzzer_test("dawn_spirv_cross_hlsl_full_fuzzer") {
sources = [ sources = [
"DawnSPIRVCrossGLSLFullFuzzer.cpp", "DawnSPIRVCrossGLSLFullFuzzer.cpp",
@ -113,8 +129,11 @@ dawn_fuzzer_test("dawn_spirv_cross_hlsl_full_fuzzer") {
deps = [ deps = [
":dawn_spirv_cross_fuzzer_common", ":dawn_spirv_cross_fuzzer_common",
] ]
asan_options = [ "allow_user_segv_handler=1" ]
} }
# TODO(rharrison): Remove asan_options once signal trap is no longer
# needed.
# Uses Dawn specific options and varies input data # Uses Dawn specific options and varies input data
dawn_fuzzer_test("dawn_spirv_cross_msl_fast_fuzzer") { dawn_fuzzer_test("dawn_spirv_cross_msl_fast_fuzzer") {
sources = [ sources = [
@ -123,9 +142,12 @@ dawn_fuzzer_test("dawn_spirv_cross_msl_fast_fuzzer") {
deps = [ deps = [
":dawn_spirv_cross_fuzzer_common", ":dawn_spirv_cross_fuzzer_common",
] ]
asan_options = [ "allow_user_segv_handler=1" ]
} }
# Varies bother the options and input data # TODO(rharrison): Remove asan_options once signal trap is no longer
# needed.
# Varies both the options and input data
dawn_fuzzer_test("dawn_spirv_cross_msl_full_fuzzer") { dawn_fuzzer_test("dawn_spirv_cross_msl_full_fuzzer") {
sources = [ sources = [
"DawnSPIRVCrossGLSLFullFuzzer.cpp", "DawnSPIRVCrossGLSLFullFuzzer.cpp",
@ -133,6 +155,7 @@ dawn_fuzzer_test("dawn_spirv_cross_msl_full_fuzzer") {
deps = [ deps = [
":dawn_spirv_cross_fuzzer_common", ":dawn_spirv_cross_fuzzer_common",
] ]
asan_options = [ "allow_user_segv_handler=1" ]
} }
dawn_fuzzer_test("dawn_wire_server_and_frontend_fuzzer") { dawn_fuzzer_test("dawn_wire_server_and_frontend_fuzzer") {