encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-07-07 13:45:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Vulkan: discover Vulkan instance versions higher than 1.2

Browse Source 
Previously we would only discover 1.0 or 1.1, meaning that extensions
promoted to core in 1.2 wouldn't be properly discovered.

Bug: chromium:1269882
Change-Id: I38bc211a3358158ba5eccd6b361e4b1173e047fd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/70640
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Corentin Wallez 2021-11-23 23:50:37 +00:00 committed by Dawn LUCI CQ
parent 737d092b28
commit 4c10e82cf8
2 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/dawn_native/vulkan/BackendVk.cpp
View File

@ -264,7 +264,7 @@ namespace dawn_native { namespace vulkan {
// if the instance only supports Vulkan 1.0. Otherwise we set apiVersion to Vulkan 1.2, // if the instance only supports Vulkan 1.0. Otherwise we set apiVersion to Vulkan 1.2,
// treat 1.2 as the highest API version dawn targets. // treat 1.2 as the highest API version dawn targets.
if (mGlobalInfo.apiVersion == VK_MAKE_VERSION(1, 0, 0)) { if (mGlobalInfo.apiVersion == VK_MAKE_VERSION(1, 0, 0)) {
appInfo.apiVersion = mGlobalInfo.apiVersion; appInfo.apiVersion = VK_MAKE_VERSION(1, 0, 0);
} else { } else {
appInfo.apiVersion = VK_MAKE_VERSION(1, 2, 0); appInfo.apiVersion = VK_MAKE_VERSION(1, 2, 0);
} }

12
src/dawn_native/vulkan/VulkanInfo.cpp
View File

@ -67,15 +67,11 @@ namespace dawn_native { namespace vulkan {
// Gather info on available API version // Gather info on available API version
{ {
uint32_t supportedAPIVersion = VK_MAKE_VERSION(1, 0, 0); info.apiVersion = VK_MAKE_VERSION(1, 0, 0);
if (vkFunctions.EnumerateInstanceVersion) { if (vkFunctions.EnumerateInstanceVersion != nullptr) {
vkFunctions.EnumerateInstanceVersion(&supportedAPIVersion); DAWN_TRY(CheckVkSuccess(vkFunctions.EnumerateInstanceVersion(&info.apiVersion),
"vkEnumerateInstanceVersion"));
} }
// Use Vulkan 1.1 if it's available.
info.apiVersion = (supportedAPIVersion >= VK_MAKE_VERSION(1, 1, 0))
? VK_MAKE_VERSION(1, 1, 0)
: VK_MAKE_VERSION(1, 0, 0);
} }
// Gather the info about the instance layers // Gather the info about the instance layers