encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Skip some end2end tests for Vulkan validation layers enable on Windows 

Temporarily skip some tests to make Vulkan validation layers could be
enabled on Windows, these tests are failing on Vulkan with validation
layers enabled.

BUG=dawn:210

Change-Id: I03a6ab6aca94f7c7044cc27cc1ff5d79ad1f88d2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11141
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Li, Hao 2019-09-11 15:08:16 +00:00 committed by Commit Bot service account
parent 03e31edd98
commit 4cc1891039
3 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/tests/end2end/MultisampledRenderingTests.cpp
View File

@ -255,6 +255,10 @@ TEST_P(MultisampledRenderingTest, ResolveInto2DTexture) {
// Test multisampled rendering with depth test works correctly.
TEST_P(MultisampledRenderingTest, MultisampledRenderingWithDepthTest) {
// Test failing on Vulkan with validation layer enabled
// See https://bugs.chromium.org/p/dawn/issues/detail?id=210
DAWN_SKIP_TEST_IF(IsVulkan() && IsBackendValidationEnabled());
constexpr bool kTestDepth = true;
dawn::CommandEncoder commandEncoder = device.CreateCommandEncoder();
dawn::RenderPipeline pipeline = CreateRenderPipelineWithOneOutputForTest(kTestDepth);

12
src/tests/end2end/TextureZeroInitTests.cpp
View File

@ -300,6 +300,10 @@ TEST_P(TextureZeroInitTest, CopyTextureToTextureHalf) {
// This tests the texture with depth attachment and load op load will init depth stencil texture to
// 0s.
TEST_P(TextureZeroInitTest, RenderingLoadingDepth) {
// Test failing on Vulkan with validation layer enabled
// See https://bugs.chromium.org/p/dawn/issues/detail?id=210
DAWN_SKIP_TEST_IF(IsVulkan() && IsBackendValidationEnabled());
dawn::TextureDescriptor srcDescriptor =
CreateTextureDescriptor(1, 1,
dawn::TextureUsage::CopySrc | dawn::TextureUsage::CopyDst |
@ -335,6 +339,10 @@ TEST_P(TextureZeroInitTest, RenderingLoadingDepth) {
// This tests the texture with stencil attachment and load op load will init depth stencil texture
// to 0s.
TEST_P(TextureZeroInitTest, RenderingLoadingStencil) {
// Test failing on Vulkan with validation layer enabled
// See https://bugs.chromium.org/p/dawn/issues/detail?id=210
DAWN_SKIP_TEST_IF(IsVulkan() && IsBackendValidationEnabled());
dawn::TextureDescriptor srcDescriptor =
CreateTextureDescriptor(1, 1,
dawn::TextureUsage::CopySrc | dawn::TextureUsage::CopyDst |
@ -370,6 +378,10 @@ TEST_P(TextureZeroInitTest, RenderingLoadingStencil) {
// This tests the texture with depth stencil attachment and load op load will init depth stencil
// texture to 0s.
TEST_P(TextureZeroInitTest, RenderingLoadingDepthStencil) {
// Test failing on Vulkan with validation layer enabled
// See https://bugs.chromium.org/p/dawn/issues/detail?id=210
DAWN_SKIP_TEST_IF(IsVulkan() && IsBackendValidationEnabled());
dawn::TextureDescriptor srcDescriptor =
CreateTextureDescriptor(1, 1,
dawn::TextureUsage::CopySrc | dawn::TextureUsage::CopyDst |

4
src/tests/end2end/VertexInputTests.cpp
View File

@ -523,6 +523,10 @@ class OptionalVertexInputTest : public DawnTest {};
// Test that vertex input is not required in render pipeline descriptor.
TEST_P(OptionalVertexInputTest, Basic) {
// Test failing on Vulkan with validation layer enabled
// See https://bugs.chromium.org/p/dawn/issues/detail?id=210
DAWN_SKIP_TEST_IF(IsVulkan() && IsBackendValidationEnabled());
utils::BasicRenderPass renderPass = utils::CreateBasicRenderPass(device, 3, 3);
dawn::ShaderModule vsModule =