encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

spirv-reader: disable dumping for known incorrectness 

Bug: tint:1043, tint:1039
Change-Id: I6de89097d166df30bcf573ec77b9af6f09eb3d75
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/59483
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: James Price <jrprice@google.com>
Auto-Submit: David Neto <dneto@google.com>
This commit is contained in:
David Neto 2021-07-26 18:09:59 +00:00 committed by Tint LUCI CQ
parent 1444a2e117
commit 4e4cef90fe
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/reader/spirv/parser_impl_handle_test.cc
View File

@ -260,6 +260,8 @@ TEST_F(SpvParserHandleTest,
EXPECT_EQ(sampler, nullptr); EXPECT_EQ(sampler, nullptr);
EXPECT_EQ(image, nullptr); EXPECT_EQ(image, nullptr);
EXPECT_TRUE(p->error().empty()); EXPECT_TRUE(p->error().empty());
p->DeliberatelyInvalidSpirv(); // WGSL does not have null pointers.
} }
TEST_F(SpvParserHandleTest, TEST_F(SpvParserHandleTest,
@ -589,6 +591,8 @@ TEST_F(SpvParserHandleTest,
ASSERT_TRUE(image != nullptr); ASSERT_TRUE(image != nullptr);
EXPECT_EQ(image->result_id(), 20u); EXPECT_EQ(image->result_id(), 20u);
p->SkipDumpingPending("crbug.com/tint/1039");
} }
TEST_F(SpvParserHandleTest, TEST_F(SpvParserHandleTest,
@ -774,6 +778,8 @@ TEST_F(SpvParserHandleTest,
ASSERT_TRUE(image != nullptr); ASSERT_TRUE(image != nullptr);
EXPECT_EQ(image->result_id(), 20u); EXPECT_EQ(image->result_id(), 20u);
p->SkipDumpingPending("crbug.com/tint/1039");
} }
TEST_F(SpvParserHandleTest, TEST_F(SpvParserHandleTest,
@ -803,6 +809,8 @@ TEST_F(SpvParserHandleTest,
ASSERT_TRUE(image != nullptr); ASSERT_TRUE(image != nullptr);
EXPECT_EQ(image->result_id(), 20u); EXPECT_EQ(image->result_id(), 20u);
p->SkipDumpingPending("crbug.com/tint/1039");
} }
TEST_F(SpvParserHandleTest, TEST_F(SpvParserHandleTest,
@ -837,6 +845,8 @@ TEST_F(SpvParserHandleTest,
ASSERT_TRUE(image != nullptr); ASSERT_TRUE(image != nullptr);
EXPECT_EQ(image->result_id(), 20u); EXPECT_EQ(image->result_id(), 20u);
p->SkipDumpingPending("crbug.com/tint/1039");
} }
TEST_F(SpvParserHandleTest, TEST_F(SpvParserHandleTest,
@ -866,6 +876,8 @@ TEST_F(SpvParserHandleTest,
const auto* image = p->GetMemoryObjectDeclarationForHandle(200, true); const auto* image = p->GetMemoryObjectDeclarationForHandle(200, true);
ASSERT_TRUE(image != nullptr); ASSERT_TRUE(image != nullptr);
EXPECT_EQ(image->result_id(), 20u); EXPECT_EQ(image->result_id(), 20u);
p->SkipDumpingPending("crbug.com/tint/1039");
} }
// Test RegisterHandleUsage, sampled image cases // Test RegisterHandleUsage, sampled image cases