encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-18 01:15:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Have Queue timeline tasks resolve in order

Browse Source 
Use QueueBase to track fences in flight and map requests so that they
can be resolved in the order they were added. Before these tasks were
separately tracked in FenceSignalTracker and MapRequestTracker, so tasks
would be resolving out of order.

Bug: dawn:404
Change-Id: I8b58fb72c99f43bc4593f56e08920d48ac506157
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/29441
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Natasha Lee <natlee@microsoft.com>
This commit is contained in:
Natasha Lee
2020-10-12 22:32:33 +00:00
committed by Commit Bot service account
parent a7b0fdc90f
commit 51af1b428f
19 changed files with 269 additions and 232 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/tests/unittests/validation/FenceValidationTests.cpp
View File

@@ -46,10 +46,6 @@ class FenceValidationTest : public ValidationTest {
fence.OnCompletion(value, ToMockFenceOnCompletionCallback, expectation);
}
void Flush() {
device.Tick();
}
wgpu::Queue queue;
private:
@@ -127,7 +123,7 @@ TEST_F(FenceValidationTest, OnCompletionLargerThanSignaled) {
.Times(1);
fence.OnCompletion(2u, ToMockFenceOnCompletionCallback, nullptr);
Flush();
WaitForAllOperations(device);
}
TEST_F(FenceValidationTest, GetCompletedValueInsideCallback) {
@@ -142,7 +138,7 @@ TEST_F(FenceValidationTest, GetCompletedValueInsideCallback) {
EXPECT_EQ(fence.GetCompletedValue(), 3u);
}));
Flush();
WaitForAllOperations(device);
}
TEST_F(FenceValidationTest, GetCompletedValueAfterCallback) {
@@ -155,7 +151,7 @@ TEST_F(FenceValidationTest, GetCompletedValueAfterCallback) {
EXPECT_CALL(*mockFenceOnCompletionCallback, Call(WGPUFenceCompletionStatus_Success, nullptr))
.Times(1);
Flush();
WaitForAllOperations(device);
EXPECT_EQ(fence.GetCompletedValue(), 2u);
}
@@ -178,12 +174,12 @@ TEST_F(FenceValidationTest, SignalSuccess) {
// Success
queue.Signal(fence, 2);
Flush();
WaitForAllOperations(device);
EXPECT_EQ(fence.GetCompletedValue(), 2u);
// Success increasing fence value by more than 1
queue.Signal(fence, 6);
Flush();
WaitForAllOperations(device);
EXPECT_EQ(fence.GetCompletedValue(), 6u);
}
@@ -211,11 +207,11 @@ TEST_F(FenceValidationTest, DISABLED_SignalWrongQueueDoesNotUpdateValue) {
ASSERT_DEVICE_ERROR(queue2.Signal(fence, 2));
// Fence value should be unchanged.
Flush();
WaitForAllOperations(device);
EXPECT_EQ(fence.GetCompletedValue(), 1u);
// Signaling with 2 on the correct queue should succeed
queue.Signal(fence, 2);
Flush();
WaitForAllOperations(device);
EXPECT_EQ(fence.GetCompletedValue(), 2u);
}