encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-07-05 04:36:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove the use_tint_inspector toggle.

Browse Source 
This CL removes the use_tint_inspector toggle which was deprecated in
favour of the use_tint_generator toggle.

Change-Id: I0d48b0cef4605021e0fcf26b9035faf0da6668f1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/41241
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Auto-Submit: dan sinclair <dsinclair@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
This commit is contained in:
dan sinclair 2021-02-09 20:26:24 +00:00 committed by Commit Bot service account
parent fb0bf70459
commit 52e2b90919
2 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/dawn_native/Toggles.cpp
View File

@ -153,9 +153,6 @@ namespace dawn_native {
{Toggle::UseTintGenerator, {Toggle::UseTintGenerator,
{"use_tint_generator", "Use Tint instead of SPRIV-cross to generate shaders.", {"use_tint_generator", "Use Tint instead of SPRIV-cross to generate shaders.",
"https://crbug.com/dawn/571"}}, "https://crbug.com/dawn/571"}},
{Toggle::UseTintInspector,
{"use_tint_inspector", "Use Tint instead of SPRIV-cross for shader reflection.",
"https://crbug.com/dawn/578"}},
{Toggle::FlushBeforeClientWaitSync, {Toggle::FlushBeforeClientWaitSync,
{"flush_before_client_wait_sync", {"flush_before_client_wait_sync",
"Call glFlush before glClientWaitSync to work around bugs in the latter", "Call glFlush before glClientWaitSync to work around bugs in the latter",
@ -167,20 +164,12 @@ namespace dawn_native {
void TogglesSet::Set(Toggle toggle, bool enabled) { void TogglesSet::Set(Toggle toggle, bool enabled) {
ASSERT(toggle != Toggle::InvalidEnum); ASSERT(toggle != Toggle::InvalidEnum);
if (toggle == Toggle::UseTintInspector)
toggle = Toggle::UseTintGenerator;
const size_t toggleIndex = static_cast<size_t>(toggle); const size_t toggleIndex = static_cast<size_t>(toggle);
toggleBitset.set(toggleIndex, enabled); toggleBitset.set(toggleIndex, enabled);
} }
bool TogglesSet::Has(Toggle toggle) const { bool TogglesSet::Has(Toggle toggle) const {
ASSERT(toggle != Toggle::InvalidEnum); ASSERT(toggle != Toggle::InvalidEnum);
if (toggle == Toggle::UseTintInspector)
toggle = Toggle::UseTintGenerator;
const size_t toggleIndex = static_cast<size_t>(toggle); const size_t toggleIndex = static_cast<size_t>(toggle);
return toggleBitset.test(toggleIndex); return toggleBitset.test(toggleIndex);
} }

1
src/dawn_native/Toggles.h
View File

@ -47,7 +47,6 @@ namespace dawn_native {
MetalEnableVertexPulling, MetalEnableVertexPulling,
DisallowUnsafeAPIs, DisallowUnsafeAPIs,
UseTintGenerator, UseTintGenerator,
UseTintInspector,
FlushBeforeClientWaitSync, FlushBeforeClientWaitSync,
EnumCount, EnumCount,