encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

end2end: Enable DepthReplacing tint tests 

These are fixed by:
https://dawn-review.googlesource.com/c/tint/+/35500

Fixed: tint:329
Change-Id: I33105e392c6dfbe75a4d716fe98805dbe696c2ea
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/35721
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@google.com>
Reviewed-by: Corentin Wallez <cwallez@google.com>
This commit is contained in:
Ben Clayton 2020-12-15 16:33:19 +00:00 committed by Commit Bot service account
parent f46720fe43
commit 56996023fe
3 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/tests/end2end/DepthStencilCopyTests.cpp
View File

@ -27,10 +27,6 @@ class DepthStencilCopyTests : public DawnTest {
void SetUp() override { void SetUp() override {
DawnTest::SetUp(); DawnTest::SetUp();
// TODO(crbug.com/tint/329): SPIR-V output missing DepthReplacing execution mode.
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator") &&
(IsVulkan() || IsOpenGL() || IsOpenGLES()));
// Draw a square in the bottom left quarter of the screen. // Draw a square in the bottom left quarter of the screen.
mVertexModule = utils::CreateShaderModuleFromWGSL(device, R"( mVertexModule = utils::CreateShaderModuleFromWGSL(device, R"(
[[builtin(vertex_idx)]] var<in> VertexIndex : u32; [[builtin(vertex_idx)]] var<in> VertexIndex : u32;

12
src/tests/end2end/MultisampledRenderingTests.cpp
View File

@ -315,10 +315,6 @@ TEST_P(MultisampledRenderingTest, ResolveFromSingleLayerArrayInto2DTexture) {
// Test multisampled rendering with depth test works correctly. // Test multisampled rendering with depth test works correctly.
TEST_P(MultisampledRenderingTest, MultisampledRenderingWithDepthTest) { TEST_P(MultisampledRenderingTest, MultisampledRenderingWithDepthTest) {
// TODO(crbug.com/tint/329): SPIR-V output missing DepthReplacing execution mode.
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator") &&
(IsVulkan() || IsOpenGL() || IsOpenGLES()));
constexpr bool kTestDepth = true; constexpr bool kTestDepth = true;
wgpu::CommandEncoder commandEncoder = device.CreateCommandEncoder(); wgpu::CommandEncoder commandEncoder = device.CreateCommandEncoder();
wgpu::RenderPipeline pipeline = CreateRenderPipelineWithOneOutputForTest(kTestDepth); wgpu::RenderPipeline pipeline = CreateRenderPipelineWithOneOutputForTest(kTestDepth);
@ -674,10 +670,6 @@ TEST_P(MultisampledRenderingTest, MultisampledRenderingWithDepthTestAndSampleMas
// TODO(dawn:491): Find out why this test doesn't work on Windows Intel Vulkan. // TODO(dawn:491): Find out why this test doesn't work on Windows Intel Vulkan.
DAWN_SKIP_TEST_IF(IsWindows() && IsIntel() && IsVulkan()); DAWN_SKIP_TEST_IF(IsWindows() && IsIntel() && IsVulkan());
// TODO(crbug.com/tint/329): SPIR-V output missing DepthReplacing execution mode.
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator") &&
(IsVulkan() || IsOpenGL() || IsOpenGLES()));
constexpr bool kTestDepth = true; constexpr bool kTestDepth = true;
// The second sample is included in the first render pass and it's covered by the triangle. // The second sample is included in the first render pass and it's covered by the triangle.
constexpr uint32_t kSampleMaskGreen = kSecondSampleMaskBit; constexpr uint32_t kSampleMaskGreen = kSecondSampleMaskBit;
@ -940,10 +932,6 @@ TEST_P(MultisampledRenderingTest, MultisampledRenderingWithDepthTestAndAlphaToCo
// algorithm. // algorithm.
DAWN_SKIP_TEST_IF(IsSwiftshader()); DAWN_SKIP_TEST_IF(IsSwiftshader());
// TODO(crbug.com/tint/329): SPIR-V output missing DepthReplacing execution mode.
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator") &&
(IsVulkan() || IsOpenGL() || IsOpenGLES()));
constexpr bool kTestDepth = true; constexpr bool kTestDepth = true;
constexpr uint32_t kSampleMask = 0xFFFFFFFF; constexpr uint32_t kSampleMask = 0xFFFFFFFF;

3
src/tests/end2end/MultisampledSamplingTests.cpp
View File

@ -50,9 +50,6 @@ class MultisampledSamplingTest : public DawnTest {
void SetUp() override { void SetUp() override {
DawnTest::SetUp(); DawnTest::SetUp();
// TODO(crbug.com/tint/329): SPIR-V output missing DepthReplacing execution mode.
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator") &&
(IsVulkan() || IsOpenGL() || IsOpenGLES()));
{ {
utils::ComboRenderPipelineDescriptor desc(device); utils::ComboRenderPipelineDescriptor desc(device);